Adds issueops.Lifecycle — Create, Update, Close, Reopen — reached from the storage handle via store.IssueLifecycle(), implemented once and shared by the CLI and linked library consumers. Three backends implement it and a shared conformance suite asserts them against one spec. The bd CLI's create, update, close and reopen now route through it. Fixes several defects that predate this change and became visible once the write paths were forced to agree: swallowed metadata-edit failures, a claim applied before field validation, missing value validation on title/priority/estimate, silently dropped create edges to missing targets, infra-typed creates landing in the wrong table, a dropped SourceRepo, closed_by_session written but never read, and a compound update writing twice. Behavior changes needing release notes: create with an occupied explicit id now fails instead of silently overwriting; a compound update is one atomic operation with one hook and one version commit; reparenting replaces all parent edges; reopening something not closed reports nothing to do.
61 lines
2 KiB
Go
61 lines
2 KiB
Go
package dberrors
|
|
|
|
import (
|
|
"database/sql"
|
|
"errors"
|
|
"regexp"
|
|
"strings"
|
|
|
|
mysql "github.com/go-sql-driver/mysql"
|
|
)
|
|
|
|
// IsNoRows reports whether err is a "no rows in result set" error — a single-row
|
|
// query (QueryRow/Scan) that matched nothing. Repository Get methods surface a
|
|
// missing row as the bare sql.ErrNoRows; classifying it here lets callers detect
|
|
// a missing row without importing database/sql into higher layers.
|
|
func IsNoRows(err error) bool {
|
|
return errors.Is(err, sql.ErrNoRows)
|
|
}
|
|
|
|
var (
|
|
quotedTableMissingPattern = regexp.MustCompile(`(?i)\btable\s+'[^']+'\s+(doesn't exist|does not exist)\b`)
|
|
unquotedTableMissingPattern = regexp.MustCompile("(?i)^table\\s+`?[^\\s'`]+`?\\s+(doesn't exist|does not exist)\\b")
|
|
)
|
|
|
|
// IsTableNotExist reports whether err is specifically a MySQL/Dolt
|
|
// table-not-found error. It intentionally does not classify missing columns,
|
|
// schemas, or other objects as optional-table absence.
|
|
func IsTableNotExist(err error) bool {
|
|
if err == nil {
|
|
return false
|
|
}
|
|
|
|
var mysqlErr *mysql.MySQLError
|
|
if errors.As(err, &mysqlErr) {
|
|
return mysqlErr.Number == 1146
|
|
}
|
|
|
|
s := strings.ToLower(err.Error())
|
|
return strings.Contains(s, "error 1146") ||
|
|
quotedTableMissingPattern.MatchString(s) ||
|
|
unquotedTableMissingPattern.MatchString(s)
|
|
}
|
|
|
|
// IsMissingForeignKeyTarget reports whether err is the integrity-constraint
|
|
// violation a write hits when it references a row that does not exist: MySQL
|
|
// 1452 (ER_NO_REFERENCED_ROW_2) and its older 1216 (ER_NO_REFERENCED_ROW).
|
|
// It deliberately does not classify 1451 (ER_ROW_IS_REFERENCED_2), which is
|
|
// the opposite direction — deleting a row other rows still point at.
|
|
func IsMissingForeignKeyTarget(err error) bool {
|
|
if err == nil {
|
|
return false
|
|
}
|
|
|
|
var mysqlErr *mysql.MySQLError
|
|
if errors.As(err, &mysqlErr) {
|
|
return mysqlErr.Number == 1452 || mysqlErr.Number == 1216
|
|
}
|
|
|
|
s := strings.ToLower(err.Error())
|
|
return strings.Contains(s, "error 1452") || strings.Contains(s, "error 1216")
|
|
}
|