Rebase of PR #4601 (feat/choose-your-own-backend) onto current origin/main, squashed to a single commit because the original 73-commit history built and then removed the uowStore derisk spike incrementally, which does not replay cleanly over the 125 commits main has since advanced (notably #4679, the ready-work counts fix, which merged to main and is now inherited rather than re-applied). The full pre-rebase history remains on the original branch tip for reference. Contents (multi-backend feature + the six review follow-ups): - bd init --backend=postgres|mysql|sqlite provisioning behind the Dolt-parity seam; the three SQL backends share *sqlkit.Store over pluggable dialects and carry a generated typed-unsupported shell for the non-core surface. - Passwords in init DSNs are redacted before persisting to metadata.json (driver parser + re-parse verification), with a negative-test matrix proving no secret survives (pgdialect + mysql). - The uowStore derisk spike and its report artifacts are removed; the shell generator now lives in internal/storage/unsupportedgen (neutral name). - Compile-time guard `var _ storage.DoltStorage = (*Store)(nil)` on each backend plus a regen-idempotence test keep the generated skip lists honest. - sqlkit exposes CountReadyWork so every SQL backend satisfies storage.ReadyWorkCounter and inherits the shared page-pushed ready-counts path. - Commercial/product names scrubbed from the feature's own code for vendor neutrality. Rebase reconciliations: adopted main's metadata-load hardening in the store factories alongside the backend dispatch; combined the config interface (GetMetadata + ReconcileVersion) and the conformance registrations (ReadyCounts + Claim/lease); took main's versions of the shared-infra concurrency (uow doltserver_tx) and delete-cascade (domain/issue_delete) evolutions; implemented the interface's new UnclaimIssue on sqlkit (delegating to issueops) and added it to the skip lists. Verified: go build (cgo + CGO_ENABLED=0) and go vet clean; unit tests (sqlbuild/issueops/pgdialect/mysql/unsupportedgen) and the SQLite conformance suite green (RunAll, incl. ReadyCounts equivalence and Claim/lease on the real sqlkit backend). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
50 lines
1.5 KiB
Go
50 lines
1.5 KiB
Go
package sqlite
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"fmt"
|
|
"path/filepath"
|
|
|
|
"github.com/steveyegge/beads/internal/configfile"
|
|
"github.com/steveyegge/beads/internal/storage"
|
|
)
|
|
|
|
// NewFromConfig opens the SQLite backend for a workspace, reading the database file
|
|
// path from .beads/metadata.json (default beads.db, relative to the beads dir). SQLite
|
|
// is file-based, so there is no DSN password to manage.
|
|
func NewFromConfig(ctx context.Context, beadsDir string) (storage.DoltStorage, error) {
|
|
cfg, err := configfile.Load(beadsDir)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("sqlite: load config: %w", err)
|
|
}
|
|
path := cfg.GetSQLitePath()
|
|
if path == "" {
|
|
path = "beads.db"
|
|
}
|
|
if !filepath.IsAbs(path) {
|
|
path = filepath.Join(beadsDir, path)
|
|
}
|
|
return Provision(ctx, path)
|
|
}
|
|
|
|
// Provision opens the SQLite database file, applies the schema (idempotent; config
|
|
// seeds on first provision), and returns the store. bd init calls this directly.
|
|
func Provision(ctx context.Context, dbPath string) (storage.DoltStorage, error) {
|
|
if dbPath == "" {
|
|
return nil, fmt.Errorf("sqlite: empty database path")
|
|
}
|
|
d := dsn(dbPath)
|
|
// DDL and seeds are native SQLite; a raw modernc connection (no translation) runs
|
|
// them. The store's own connection goes through the translating dialect.
|
|
raw, err := sql.Open("sqlite", d)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("sqlite: open (raw): %w", err)
|
|
}
|
|
if err := InitSchema(ctx, raw); err != nil {
|
|
_ = raw.Close()
|
|
return nil, fmt.Errorf("sqlite: init schema: %w", err)
|
|
}
|
|
_ = raw.Close()
|
|
return New(ctx, Config{DSN: d})
|
|
}
|