Rebase of PR #4601 (feat/choose-your-own-backend) onto current origin/main, squashed to a single commit because the original 73-commit history built and then removed the uowStore derisk spike incrementally, which does not replay cleanly over the 125 commits main has since advanced (notably #4679, the ready-work counts fix, which merged to main and is now inherited rather than re-applied). The full pre-rebase history remains on the original branch tip for reference. Contents (multi-backend feature + the six review follow-ups): - bd init --backend=postgres|mysql|sqlite provisioning behind the Dolt-parity seam; the three SQL backends share *sqlkit.Store over pluggable dialects and carry a generated typed-unsupported shell for the non-core surface. - Passwords in init DSNs are redacted before persisting to metadata.json (driver parser + re-parse verification), with a negative-test matrix proving no secret survives (pgdialect + mysql). - The uowStore derisk spike and its report artifacts are removed; the shell generator now lives in internal/storage/unsupportedgen (neutral name). - Compile-time guard `var _ storage.DoltStorage = (*Store)(nil)` on each backend plus a regen-idempotence test keep the generated skip lists honest. - sqlkit exposes CountReadyWork so every SQL backend satisfies storage.ReadyWorkCounter and inherits the shared page-pushed ready-counts path. - Commercial/product names scrubbed from the feature's own code for vendor neutrality. Rebase reconciliations: adopted main's metadata-load hardening in the store factories alongside the backend dispatch; combined the config interface (GetMetadata + ReconcileVersion) and the conformance registrations (ReadyCounts + Claim/lease); took main's versions of the shared-infra concurrency (uow doltserver_tx) and delete-cascade (domain/issue_delete) evolutions; implemented the interface's new UnclaimIssue on sqlkit (delegating to issueops) and added it to the skip lists. Verified: go build (cgo + CGO_ENABLED=0) and go vet clean; unit tests (sqlbuild/issueops/pgdialect/mysql/unsupportedgen) and the SQLite conformance suite green (RunAll, incl. ReadyCounts equivalence and Claim/lease on the real sqlkit backend). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
38 lines
1.1 KiB
Go
38 lines
1.1 KiB
Go
package sqlite
|
|
|
|
import (
|
|
"context"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
// TestSeedOnlyOnFirstProvision guards that re-opening a SQLite workspace (InitSchema
|
|
// runs every open) does not resurrect a key the user `config unset`.
|
|
func TestSeedOnlyOnFirstProvision(t *testing.T) {
|
|
ctx := context.Background()
|
|
path := filepath.Join(t.TempDir(), "seed.db")
|
|
|
|
st, err := Provision(ctx, path)
|
|
if err != nil {
|
|
t.Fatalf("Provision: %v", err)
|
|
}
|
|
if v, _ := st.GetConfig(ctx, "auto_compact_enabled"); v != "false" {
|
|
t.Fatalf("first provision: want seeded auto_compact_enabled=false, got %q", v)
|
|
}
|
|
if err := st.DeleteConfig(ctx, "auto_compact_enabled"); err != nil {
|
|
t.Fatalf("DeleteConfig: %v", err)
|
|
}
|
|
if v, _ := st.GetConfig(ctx, "auto_compact_enabled"); v != "" {
|
|
t.Fatalf("after unset: want empty, got %q", v)
|
|
}
|
|
_ = st.Close()
|
|
|
|
st2, err := Provision(ctx, path)
|
|
if err != nil {
|
|
t.Fatalf("re-Provision: %v", err)
|
|
}
|
|
defer st2.Close()
|
|
if v, _ := st2.GetConfig(ctx, "auto_compact_enabled"); v != "" {
|
|
t.Fatalf("REGRESSION: re-provision resurrected an unset key: got %q (want empty)", v)
|
|
}
|
|
}
|