Rebase of PR #4601 (feat/choose-your-own-backend) onto current origin/main, squashed to a single commit because the original 73-commit history built and then removed the uowStore derisk spike incrementally, which does not replay cleanly over the 125 commits main has since advanced (notably #4679, the ready-work counts fix, which merged to main and is now inherited rather than re-applied). The full pre-rebase history remains on the original branch tip for reference. Contents (multi-backend feature + the six review follow-ups): - bd init --backend=postgres|mysql|sqlite provisioning behind the Dolt-parity seam; the three SQL backends share *sqlkit.Store over pluggable dialects and carry a generated typed-unsupported shell for the non-core surface. - Passwords in init DSNs are redacted before persisting to metadata.json (driver parser + re-parse verification), with a negative-test matrix proving no secret survives (pgdialect + mysql). - The uowStore derisk spike and its report artifacts are removed; the shell generator now lives in internal/storage/unsupportedgen (neutral name). - Compile-time guard `var _ storage.DoltStorage = (*Store)(nil)` on each backend plus a regen-idempotence test keep the generated skip lists honest. - sqlkit exposes CountReadyWork so every SQL backend satisfies storage.ReadyWorkCounter and inherits the shared page-pushed ready-counts path. - Commercial/product names scrubbed from the feature's own code for vendor neutrality. Rebase reconciliations: adopted main's metadata-load hardening in the store factories alongside the backend dispatch; combined the config interface (GetMetadata + ReconcileVersion) and the conformance registrations (ReadyCounts + Claim/lease); took main's versions of the shared-infra concurrency (uow doltserver_tx) and delete-cascade (domain/issue_delete) evolutions; implemented the interface's new UnclaimIssue on sqlkit (delegating to issueops) and added it to the skip lists. Verified: go build (cgo + CGO_ENABLED=0) and go vet clean; unit tests (sqlbuild/issueops/pgdialect/mysql/unsupportedgen) and the SQLite conformance suite green (RunAll, incl. ReadyCounts equivalence and Claim/lease on the real sqlkit backend). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
60 lines
2.3 KiB
Go
60 lines
2.3 KiB
Go
// Package sqlite is the SQLite backend for bd: the shared sqlkit.Store bundled with
|
|
// the SQLite dialect and a no-op readiness strategy, plus the non-Dolt markers. It is
|
|
// a pure-Go, file-based, embedded backend (modernc.org/sqlite; no CGO, no server).
|
|
package sqlite
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/steveyegge/beads/internal/storage"
|
|
"github.com/steveyegge/beads/internal/storage/sqlkit"
|
|
)
|
|
|
|
// Backend is the metadata.json backend identifier for this store.
|
|
const Backend = "sqlite"
|
|
|
|
// Store is the SQLite backend: *sqlkit.Store + the generated typed-unsupported shell.
|
|
type Store struct {
|
|
*sqlkit.Store
|
|
unsupportedDoltStorage
|
|
}
|
|
|
|
// Compile-time guard on the generated skip list: the composite backend (real
|
|
// *sqlkit.Store methods plus the typed-unsupported shell) must fully satisfy
|
|
// storage.DoltStorage. This fails the build on skip-list drift — a skipped
|
|
// method sqlkit does not actually implement (missing method), or a method both
|
|
// implemented and stubbed (ambiguous selector) — so no method can silently
|
|
// become "unsupported".
|
|
var _ storage.DoltStorage = (*Store)(nil)
|
|
|
|
// Config configures a SQLite backend. DSN is a modernc.org/sqlite file DSN.
|
|
type Config struct{ DSN string }
|
|
|
|
// New builds the SQLite backend from its strategy bundle: the sqlite dialect and a
|
|
// no-op readiness strategy (issueops maintains is_blocked in-tx, like Dolt).
|
|
func New(ctx context.Context, cfg Config) (*Store, error) {
|
|
base, err := sqlkit.New(ctx, sqlkit.Config{
|
|
Dialect: sqliteDialect{dsn: cfg.DSN},
|
|
Readiness: sqlkit.NoopReadiness{},
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &Store{Store: base}, nil
|
|
}
|
|
|
|
// CommitGraphUnsupported tells cmd/bd's PostRun to skip Dolt-only maintenance.
|
|
func (s *Store) CommitGraphUnsupported() bool { return true }
|
|
|
|
// CommitPending is a no-op on a non-version-controlled backend.
|
|
func (s *Store) CommitPending(_ context.Context, _ string) (bool, error) { return false, nil }
|
|
|
|
// Commit and variants are no-ops on SQLite (writes are already durable per-tx).
|
|
func (s *Store) Commit(_ context.Context, _ string) error { return nil }
|
|
func (s *Store) CommitWithConfig(_ context.Context, _ string) error { return nil }
|
|
func (s *Store) CommitMergeResolution(_ context.Context, _ string) error { return nil }
|
|
|
|
var (
|
|
_ storage.DoltStorage = (*Store)(nil)
|
|
_ storage.NonCommitGraphBackend = (*Store)(nil)
|
|
)
|