beads/.github/workflows
Julian Knutsen 17127ee544
fix(ci-policy): close review leftovers from #7485/#7486 (#7491)
* fix(ci-policy): close review leftovers from #7485/#7486

Follow-ups from maintainer review on the host-tool exec/shell policy
tests and the bazel.yml integration gate:

- host_tool_shell_policy_test.go: recognize indented function headers
  and `function name {` forms when finding a function's closing brace,
  so scripts/test.sh's indented cleanup_shared_server() no longer
  mis-attributes its trailing lines to the wrong function; classify
  same-line `command -v gofmt && gofmt` (and `go`) as the guarded
  presence-check idiom instead of flagging it.
- host_tool_exec_policy_test.go: make condPolarity reject mixed-polarity
  && / || compounds (one recognized side, one not) instead of guessing
  at the recognized side's polarity, which was unsound in both
  directions; add pinning tests documenting the exec-before-gate and
  function-value-helper cases as known, safety-conservative limitations
  rather than bugs. Fixing this exposed a real ungated fallback in
  cmd/bd/scripttest_test.go (a `go build` that could still run under
  Bazel on a prebuilt-binary basename mismatch); fixed by symlinking the
  prebuilt binary under the expected name instead of rebuilding it.
- bazel.yml: bazel-server-storage now honors the `integration` input
  like bazel-integration/bazel-cmd-dolt do, so an explicit "off" skips
  it too (latent today: no caller passes "off"). Updated
  ci_workflow_test.go's policy tests to match.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix(ci-policy): close should-fix B (go command -v guard evasion) on #7491

shellCommandVGuard previously excused go the same as gofmt, but under an
exit-127 host-tool stub `command -v` finds the stub and the guarded exec
still runs, and on a worker genuinely lacking go the exec was silently
skipped -- the worker-dependent behavior this policy exists to ban. Drop
go from the guard entirely, require the guarded exec to sit directly after
the guard's own `&&` (no intervening `;`, `||`, `|`, or leading `!`), and
require an exact gofmt match so a same-prefixed sibling like `gofmt-foo`/
`go-junit-report` can't borrow the guard. Add every should-fix B shape as
a fixture that must still be flagged, plus the generalized gofmt-side
cases (leading `!`, exact-name, post-`;` exec).

Also: correct host_tool_exec_policy_test.go's doc claim that a
function-value helper call site is "not a soundness hole" -- mixed with
one gated direct call site, the invisible function-value call site's
ungated-ness is silently lost and the combined verdict flips to gated;
pinned as review M22. And recognize a function closed by `} >&2` as
ended, so abort-style safety computed inside it does not leak into the
rest of the file (no scoped script has this shape today, but a bare `}`
equality check would silently miss it the moment one does).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
2026-10-11 01:22:48 +00:00
..
bazel-autofix.yml ci: autofix pushes with the gastownhall-autofix App token (no more approve-and-run) (#7215) 2026-10-04 21:27:06 -07:00
bazel-farm.yml ci(bazel): remote repo contents cache: main-push seed, lane readers, nightly verify (#7453) 2026-10-10 02:50:26 +00:00
bazel.yml fix(ci-policy): close review leftovers from #7485/#7486 (#7491) 2026-10-11 01:22:48 +00:00
close-stale-needs.yml ci: add needs-triage inbox labeling (mirrors gastownhall/gascity) (#6622) 2026-09-19 14:37:19 -07:00
deploy-pages-redirect.yml build(deps): bump actions/checkout from 7.0.0 to 7.0.1 (#5016) 2026-07-25 08:52:22 -07:00
docs-autofix.yml ci: autofix pushes with the gastownhall-autofix App token (no more approve-and-run) (#7215) 2026-10-04 21:27:06 -07:00
docs-mintlify.yml ci(bazel): run the conformance e2e tier under Bazel; retire conformance.yml and the docs-mintlify docsync job (#7321) 2026-10-06 22:42:25 +00:00
main.yml ci(bazel): run every Windows/macOS job on Blacksmith; retire the Linux preflight leg and the cross-compiled Windows pair (#7355) 2026-10-07 10:41:14 +00:00
nightly.yml ci(bazel): remote repo contents cache: main-push seed, lane readers, nightly verify (#7453) 2026-10-10 02:50:26 +00:00
nix-build.yml ci: advisory workflows on Blacksmith with restore-only caches, folded matrices, path filters (F7c) (#7147) 2026-10-03 16:03:39 -07:00
pr-risk.yml ci(bazel): run the hook-timeout-backends check under Bazel; test-nix stops running tests (#7357) 2026-10-07 11:05:39 +00:00
pr.yml ci(bazel): remote repo contents cache: main-push seed, lane readers, nightly verify (#7453) 2026-10-10 02:50:26 +00:00
release.yml fix: make release-version checks shell-free (#5614) 2026-10-01 07:46:37 -07:00
remove-needs-info.yml ci: add needs-triage inbox labeling (mirrors gastownhall/gascity) (#6622) 2026-09-19 14:37:19 -07:00
remove-needs-triage.yml ci: add needs-triage inbox labeling (mirrors gastownhall/gascity) (#6622) 2026-09-19 14:37:19 -07:00
request-needs-info.yml ci: add needs-triage inbox labeling (mirrors gastownhall/gascity) (#6622) 2026-09-19 14:37:19 -07:00
test-pypi.yml build(deps): bump the actions group across 1 directory with 3 updates (#5059) 2026-07-25 19:05:02 -07:00
triage-label.yml ci: add needs-triage inbox labeling (mirrors gastownhall/gascity) (#6622) 2026-09-19 14:37:19 -07:00
update-flake-lock.yml chore(deps): bump DeterminateSystems/determinate-nix-action (#6042) 2026-09-02 17:41:12 -07:00
update-vendor-hash.yml ci(bazel): run the hook-timeout-backends check under Bazel; test-nix stops running tests (#7357) 2026-10-07 11:05:39 +00:00
worker-env-autosync.yml ci(rbe): auto-PR a worker-env pin sync when gascity main re-pins (mc-gv9fk) (#7455) 2026-10-10 05:58:24 +00:00