Closes #4991; extracted from PR #5075 per its review (split-merge). The full PR bundled this fix with substantial CI toolchain-identity/host-binding machinery; this commit keeps only the reviewed core: - scripts/ci/pr-lint.sh: after the native golangci-lint pass, add a second pass with GOOS=windows GOARCH=amd64 CGO_ENABLED=0 GOWORK=off (skipped if the native target already matches), so files guarded by //go:build windows && !cgo get linted. - Makefile fmt-check: stop swallowing gofmt's own exit status - a gofmt failure (not just "found unformatted files") now fails the check. - Pin golangci-lint-action from version: latest to v2.10.1 in .github/workflows/pr.yml and .github/workflows/main.yml, and harden the lint invocations with --config=.golangci.yml, --modules-download-mode=readonly, and GOWORK=off. .github/workflows/ci-measurements.yml already pinned golangci-lint to v2.10.1 via `go install ...@v2.10.1`, so no change was needed there. Agent-Signature: claude-fable-5-medium on behalf of maphew Co-authored-by: Ewen Cuthiell <ewencuthiell@gmail.com> |
||
|---|---|---|
| .. | ||
| go-list-test-names | ||
| lib | ||
| detect-package-gates.sh | ||
| gen_proxied_shard_manifest.py | ||
| go-test-shard-names.sh | ||
| go-test-shard-packages.sh | ||
| package-mcp.sh | ||
| package-npm.sh | ||
| pr-core.sh | ||
| pr-lint.sh | ||
| pr-policy.sh | ||