beads/internal/storage/dolt/batch_closer_contract_test.go
Julian Knutsen d801ec43dc
feat(issueops): put every issue capability behind one library surface
Beads had two implementations of most issue verbs: one for the direct route
(the CLI talking to a store it opened itself) and one for the proxied-server
route (the CLI talking through a unit of work over a running Dolt server).
They drifted — different commit messages, different transaction boundaries,
different refusals, occasionally different answers.

Seven role interfaces now live in the leaf package issueops: Lifecycle,
Reader, ReadyClaimer, BatchCloser, DependencyEditor, Commenter and Relations.
Each is reached only through a store accessor, never a constructor, because
the accessor is where the hook and telemetry decorators add their layers.
Three implementations back every role — dolt, embeddeddolt, and the
unit-of-work provider the proxied route uses. Both routes call the same role
for close, dep add/remove/list, comment, ready --claim and update.

A depguard rule (httpapi-domain-boundary) denies internal/storage/domain from
internal/httpapi, so a handler cannot reach uw.IssueUseCase() past the roles
and open a second front door one lint-clean commit at a time.

Behaviour users will notice, all in the CHANGELOG:
  - bd close a b c is one Dolt commit, not three, and --claim-next moved
    inside that transaction so it fires only when something landed
  - the open-children guard moved into the transaction and its hand-rolled
    cmd/bd copy is gone, removing a read-then-write window that made
    bd close <child> <parent> depend on argument order
  - bd dep add --file honours deferred version commit
  - embedded bd comment writes the role's message and author
  - dep verb commit messages are the role's on the direct route

Wisp-sourced dependency edges are restored. Moving bd dep add onto the role
had pinned an edge's SOURCE to the issues plane, and the two routes did not
even fail alike: direct refused with "issue <id> not found", proxied threw an
fk_dep_issue violation. The comment justifying the pin claimed the issues
plane was "the only one its unit-of-work sibling can reach" — that was false;
domain.DependencyUseCase declared a full set of wisp twins with no production
caller. All three implementations now route per edge by the edge's own
source. A mixed request stays one transaction: parent-child-first ordering
and the whole-graph cycle gate span both planes, and a refusal rolls back
both. Behind the role, three bulk add verbs collapsed into one source-routed
AddDependencies, so no plane-pinned variant is left to reach for by mistake.

Six Provenance fields with no production caller were deleted rather than
wired — CloseRequest, CloseBatchRequest, ClaimNextRequest, AddCommentRequest,
AddDependenciesRequest, RemoveDependencyRequest. Each role already composes an
id-bearing message, so a caller could only restate the default and make it
unreachable from production. Two are not caller-settable even in principle:
CloseBatchCommitMessage names what LANDED and ClaimNextCommitMessage names the
id the claim WON. UpdateRequest and ReopenRequest keep theirs; commit messages
users see are unchanged.

Verified: build, vet and gofmt clean; golangci-lint 0 issues; protocol corpus
byte-identical under BEADS_PROTOCOL_REQUIRE_DOLT=1; all twelve
DependencyEditor conformance wirings green (four contract functions against
each implementation); TestEmbeddedDepAddWispSource runs bd dep add <wisp-id>
at the front door and was demonstrated RED against the pinned routing first.
Three internal/storage/dolt failures reproduce on pristine origin/main.

Known gaps are enumerated in the PR description rather than left to be found:
comment listing is on no role, bd dep tree and bd dep cycles have no role,
bd create and bd reopen are on Lifecycle only on the direct route, per-edge
line attribution is lost in bd dep add --file, multi-store bd close
--claim-next rides only the first store's batch, and the is_blocked staging gap
(bd-2y9ke, predates this change). Seven of the eight role interfaces now have a
shared conformance contract in backend/conformance, run at all three
implementations; main's Claimer, added in parallel by #5334, is the eighth and
has none yet.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-04 12:27:56 -07:00

156 lines
5.7 KiB
Go

package dolt
import (
"context"
"testing"
"github.com/steveyegge/beads/backend/conformance"
)
// The server-backed store's wiring of the BatchCloser contract. Each case gets
// its own store, which on this backend is its own copy-on-write branch, so the
// history deltas the atomicity cases take cannot be moved by a sibling.
func TestBatchCloserOutcomesMirrorItemsIndexForIndex(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcmirror")
defer cleanup()
conformance.RunBatchCloserOutcomesMirrorItemsIndexForIndex(t, ctx, fixture)
}
func TestBatchCloserPerItemRefusalIsAResultAndSurvivorsCommit(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcrefusal")
defer cleanup()
conformance.RunBatchCloserPerItemRefusalIsAResultAndSurvivorsCommit(t, ctx, fixture)
}
func TestBatchCloserOutcomeSnapshotIsTheDocumentedShape(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcshape")
defer cleanup()
conformance.RunBatchCloserOutcomeSnapshotIsTheDocumentedShape(t, ctx, fixture)
}
func TestBatchCloserRequestValidationReturnsZeroResultAndChangesNothing(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcvalid")
defer cleanup()
conformance.RunBatchCloserRequestValidationReturnsZeroResultAndChangesNothing(t, ctx, fixture)
}
func TestBatchCloserClaimFilterValueFailureIsARequestValidationFailure(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcbadsort")
defer cleanup()
conformance.RunBatchCloserClaimFilterValueFailureIsARequestValidationFailure(t, ctx, fixture)
}
func TestBatchCloserBackendFailureReturnsNoOutcomes(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcdeadctx")
defer cleanup()
conformance.RunBatchCloserBackendFailureReturnsNoOutcomes(t, ctx, fixture)
}
func TestBatchCloserIdempotentRecloseIsAPerItemSuccess(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcreclose")
defer cleanup()
conformance.RunBatchCloserIdempotentRecloseIsAPerItemSuccess(t, ctx, fixture)
}
func TestBatchCloserAllIdempotentBatchLandsNothing(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcallidem")
defer cleanup()
conformance.RunBatchCloserAllIdempotentBatchLandsNothing(t, ctx, fixture)
}
func TestBatchCloserDuplicateItemRecloseAtItsOwnIndex(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcdup")
defer cleanup()
conformance.RunBatchCloserDuplicateItemRecloseAtItsOwnIndex(t, ctx, fixture)
}
func TestBatchCloserWispItemClosesAndEarnsTheClaim(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcwispclaim")
defer cleanup()
conformance.RunBatchCloserWispItemClosesAndEarnsTheClaim(t, ctx, fixture)
}
func TestBatchCloserDurableHistoryNeverNamesAWisp(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcwisphistory")
defer cleanup()
conformance.RunBatchCloserDurableHistoryNeverNamesAWisp(t, ctx, fixture)
}
func TestBatchCloserForceBypassesOnlyClosePolicy(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcforce")
defer cleanup()
conformance.RunBatchCloserForceBypassesOnlyClosePolicy(t, ctx, fixture)
}
func TestBatchCloserClaimNextHydratesWhenSomethingClosed(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcclaimhit")
defer cleanup()
conformance.RunBatchCloserClaimNextHydratesWhenSomethingClosed(t, ctx, fixture)
}
func TestBatchCloserClaimNextIsNilWhenNothingClosed(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcclaimnone")
defer cleanup()
conformance.RunBatchCloserClaimNextIsNilWhenNothingClosed(t, ctx, fixture)
}
func TestBatchCloserClaimNextIsNilWhenTheFrontIsEmpty(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcclaimempty")
defer cleanup()
conformance.RunBatchCloserClaimNextIsNilWhenTheFrontIsEmpty(t, ctx, fixture)
}
func TestBatchCloserClaimNextSeesAnUnblockingFromItsOwnBatch(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcclaimunblock")
defer cleanup()
conformance.RunBatchCloserClaimNextSeesAnUnblockingFromItsOwnBatch(t, ctx, fixture)
}
func TestBatchCloserRecordsOneHistoryEntryForWhatLanded(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bchistory")
defer cleanup()
conformance.RunBatchCloserRecordsOneHistoryEntryForWhatLanded(t, ctx, fixture)
}
func TestBatchCloserAllRefusedBatchRecordsNoHistory(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcnohistory")
defer cleanup()
conformance.RunBatchCloserAllRefusedBatchRecordsNoHistory(t, ctx, fixture)
}
func TestBatchCloserDoesNotMutateTheCallerRequest(t *testing.T) {
fixture, ctx, cleanup := newDoltBatchCloserFixture(t, "bcsnapshot")
defer cleanup()
conformance.RunBatchCloserDoesNotMutateTheCallerRequest(t, ctx, fixture)
}
func newDoltBatchCloserFixture(t *testing.T, prefix string) (conformance.BatchCloserFixture, context.Context, func()) {
t.Helper()
store, storeCleanup := setupTestStore(t)
ctx, cancel := testContext(t)
closer, err := store.BatchCloser()
if err != nil {
cancel()
storeCleanup()
t.Fatalf("BatchCloser(): %v", err)
}
kit := newDoltRoleFixtureKit(store, prefix)
fixture := conformance.BatchCloserFixture{
IssuePrefix: kit.IssuePrefix,
Closer: closer,
CreateIssue: kit.CreateIssue,
CreateWisp: kit.CreateWisp,
AddDependency: kit.AddDependency,
// Local, because the shared kit exposes no comment hook. Folding it in
// is an S0 follow-up (bd-kue5t); editing the frozen kit from this slice
// would collide with the five running beside it.
AddComment: store.AddComment,
QueryScalar: kit.QueryScalar,
CountHistory: kit.CountHistory,
}
return fixture, ctx, func() {
cancel()
storeCleanup()
}
}