beads/cmd/bd/note.go
Julian Knutsen eb872d33cf
Preflight graph apply blocking cycles (#4384)
* fix: preflight graph apply blocking cycles

* fix: maintainer review fixes for adopted graph-apply cycle PR

Keep dep/link dependency targets read-only: resolveIDForMutation is used
only for the mutated source issue, while the depends-on/link target is
resolved via read-only resolveIDWithRouting so resolving a routed target
never opens a foreign project writable or runs open-time migrations into
its history (bd-6dnrw.32, GH#3231).

Make the embedded graph-apply blocking-cycle preflight mirror the storage
SQL cycle check: its existing-edge walk is restricted to blocking dep
types, so a blocking edge whose return path runs only through an existing
parent-child or waits-for dep is no longer rejected when bd dep add allows
it. The parent->child blocking-path validator keeps the broader
AffectsReadyWork traversal.

Port the blocking-cycle preflight to the domain/proxied-server graph-apply
path and drop the now-redundant per-edge HasCycle probe so embedded and
server modes agree. Remove the dead graphApplyPlanCanSkipSQLCycleChecks
helpers left by the strategy change.

Restore the bulk --no-cycle-check whole-graph rollback test and add routed
read-only-target, parent-child parity, and domain external-ID cycle tests.

---------

Co-authored-by: Eddie the Engineer <ci@beads.test>
2026-06-19 21:31:59 -07:00

129 lines
3.2 KiB
Go

package main
import (
"fmt"
"io"
"os"
"strings"
"github.com/spf13/cobra"
"github.com/steveyegge/beads/internal/ui"
)
var noteCmd = &cobra.Command{
Use: "note <id> [text...]",
GroupID: "issues",
Short: "Append a note to an issue",
Long: `Append a note to an issue's notes field.
Shorthand for 'bd update <id> --append-notes "text"'.
Examples:
bd note gt-abc "Fixed the flaky test"
bd note gt-abc Fixed the flaky test
echo "note from pipe" | bd note gt-abc --stdin
bd note gt-abc --file notes.txt`,
Args: cobra.MinimumNArgs(1),
Run: func(cmd *cobra.Command, args []string) {
CheckReadonly("note")
id := args[0]
textArgs := args[1:]
// Determine note text from args, stdin, or file
stdinFlag, _ := cmd.Flags().GetBool("stdin")
fileFlag, _ := cmd.Flags().GetString("file")
var noteText string
switch {
case stdinFlag:
content, err := io.ReadAll(os.Stdin)
if err != nil {
FatalErrorRespectJSON("reading from stdin: %v", err)
}
noteText = strings.TrimRight(string(content), "\n")
case fileFlag != "":
content, err := readBodyFile(fileFlag)
if err != nil {
FatalErrorRespectJSON("reading file: %v", err)
}
noteText = content
case len(textArgs) > 0:
noteText = strings.Join(textArgs, " ")
default:
FatalErrorRespectJSON("no note text provided (use positional args, --stdin, or --file)")
}
if noteText == "" {
FatalErrorRespectJSON("note text is empty")
}
ctx := rootCtx
result, err := resolveAndGetIssueForMutation(ctx, store, id)
if err != nil {
if result != nil {
result.Close()
}
FatalErrorRespectJSON("resolving %s: %v", id, err)
}
if result == nil || result.Issue == nil {
if result != nil {
result.Close()
}
FatalErrorRespectJSON("issue %s not found", id)
}
defer result.Close()
issue := result.Issue
issueStore := result.Store
if err := validateIssueUpdatable(id, issue); err != nil {
FatalErrorRespectJSON("%s", err)
}
// Append to existing notes
combined := issue.Notes
if combined != "" {
combined += "\n"
}
combined += noteText
updates := map[string]interface{}{
"notes": combined,
}
if err := issueStore.UpdateIssue(ctx, result.ResolvedID, updates, actor); err != nil {
FatalErrorRespectJSON("updating %s: %v", id, err)
}
if err := commitPendingIfEmbedded(ctx, issueStore, actor, doltAutoCommitParams{
Command: "note",
IssueIDs: []string{result.ResolvedID},
}); err != nil {
FatalErrorRespectJSON("failed to commit: %v", err)
}
SetLastTouchedID(result.ResolvedID)
// Re-fetch for display
updatedIssue, _ := issueStore.GetIssue(ctx, result.ResolvedID)
title := ""
if updatedIssue != nil {
title = updatedIssue.Title
}
if jsonOutput {
if updatedIssue != nil {
outputJSON(updatedIssue)
}
} else {
fmt.Printf("%s Note added to %s\n", ui.RenderPass("✓"), formatFeedbackID(result.ResolvedID, title))
}
},
}
func init() {
noteCmd.Flags().Bool("stdin", false, "Read note text from stdin")
noteCmd.Flags().String("file", "", "Read note text from file")
noteCmd.MarkFlagsMutuallyExclusive("stdin", "file")
noteCmd.ValidArgsFunction = issueIDCompletion
rootCmd.AddCommand(noteCmd)
}