beads/internal/gitlab
Harry 99653e0597
fix(trackers): route secret keys through config.yaml in all tracker getConfig methods
Follow-up to #3929 (GitHub tracker fix by @sealocal). The same bug
existed in jira, gitlab, ado, and notion trackers: their getConfig()
methods read every key from the Dolt store, but secret keys (API
tokens, PATs) should never be in the database because it gets pushed
to remotes, triggering secret-scanning blocks.

Changes:
- Add jira.api_token, gitlab.token, ado.pat to the yaml-only key
  list so they are stored in config.yaml (not the Dolt database),
  consistent with github.token and linear.api_key.
- Add IsYamlOnlyKey guard to getConfig() in all four trackers,
  mirroring the pattern in linear/tracker.go and the merged GitHub
  tracker fix.
- Add regression tests (nil-store bypass + yaml-read) for jira,
  gitlab, and ado; defensive yaml-only path test for notion.
- Update existing tests that put secret keys in mock stores to use
  t.Setenv instead, matching the new yaml-only behavior.

Co-Authored-By: sealocal <4951910+sealocal@users.noreply.github.com>
2026-05-15 09:07:12 -07:00
..
client.go fix(gitlab): resolve hardcoded work item type ID and O(n) milestone scan 2026-04-02 21:00:37 -07:00
client_test.go feat: add optional group-level GitLab issue sync (PR #2801) 2026-03-26 19:31:45 -07:00
fieldmapper.go refactor: inline tracker adapters into internal packages 2026-02-14 16:18:37 -08:00
mapping.go fix(gitlab): wire issue link dependencies into sync pull (GH#2645) (#3202) 2026-04-11 21:21:49 -07:00
mapping_test.go feat: GitLab sync — dedup fixes, type filtering, epic→milestone mapping, work item hierarchy (#2889) 2026-04-02 20:58:25 -07:00
tracker.go fix(trackers): route secret keys through config.yaml in all tracker getConfig methods 2026-05-15 09:07:12 -07:00
tracker_test.go fix(trackers): route secret keys through config.yaml in all tracker getConfig methods 2026-05-15 09:07:12 -07:00
types.go fix(gitlab): wire issue link dependencies into sync pull (GH#2645) (#3202) 2026-04-11 21:21:49 -07:00
types_test.go style: run gofmt across entire codebase (bd-nmk12) 2026-02-07 19:35:20 -08:00