Move all pure SQL-text builders shared by issueops (classic) and domain/db (proxied) into one package; both stacks now delegate, so ready/filter/counts query semantics can no longer drift (Seam A). Execution orchestration stays per-stack per the extract-don't-unify decision. Canonical SQL text is classic's; the only proxied-side text deltas are IN-list whitespace. Adversarial re-review (bd-6dnrw.47) verified all 10 attack items with no production divergence, and adds an import-boundary test pinning the layering (domain must never import issueops/sqlbuild) plus a single-use constraint note on LabelSearchPlan.MergeInto. Follow-ups filed: bd-emrs2 (+1-overfetch convention), bd-kzeme (IN-helper consolidation). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
88 lines
3.6 KiB
Go
88 lines
3.6 KiB
Go
// Package sqlbuild holds the pure SQL-text builders shared by the classic
|
|
// issueops stack (production, *sql.Tx) and the domain/db repository stack
|
|
// (proxied-server, Runner). Functions here map (filter, tables) -> (sql, args)
|
|
// and are execution-context-free: no database handles, no transactions.
|
|
//
|
|
// Both stacks must produce identical row sets for identical filters (pinned
|
|
// by the Seam A parity suite in internal/storage/domain/db). Keeping the
|
|
// query text in one place is what prevents the two implementations from
|
|
// drifting; see bd-6dnrw.46 for the unify-vs-duplicate decision. Execution
|
|
// orchestration (issues+wisps merge strategy, hydration, probes) is
|
|
// intentionally NOT unified and stays in each stack.
|
|
package sqlbuild
|
|
|
|
import "strings"
|
|
|
|
// FilterTables configures table names for the filter builders, allowing the
|
|
// same filter logic to target both the issues and wisps table families.
|
|
type FilterTables struct {
|
|
Main string // "issues" or "wisps"
|
|
Labels string // "labels" or "wisp_labels"
|
|
Dependencies string // "dependencies" or "wisp_dependencies"
|
|
Comments string // "comments" or "wisp_comments"
|
|
}
|
|
|
|
var (
|
|
IssuesFilterTables = FilterTables{Main: "issues", Labels: "labels", Dependencies: "dependencies", Comments: "comments"}
|
|
WispsFilterTables = FilterTables{Main: "wisps", Labels: "wisp_labels", Dependencies: "wisp_dependencies", Comments: "wisp_comments"}
|
|
)
|
|
|
|
// DepTargetExpr resolves a dependency row's target across the three
|
|
// mutually-exclusive target columns.
|
|
const DepTargetExpr = "COALESCE(depends_on_issue_id, depends_on_wisp_id, depends_on_external)"
|
|
|
|
// IssueSelectColumns is the canonical column list for full issue hydration.
|
|
// Every query that reads a complete types.Issue should use this constant;
|
|
// the scan side is issueops.ScanIssueFrom, which scans positionally and
|
|
// must stay in column-for-column agreement with this list.
|
|
const IssueSelectColumns = `id, content_hash, title, description, design, acceptance_criteria, notes,
|
|
status, priority, issue_type, assignee, estimated_minutes,
|
|
created_at, created_by, owner, updated_at, started_at, closed_at, external_ref, spec_id,
|
|
compaction_level, compacted_at, compacted_at_commit, original_size, source_repo, close_reason,
|
|
sender, ephemeral, no_history, wisp_type, pinned, is_template,
|
|
await_type, await_id, timeout_ns, waiters,
|
|
mol_type,
|
|
event_kind, actor, target, payload,
|
|
due_at, defer_until,
|
|
work_type, source_system, metadata`
|
|
|
|
// QueryBatchSize bounds IN-clause sizes when long ID lists are folded into
|
|
// WHERE fragments.
|
|
const QueryBatchSize = 200
|
|
|
|
// QualifyColumns prefixes every column in a comma-separated list (e.g.
|
|
// IssueSelectColumns) with the given table qualifier such as "i.".
|
|
func QualifyColumns(columns, prefix string) string {
|
|
raw := strings.ReplaceAll(columns, "\n", " ")
|
|
raw = strings.ReplaceAll(raw, "\t", " ")
|
|
parts := strings.Split(raw, ",")
|
|
for i, p := range parts {
|
|
parts[i] = prefix + strings.TrimSpace(p)
|
|
}
|
|
return strings.Join(parts, ", ")
|
|
}
|
|
|
|
// InPlaceholders renders "?,?,..." and the matching arg slice for an IN clause.
|
|
func InPlaceholders[T ~string](values []T) (string, []any) {
|
|
ph := make([]string, len(values))
|
|
args := make([]any, len(values))
|
|
for i, v := range values {
|
|
ph[i] = "?"
|
|
args[i] = string(v)
|
|
}
|
|
return strings.Join(ph, ","), args
|
|
}
|
|
|
|
// CompactNonEmptyStrings drops empty entries, returning nil when none remain.
|
|
func CompactNonEmptyStrings(values []string) []string {
|
|
if len(values) == 0 {
|
|
return nil
|
|
}
|
|
out := make([]string, 0, len(values))
|
|
for _, value := range values {
|
|
if value != "" {
|
|
out = append(out, value)
|
|
}
|
|
}
|
|
return out
|
|
}
|