* test(cmd/bd): repair the embedded-gated tests that rotted while no lane ran them
These tests skip unless BEADS_TEST_EMBEDDED_DOLT=1 but no CI lane selected
them, so they rotted unseen. Running them shows:
- TestEventsTailFollowReportsTruncationOnTheStream raced on a plain
bytes.Buffer that os/exec's copy goroutine writes while the test polls it.
Use the package's syncBuffer.
- TestCorruptMetadataDiagnosticsRunAndDataFailsLoud still asserted that
doctor and init run on a corrupt metadata.json. #4857 deliberately made
every workspace command refuse instead (pinned for doctor by
TestDoctorRejectsCorruptMetadataBeforeSharedServerChecks). Rewrite it to
the shipped contract as TestEmbeddedCorruptMetadataFailsLoudUntilRestored:
version warns, doctor/list/init refuse naming the file without touching
it, and restoring the file brings the data back.
- dolt_remote_origin_guard_embedded_test.go was tagged
`embeddeddolt && cgo`, a tag no lane sets, so it never compiled in CI
(gazelle left it out of bd_test srcs). Retag it `cgo`, as #4153 did for
its dolt_local_only sibling, and add it to srcs. Drop its four bd doctor
git-origin tests: bd doctor runs no checks on an embedded workspace
(GH#3794), so two could never pass and two passed vacuously on empty
output. Rename the surviving tests into the TestEmbedded* prefix.
Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
* ci(embedded): run every BEADS_TEST_EMBEDDED_DOLT-gated cmd/bd test in the embedded lane
The embedded-Dolt cmd lane selected tests with
grep '^func TestEmbedded' cmd/bd/*_embedded_test.go, and only its two
Bazel targets set BEADS_TEST_EMBEDDED_DOLT. A test that skips without the
variable but missed the name prefix or the file suffix skipped in every
lane and reported green: 92 of them, including #7203's --if-revision CLI
coverage (TestIfRevisionMatchAndMismatch, TestReassignFenceCLI, ...).
- embedded-test-shard.sh and gen_embedded_cmd_shard_manifest.py select
TestEmbedded* by name across cmd/bd/*_test.go, as proxied-test-shard.sh
does, leaving authors one rule.
- Rename the gated tests into the TestEmbedded* prefix
(TestDoctorEmbedded<X> -> TestEmbeddedDoctor<X>) and update every
reference.
- Place the new names with gen_embedded_cmd_shard_manifest.py 100
--weights=duration --write (incremental).
- Add TestEmbeddedGatedTestsRunInTheEmbeddedLane: it walks cmd/bd's tests
for any that reach os.Getenv("BEADS_TEST_EMBEDDED_DOLT") != "1" and fails
if a shard of the lane never lists one. The proxied guard's helpers now
take the variable and the script; a fixture test pins the walk.
Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of Julian Knutsen
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>