beads/scripts/testing_short_tree_test.go
Julian Knutsen d90823480a
ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files (#7414)
* ci(bazel): split //scripts:scripts_test by what it reads; partition //:repo_files

//scripts:scripts_test declared //:repo_files (the whole checkout), so every
PR re-ran it, and it took ~181s on rbe-west. Most of that (60-79s) was
TestBazelGatedLanesNeverRetryFlakyTests line-regexping the --run_under
wrapper's pinned dolt binary (tools/bazel/hermetic_bin/dolt, in every
test's runfiles); it now skips binary files, as git grep -I does.

tools/bazel/go_srcs.py's per-package repo_files block now partitions each
package's files into repo_go_srcs, repo_go_test_srcs, repo_doc_files and
repo_other_files, aggregated at the root; //:repo_files is their union
(same 4679 files). The //scripts tests are split into go_test targets by
what they read (traced per test with strace over a runfiles-shaped tree):

  scripts_test          CI/Bazel policy: //:repo_other_files (+1 Go file)
  shell_scripts_test    script fixtures: //scripts files, a few root files
  go_test_sources_test  _test.go scans: //:repo_go_test_srcs + shard files
  go_sources_test       check-testing-short.sh: every .go file
  tracked_files_test    every tracked file: //:repo_files

Shared helpers move to helpers-only files; TestScriptsTestTargetsPartition-
TheTests fails on a test file in no target or in two. //test/docsync and
the //scripts/repochecks slices declare partitions or single files instead
of //:repo_files where they can.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* ci(bazel): skip only the non-checkout hermetic_bin dir in the flaky-retry walk

Skipping every binary file also stopped scanning tracked binaries (images,
.binpb fixtures). Skip just tools/bazel/hermetic_bin, the --run_under
wrapper's runfiles directory, which is not in the checkout, so the walk's
coverage of tracked files is unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-09 05:13:07 +00:00

33 lines
1.2 KiB
Go

package scripts_test
// check-testing-short.sh over the whole Go tree: //scripts:go_sources_test,
// which declares every .go file (test and non-test) and nothing else. The
// script's own fixture tests are in check_testing_short_test.go.
import (
"os"
"os/exec"
"path/filepath"
"runtime"
"testing"
)
func TestCheckTestingShortPassesOnCleanRepoTree(t *testing.T) {
if runtime.GOOS == "windows" {
t.Skip("checker is a Bash boundary")
}
repo := sourceRepoRoot(t)
// Under Bazel the tree is //:repo_go_srcs and //:repo_go_test_srcs; a tree
// missing the allowlisted call sites would let the scan pass vacuously.
for _, rel := range []string{"internal/hooks/hooks_test.go", "internal/storage/dolt/concurrent_test.go", "internal/workapi/sweep_test.go"} {
if _, err := os.Stat(filepath.Join(repo, filepath.FromSlash(rel))); err != nil {
t.Fatalf("the scanned tree lacks %s, which holds an allowlisted call: %v", rel, err)
}
}
cmd := exec.Command("bash", filepath.Join(repo, "scripts", "check-testing-short.sh"))
cmd.Dir = repo
out, err := cmd.CombinedOutput()
if err != nil {
t.Fatalf("check-testing-short.sh failed on clean repo tree (all 9 allowlist entries must still be recognized): %v\noutput: %s", err, out)
}
}