Opus review of 12c5144ca (HIGH-1, MEDIUM-5):
- Rename the capability token issues.listSort -> issues.list.sort to match
bd-enterprise's client (httpstore/wire/handshake.go:121, DESIGN.txt S4e),
and widen capabilityToken to accept an optional third segment.
- untokenedParameters() now requires the extracted token to be one
Capabilities() actually serves, not just backtick-shaped text. This
catches real false positives that existed in the spec already
(workapi.DefaultReadyLimit, status.custom) which only shape-matched the
old regex; they're added to the pretoken baseline as genuinely
pre-existing untokened parameters.
- Extend the rule to request body members (new
testdata/pretoken_request_body_members.json baseline) and exempt
brand-new operations via a frozen testdata/pretoken_operations.json
snapshot.
- Add TestPretokenBaselinesNeverGrow pinning all three baseline sizes so
a future change can't hand-add an exemption instead of a token.
- Update spec prose for the widened rule scope.
go test ./internal/httpapi/... and the reviewer's pmut.py all pass as
expected: plain/bogus modes go RED, reuse (real-but-unrelated token) stays
green, matching the review's literal ask ("a token must be one advertised
by Capabilities()").
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
195 lines
2.9 KiB
JSON
195 lines
2.9 KiB
JSON
{
|
|
"addComment": [
|
|
"id"
|
|
],
|
|
"claimIssue": [
|
|
"id"
|
|
],
|
|
"claimNextIssue": [
|
|
"assignee",
|
|
"exclude_label",
|
|
"exclude_type",
|
|
"has_metadata_key",
|
|
"include_deferred",
|
|
"include_ephemeral",
|
|
"label",
|
|
"label_any",
|
|
"label_pattern",
|
|
"label_regex",
|
|
"metadata_field",
|
|
"parent",
|
|
"priority",
|
|
"sort",
|
|
"type",
|
|
"unassigned"
|
|
],
|
|
"closeIssue": [
|
|
"id"
|
|
],
|
|
"compareAndSetMetadata": [
|
|
"id"
|
|
],
|
|
"countDependencyEdges": [
|
|
"direction",
|
|
"issue_id",
|
|
"status",
|
|
"type"
|
|
],
|
|
"countIssues": [
|
|
"assignee",
|
|
"closed_after",
|
|
"closed_before",
|
|
"created_after",
|
|
"created_before",
|
|
"desc_contains",
|
|
"empty_description",
|
|
"group_by",
|
|
"has_metadata_key",
|
|
"id",
|
|
"include_ephemeral",
|
|
"include_infra",
|
|
"label",
|
|
"label_any",
|
|
"metadata_field",
|
|
"no_assignee",
|
|
"no_labels",
|
|
"notes_contains",
|
|
"priority",
|
|
"priority_max",
|
|
"priority_min",
|
|
"status",
|
|
"title",
|
|
"title_contains",
|
|
"type",
|
|
"updated_after",
|
|
"updated_before"
|
|
],
|
|
"countReadyWork": [
|
|
"assignee",
|
|
"exclude_label",
|
|
"exclude_type",
|
|
"has_metadata_key",
|
|
"include_deferred",
|
|
"include_ephemeral",
|
|
"label",
|
|
"label_any",
|
|
"label_pattern",
|
|
"label_regex",
|
|
"metadata_field",
|
|
"parent",
|
|
"priority",
|
|
"type",
|
|
"unassigned"
|
|
],
|
|
"forgetMemory": [
|
|
"key"
|
|
],
|
|
"getDependencyTree": [
|
|
"direction",
|
|
"max_depth",
|
|
"root_id",
|
|
"status"
|
|
],
|
|
"getIssue": [
|
|
"brief_deps",
|
|
"id",
|
|
"include_comments",
|
|
"include_dependents"
|
|
],
|
|
"getMemory": [
|
|
"key"
|
|
],
|
|
"getSetting": [
|
|
"key"
|
|
],
|
|
"getStats": [
|
|
"assignee",
|
|
"skip_blocked"
|
|
],
|
|
"listBlockingAnnotations": [
|
|
"issue_id"
|
|
],
|
|
"listDependencies": [
|
|
"issue_id",
|
|
"type"
|
|
],
|
|
"listEvents": [
|
|
"limit",
|
|
"since"
|
|
],
|
|
"listIssues": [
|
|
"all",
|
|
"assignee",
|
|
"brief",
|
|
"created_after",
|
|
"created_before",
|
|
"cursor",
|
|
"exclude_label",
|
|
"has_metadata_key",
|
|
"include_ephemeral",
|
|
"include_gates",
|
|
"include_infra",
|
|
"include_templates",
|
|
"label",
|
|
"label_any",
|
|
"limit",
|
|
"metadata_field",
|
|
"parent",
|
|
"status",
|
|
"type"
|
|
],
|
|
"listMemories": [
|
|
"search"
|
|
],
|
|
"listReadyWork": [
|
|
"assignee",
|
|
"brief",
|
|
"exclude_label",
|
|
"exclude_type",
|
|
"has_metadata_key",
|
|
"include_deferred",
|
|
"include_ephemeral",
|
|
"label",
|
|
"label_any",
|
|
"label_pattern",
|
|
"label_regex",
|
|
"limit",
|
|
"metadata_field",
|
|
"parent",
|
|
"priority",
|
|
"sort",
|
|
"type",
|
|
"unassigned"
|
|
],
|
|
"listRelatedIssues": [
|
|
"direction",
|
|
"id",
|
|
"type"
|
|
],
|
|
"queryIssues": [
|
|
"all",
|
|
"limit",
|
|
"q",
|
|
"reverse",
|
|
"sort"
|
|
],
|
|
"releaseIssue": [
|
|
"id"
|
|
],
|
|
"reopenIssue": [
|
|
"id"
|
|
],
|
|
"setSetting": [
|
|
"key"
|
|
],
|
|
"unsetSetting": [
|
|
"key"
|
|
],
|
|
"updateIssue": [
|
|
"id"
|
|
],
|
|
"watchEvents": [
|
|
"Last-Event-ID",
|
|
"since"
|
|
]
|
|
}
|