beads/docs
Steve Yegge e97839a2e1
feat(lease): land the leasing stack + schema v54 (claim-TTL, heartbeat, reclaim) (#4537)
* fix(dolt): retry mutate+commit methods on serialization conflict (1213/1205)

ClaimIssue, ClaimReadyIssue, UpdateIssue and CloseIssue each hand-rolled
their own tx (BeginTx + DOLT_ADD/DOLT_COMMIT + Commit) outside
withRetryTx, so a concurrent writer that lost Dolt's optimistic
commit-time merge surfaced MySQL 1213/1205 as a hard failure instead of
retrying. Dolt has no real row locking — FOR UPDATE / SKIP LOCKED are
parse-only no-ops (https://www.dolthub.com/blog/2023-10-23-hold-my-beer/)
— so retry is the only safety net under N concurrent workers. These four
are the work-queue hot paths: `bd ready --claim`, claim, update, close.

Move each body into a withRetryTx closure (which owns BeginTx and the
final Commit and retries serialization failures with backoff), preserving
the single-tx CAS/mutation + DOLT_COMMIT atomicity exactly. On retry,
ClaimReadyIssue re-scans the ready front from a fresh snapshot and claims
the next available issue.

Tested: TestEmbeddedReadyClaimConcurrent, TestEmbeddedReadyConcurrent,
TestEmbeddedCloseConcurrent, TestEmbeddedUpdateConcurrent and the
non-concurrent embedded Update/Close/Ready tests pass; build + vet clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* test(dolt): add concurrent work-queue drain test (Gas Station claim invariant)

N workers concurrently dequeue one shared ready-front via ClaimReadyIssue
until empty; asserts every issue claimed exactly once, none stranded, no
double-claims, and no serialization error ever surfaces (withRetryTx absorbs
the 1213/1205 from the claim-CAS cell collision). This is the regression guard
for the multi-agent claim queue that #4491 makes safe.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(lease): claim-TTL + heartbeat + reclaim for dead-worker recovery

Gas Station v1.1 (wy-5r9j). A claim was previously permanent: a worker that
died mid-task stranded its issue in_progress forever. This adds a lease so a
claim can expire and be recovered.

Schema (migration 0054): add lease_expires_at, heartbeat_at (DATETIME) and
row_lock (BIGINT) to issues (and wisps, for uniform issueops routing), plus
idx_issues_lease for the reaper scan. assignee doubles as the lease owner.

Lifecycle (shared issueops, so both server-mode DoltStore and EmbeddedDoltStore
get it):
  - Claim stamps lease_expires_at = now + TTL (default 5m, WithLeaseTTL to
    override), heartbeat_at = now, and a fresh row_lock.
  - bd heartbeat <id> — owner-only; pushes the lease forward and rewrites
    row_lock. Fails (ErrNotClaimable/ErrAlreadyClaimed) once the lease is gone.
  - bd reclaim --older-than <dur> — reverts in_progress issues whose lease
    expired more than <dur> ago back to ready (clears assignee/started_at,
    records a lease_reclaimed event). Default grace 2×TTL.

The row_lock trick: Dolt has no row locking and merges concurrent commits
cell-by-cell, so a heartbeat (writes heartbeat_at) racing a reclaim (writes
status) would silently cell-merge into a zombie — an open/unassigned issue that
still carries the worker's fresh heartbeat. Every mutating path (claim, close,
update, heartbeat, reclaim) now rewrites the shared row_lock cell, forcing the
loser to a 1213/1205 serialization conflict that withRetryTx replays. All lease
paths are withRetryTx/withConn wrapped.

Tests (real Dolt): TestRowLockForcesConflictOnDisjointCellWrites proves the bug
without row_lock (silent merge to zombie) and correctness with it (conflict);
TestConcurrentHeartbeatReclaimClose is the integration race (live workers
heartbeat+close vs a continuous reaper vs dead workers) asserting exactly-once,
no lost close, no zombie; plus claim/heartbeat/reclaim unit coverage on both
backends.

Note: lease columns are second-granular DATETIME (Dolt rounds), so sub-second
TTLs are meaningless — production TTL is minutes. Heartbeat writes a Dolt
commit, so cadence must stay ≪ claim cadence to avoid history bloat.

Fixes the test coupling in TestMigration0053PromotesRigWisps, which assumed the
rig-wisp repair was always LatestVersion().

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* ci+docs: allowlist lease stress tests; scope the row_lock invariant comment

- Add TestConcurrentWorkQueueDrain and TestConcurrentHeartbeatReclaimClose
  to the check-testing-short.sh allowlist; both are real-Dolt runtime/stress
  skips and were failing ci-pr-policy.
- freshRowLock doc said "EVERY mutating path" rewrites row_lock, which
  overstates it. Scope it to status/ownership/lease-mutating paths (the set
  the reclaim/heartbeat races care about) and document the invariant + why
  orthogonal-cell writers (is_blocked, compaction, deps, rename, reopen) are
  intentionally exempt, so a future writer does not silently reintroduce the
  zombie-merge bug.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(show): surface lease_expires_at/heartbeat_at in bd show (--json + text) (wy-9cdw)

Migration 0054 added lease_expires_at/heartbeat_at (and internal row_lock) to
the issues/wisps tables for the claim/heartbeat/reclaim leasing feature, but
bd show could not observe lease state — you had to drop to raw SQL.

- types.Issue: add LeaseExpiresAt/HeartbeatAt (*time.Time, omitempty), matching
  the StartedAt nullable-timestamp convention. row_lock stays unexported.
- sqlbuild.IssueSelectColumns: append lease_expires_at, heartbeat_at to the
  canonical hydration list (flows to every stack via the shared constant).
- issueops.ScanIssueFrom: scan + map the two nullable columns (before the
  trailing extra dests, keeping positional parity across all scan sites).
- bd show text view: emit a muted 'Lease: expires <rel> (heartbeat <rel> ago)'
  line only for in_progress issues holding an active lease; add formatTimeUntil
  as the forward-looking mirror of formatTimeAgo.
- types_test: assert lease keys appear when set, are omitted when nil, and that
  row_lock is never surfaced.

* fix(lease): settle v54 review blockers

Address #4537 review blockers before landing v54: keep heartbeat off wisps in both backends, keep direct status/assignee updates from leaving stale leases, guard the down migration, and emit reclaim JSON as snake_case.

Agent-Signature: codex-gpt-5.5-high on behalf of matt wilkie

* fix(lease): cover lease fields in tests and hooks

Agent-Signature: codex-gpt-5.5-high on behalf of matt wilkie

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: matt wilkie <maphew@gmail.com>
2026-07-03 23:28:55 -07:00
..
adr fix(init): guard JSONL init against remote history 2026-06-22 15:28:38 -07:00
design Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
staged-for-removal Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
ADAPTIVE_IDS.md feat: support issue_id_mode=counter for sequential IDs (#2013) 2026-02-22 23:49:46 -08:00
ADO_CONFIG.md Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
ADVANCED.md docs: fix broken xref to docs/EXTENDING.md in extension example (#3713) 2026-05-05 13:18:43 -07:00
AGENT_SIGNING.md docs: align agent maintainer conventions (#4237) 2026-06-20 20:44:08 -07:00
AIDER_INTEGRATION.md Document supported go install modes (bd-o5a) (#3480) 2026-04-25 11:30:19 -07:00
ANTIVIRUS.md docs: update user-facing URLs from steveyegge/beads to gastownhall/beads 2026-04-24 08:17:42 -07:00
ARCHITECTURE.md docs: link canonical SYNC_CONCEPTS.md from deeper docs (#4248) 2026-05-29 22:44:54 -07:00
ATTRIBUTION.md fix: remove dead 3-way merge config remnants (GH#2353) 2026-03-05 15:57:33 -08:00
CI_CLEANUP_PLAN.md Add PR CI wrapper command surface (#4211) 2026-05-29 18:52:53 -07:00
CI_REQUIRED_CHECK_TOPOLOGY.md Add PR CI wrapper command surface (#4211) 2026-05-29 18:52:53 -07:00
CI_TEST_SURFACE_AUDIT.md Add PR CI wrapper command surface (#4211) 2026-05-29 18:52:53 -07:00
CLAUDE.md Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
CLAUDE_INTEGRATION.md fix(setup): finish hook JSON migration 2026-05-08 09:21:39 -07:00
CLI_REFERENCE.md feat(lease): land the leasing stack + schema v54 (claim-TTL, heartbeat, reclaim) (#4537) 2026-07-03 23:28:55 -07:00
CODEX_INTEGRATION.md fix(codex): ship hook release safely 2026-05-27 13:19:41 -07:00
COLLISION_MATH.md docs: fix broken relative links across documentation 2025-12-16 00:46:08 -08:00
COMMUNITY_TOOLS.md Add bd-board to community tools (#4349) 2026-06-16 07:48:25 -07:00
CONFIG.md fix(linear): unwire staleness hook from core; gitignore last_pull (bd-6dnrw.12) 2026-06-11 01:14:08 -04:00
CONTRIBUTOR_NAMESPACE_ISOLATION.md cleanup: remove remaining Gas Town terminology from help text, docs, and comments 2026-03-22 13:27:43 -07:00
COPILOT_CLI_INTEGRATION.md feat: add Copilot CLI setup recipe (#3839) 2026-05-14 10:51:38 -07:00
COPILOT_INTEGRATION.md feat: add Copilot CLI setup recipe (#3839) 2026-05-14 10:51:38 -07:00
DEPENDENCIES.md docs(deps): add DEPENDENCIES.md covering dependency system and gates 2026-02-27 10:09:05 -08:00
DOC_INVENTORY.md docs: align agent maintainer conventions (#4237) 2026-06-20 20:44:08 -07:00
DOLT-BACKEND.md Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
DOLT.md fix(remote): remove cli invocations of 'dolt remote' and exclusively use store method and sql (#4236) 2026-06-05 13:58:21 -07:00
ERROR_HANDLING.md Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
EXCLUSIVE_LOCK.md docs: update user-facing URLs from steveyegge/beads to gastownhall/beads 2026-04-24 08:17:42 -07:00
FAQ.md docs: link canonical SYNC_CONCEPTS.md from deeper docs (#4248) 2026-05-29 22:44:54 -07:00
GIT_INTEGRATION.md docs: link canonical SYNC_CONCEPTS.md from deeper docs (#4248) 2026-05-29 22:44:54 -07:00
graph-links.md refactor: remove Gas Town references from codebase 2025-12-30 14:13:32 -08:00
ICU-POLICY.md Add PR CI wrapper command surface (#4211) 2026-05-29 18:52:53 -07:00
INSTALLING.md docs: consolidate Homebrew tap-migration snippet across install/upgrade docs 2026-06-30 14:10:35 -07:00
INTEGRATION_CHARTER.md Document project scope boundaries (mybd-1fn) (#3842) 2026-05-13 06:49:11 -07:00
INTERNALS.md refactor: remove gastown/Gas Town string references from beads code and docs (bd-1ue8) 2026-03-20 18:39:50 -07:00
JSON_SCHEMA.md Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
LABELS.md cleanup: remove remaining Gas Town terminology from help text, docs, and comments 2026-03-22 13:27:43 -07:00
LINTING.md Add PR CI wrapper command surface (#4211) 2026-05-29 18:52:53 -07:00
messaging.md fix(create): commit labels during initial issue creation (#4149) 2026-05-24 19:23:46 -07:00
METADATA.md docs(metadata): document portability of execution model/effort hints (#4358) 2026-06-10 09:30:41 -07:00
MOLECULES.md Keep regular epics open after the last child closes (#3276) 2026-04-17 15:10:38 -07:00
MULTI_REPO_AGENTS.md Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
MULTI_REPO_MIGRATION.md Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
OBSERVABILITY.md /{cmd,docs,internal}: more cleanup 2026-03-31 12:33:52 -07:00
PERFORMANCE_TESTING.md docs: update stale SQLite references to Dolt across 10 documentation files 2026-02-16 01:22:58 -08:00
PLUGIN.md fix(init): use git origin as default Dolt remote (#3909) 2026-05-13 07:02:39 -07:00
PROJECT_CHARTER.md Document project scope boundaries (mybd-1fn) (#3842) 2026-05-13 06:49:11 -07:00
PROTECTED_BRANCHES.md docs: update user-facing URLs from steveyegge/beads to gastownhall/beads 2026-04-24 08:17:42 -07:00
QUICKSTART.md docs: update user-facing URLs from steveyegge/beads to gastownhall/beads 2026-04-24 08:17:42 -07:00
README_TESTING.md Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
RECOVERY.md docs(upgrade): add validated recipe for remote-backed / multi-clone upgrades (#4514) 2026-06-29 14:47:49 -07:00
RELEASE-STABILITY-GATE.md docs: update user-facing URLs from steveyegge/beads to gastownhall/beads 2026-04-24 08:17:42 -07:00
RELEASING.md Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
REPO_CONTEXT.md docs: replace stale bd sync references with bd dolt push/pull (GH#2442, GH#2435) 2026-03-08 10:12:08 -07:00
ROUTING.md docs: update user-facing URLs from steveyegge/beads to gastownhall/beads 2026-04-24 08:17:42 -07:00
RULES_AUDIT_DESIGN.md docs: update user-facing URLs from steveyegge/beads to gastownhall/beads 2026-04-24 08:17:42 -07:00
SECURITY-DEPENDENCY-EXCEPTIONS.md chore: harden release and dependency security 2026-04-28 08:45:22 +00:00
SETUP.md docs: align agent maintainer conventions (#4237) 2026-06-20 20:44:08 -07:00
SYNC_CONCEPTS.md docs: clarify export versus database backup (#4048) 2026-05-20 16:19:23 -07:00
SYNC_SETUP.md /{.github,docs,go,internal,scripts}: bump driver/dolt version to 2.1.4 (#4326) 2026-06-08 11:31:14 -07:00
TESTING.md /{.github,docs,go,internal,scripts}: bump driver/dolt version to 2.1.4 (#4326) 2026-06-08 11:31:14 -07:00
TESTING_PHILOSOPHY.md Consolidate docs evidence review inventory 2026-05-09 07:21:46 -07:00
TODO.md docs: remove stale JSONL references from ~73 markdown files (bd-9ni.4) 2026-02-22 22:18:02 -08:00
TROUBLESHOOTING.md fix(setup): harden symlink follow-up handling 2026-05-27 13:32:00 -07:00
UI_PHILOSOPHY.md docs: consolidate duplicate UI_PHILOSOPHY files (GH#745) 2025-12-27 18:01:59 -08:00
UNINSTALLING.md docs: publish community tools on website (#4299) 2026-06-03 13:44:47 -07:00
WORKTREES.md docs: update user-facing URLs from steveyegge/beads to gastownhall/beads 2026-04-24 08:17:42 -07:00