* docs: supersedes is a replacement link, not a version chain Reword the DepSupersedes comment (internal/types/types.go), the `bd supersede` help text, and the graph-links doc: `supersedes` marks an old issue as replaced by a different issue. It is not a version relation and does not imply a version chain. The behavior is unchanged. Promised on #5898 (Q8, quad341 revision 4): a replacement link, not a version-chain link. docs/CLI_REFERENCE.md is pinned to v1.2.2 and picks this up at the next release bump (generate-cli-docs.sh --check passes). Wyvern bead wy-h4xd6f. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PvjeDsoyDfjptvjKZWzcqA * docs: finish the supersedes rewording pass in graph-links + dependencies Maintainer review fixup for PR #6212. The PR's new assertion "This is a replacement link, not a version relation" left the rest of graph-links.md still telling the version-chain story, so the page contradicted itself. Each residual line is byte-identical to base, but the contradiction is new with this commit. Extends the same wording pass to the sites that actually assert version semantics: - frontmatter description: "supersedes chains" -> "supersedes (replacement) links" (this is the rendered page description) - the example comment "# View shows the chain" -> "# View shows the replacement" - "### Version History" -> "### Replacement History" and "# bd-rfc3 is now the current version" -> "# bd-rfc3 is now the live issue" - Best Practice 4 "Document supersedes chains - Note why version changed" -> "Document replacements - Note why the issue was replaced" The use-case list ("Design document versions", "Artifact versioning", "RFC chains") and "Track document evolution" are deliberately left alone: chained replacements legitimately model document evolution without the link itself being a version relation. Also rewords the sibling core-concepts table, docs/core-concepts/ dependencies.md:56, from "Replaced by a newer issue" to "Replaced by a different issue" so both hand-written pages frame the edge the same way. No in-repo reference targets the renamed #version-history anchor. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <julianknutsen@users.noreply.github.com>
198 lines
5.6 KiB
Go
198 lines
5.6 KiB
Go
package main
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
"github.com/spf13/cobra"
|
|
"github.com/steveyegge/beads/internal/metrics"
|
|
"github.com/steveyegge/beads/internal/types"
|
|
"github.com/steveyegge/beads/internal/ui"
|
|
"github.com/steveyegge/beads/internal/utils"
|
|
)
|
|
|
|
var duplicateCmd = &cobra.Command{
|
|
Use: "duplicate <id> --of <canonical>",
|
|
GroupID: "deps",
|
|
Short: "Mark an issue as a duplicate of another",
|
|
Long: `Mark an issue as a duplicate of a canonical issue.
|
|
|
|
The duplicate issue is automatically closed with a reference to the canonical.
|
|
This is essential for large issue databases with many similar reports.
|
|
|
|
Examples:
|
|
bd duplicate bd-abc --of bd-xyz # Mark bd-abc as duplicate of bd-xyz`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: runDuplicate,
|
|
}
|
|
|
|
var supersedeCmd = &cobra.Command{
|
|
Use: "supersede <id> --with <new>",
|
|
GroupID: "deps",
|
|
Short: "Mark an issue as superseded by a replacement issue",
|
|
Long: `Mark an issue as superseded by a different (replacement) issue.
|
|
|
|
The superseded issue is automatically closed with a reference to the replacement.
|
|
Useful for design docs, specs, and evolving artifacts.
|
|
|
|
Examples:
|
|
bd supersede bd-old --with bd-new # Mark bd-old as superseded by bd-new`,
|
|
Args: cobra.ExactArgs(1),
|
|
RunE: runSupersede,
|
|
}
|
|
|
|
var (
|
|
duplicateOf string
|
|
supersededWith string
|
|
)
|
|
|
|
func init() {
|
|
duplicateCmd.Flags().StringVar(&duplicateOf, "of", "", "Canonical issue ID (required)")
|
|
_ = duplicateCmd.MarkFlagRequired("of") // Only fails if flag missing (caught in tests)
|
|
duplicateCmd.ValidArgsFunction = issueIDCompletion
|
|
rootCmd.AddCommand(duplicateCmd)
|
|
|
|
supersedeCmd.Flags().StringVar(&supersededWith, "with", "", "Replacement issue ID (required)")
|
|
_ = supersedeCmd.MarkFlagRequired("with") // Only fails if flag missing (caught in tests)
|
|
supersedeCmd.ValidArgsFunction = issueIDCompletion
|
|
rootCmd.AddCommand(supersedeCmd)
|
|
}
|
|
|
|
func runDuplicate(cmd *cobra.Command, args []string) error {
|
|
if usesProxiedServer() {
|
|
return HandleErrorRespectJSON("duplicate is not supported in proxied-server mode")
|
|
}
|
|
CheckReadonly("duplicate")
|
|
|
|
evt := metrics.NewCommandEvent("duplicate")
|
|
defer func() {
|
|
if c := metrics.Global(); c != nil {
|
|
c.CloseEventAndAdd(evt)
|
|
}
|
|
}()
|
|
|
|
ctx := getRootContext()
|
|
store := getStore()
|
|
actor := getActor()
|
|
|
|
// Resolve partial IDs
|
|
var duplicateID, canonicalID string
|
|
var err error
|
|
duplicateID, err = utils.ResolvePartialID(ctx, store, args[0])
|
|
if err != nil {
|
|
return fmt.Errorf("failed to resolve %s: %w", args[0], err)
|
|
}
|
|
canonicalID, err = utils.ResolvePartialID(ctx, store, duplicateOf)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to resolve %s: %w", duplicateOf, err)
|
|
}
|
|
|
|
if duplicateID == canonicalID {
|
|
return fmt.Errorf("cannot mark an issue as duplicate of itself")
|
|
}
|
|
|
|
// Verify canonical issue exists
|
|
var canonical *types.Issue
|
|
canonical, err = store.GetIssue(ctx, canonicalID)
|
|
if err != nil || canonical == nil {
|
|
return fmt.Errorf("canonical issue not found: %s", canonicalID)
|
|
}
|
|
|
|
// Add a "duplicates" dependency edge (duplicate → canonical)
|
|
dep := &types.Dependency{
|
|
IssueID: duplicateID,
|
|
DependsOnID: canonicalID,
|
|
Type: types.DepDuplicates,
|
|
}
|
|
if err := store.AddDependency(ctx, dep, actor); err != nil {
|
|
return fmt.Errorf("failed to add duplicate link: %w", err)
|
|
}
|
|
|
|
// Close the duplicate issue through the lifecycle operation so it records
|
|
// the complete closure state.
|
|
if err := store.CloseIssue(ctx, duplicateID, "", actor, ""); err != nil {
|
|
return fmt.Errorf("failed to close duplicate: %w", err)
|
|
}
|
|
|
|
commandDidWrite.Store(true)
|
|
|
|
if isJSONOutput() {
|
|
return outputJSON(map[string]interface{}{
|
|
"duplicate": duplicateID,
|
|
"canonical": canonicalID,
|
|
"status": "closed",
|
|
})
|
|
}
|
|
|
|
fmt.Printf("%s Marked %s as duplicate of %s (closed)\n", ui.RenderPass("✓"), duplicateID, canonicalID)
|
|
return nil
|
|
}
|
|
|
|
func runSupersede(cmd *cobra.Command, args []string) error {
|
|
if usesProxiedServer() {
|
|
return HandleErrorRespectJSON("supersede is not supported in proxied-server mode")
|
|
}
|
|
CheckReadonly("supersede")
|
|
|
|
evt := metrics.NewCommandEvent("supersede")
|
|
defer func() {
|
|
if c := metrics.Global(); c != nil {
|
|
c.CloseEventAndAdd(evt)
|
|
}
|
|
}()
|
|
|
|
ctx := getRootContext()
|
|
store := getStore()
|
|
actor := getActor()
|
|
|
|
// Resolve partial IDs
|
|
var oldID, newID string
|
|
var err error
|
|
oldID, err = utils.ResolvePartialID(ctx, store, args[0])
|
|
if err != nil {
|
|
return fmt.Errorf("failed to resolve %s: %w", args[0], err)
|
|
}
|
|
newID, err = utils.ResolvePartialID(ctx, store, supersededWith)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to resolve %s: %w", supersededWith, err)
|
|
}
|
|
|
|
if oldID == newID {
|
|
return fmt.Errorf("cannot mark an issue as superseded by itself")
|
|
}
|
|
|
|
// Verify new issue exists
|
|
var newIssue *types.Issue
|
|
newIssue, err = store.GetIssue(ctx, newID)
|
|
if err != nil || newIssue == nil {
|
|
return fmt.Errorf("replacement issue not found: %s", newID)
|
|
}
|
|
|
|
// Add a "supersedes" dependency edge (old → new)
|
|
dep := &types.Dependency{
|
|
IssueID: oldID,
|
|
DependsOnID: newID,
|
|
Type: types.DepSupersedes,
|
|
}
|
|
if err := store.AddDependency(ctx, dep, actor); err != nil {
|
|
return fmt.Errorf("failed to add supersede link: %w", err)
|
|
}
|
|
|
|
// Close the superseded issue through the lifecycle operation so it records
|
|
// the complete closure state.
|
|
if err := store.CloseIssue(ctx, oldID, "", actor, ""); err != nil {
|
|
return fmt.Errorf("failed to close superseded issue: %w", err)
|
|
}
|
|
|
|
commandDidWrite.Store(true)
|
|
|
|
if isJSONOutput() {
|
|
return outputJSON(map[string]interface{}{
|
|
"superseded": oldID,
|
|
"replacement": newID,
|
|
"status": "closed",
|
|
})
|
|
}
|
|
|
|
fmt.Printf("%s Marked %s as superseded by %s (closed)\n", ui.RenderPass("✓"), oldID, newID)
|
|
return nil
|
|
}
|