Two fixes for the contributor mode "no database selected" bug: 1. store_factory.go: Default to "beads" when metadata.json is missing (same fix as the standalone PR for the unit-level regression). 2. create.go (ensureBeadsDirForPath): Write metadata.json after creating the target store so that newDoltStoreFromConfig can find the correct database name on subsequent opens. Also sanitize the prefix for SQL database names (hyphens → underscores), matching bd init behavior. Adds embedded Dolt contributor mode tests that exercise the full init --contributor → create → show flow, covering: - Issue routing to planning repo (the #2988 regression scenario) - Issue isolation (not in project store) - bd show reads routed issues - Multiple sequential creates Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
167 lines
5.4 KiB
Go
167 lines
5.4 KiB
Go
//go:build cgo
|
|
|
|
package main
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"os/exec"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/steveyegge/beads/internal/storage/embeddeddolt"
|
|
)
|
|
|
|
// TestEmbeddedContributorCreate exercises the full contributor mode flow in
|
|
// embedded Dolt: init → contributor wizard → create. This is the exact
|
|
// scenario that triggered GH#2988 ("no database selected" when the planning
|
|
// repo's .beads directory has no metadata.json).
|
|
func TestEmbeddedContributorCreate(t *testing.T) {
|
|
if os.Getenv("BEADS_TEST_EMBEDDED_DOLT") != "1" {
|
|
t.Skip("set BEADS_TEST_EMBEDDED_DOLT=1 to run embedded dolt contributor tests")
|
|
}
|
|
t.Parallel()
|
|
|
|
bd := buildEmbeddedBD(t)
|
|
|
|
t.Run("create_routes_to_planning_repo", func(t *testing.T) {
|
|
dir, planningDir := initContributor(t, bd, "cr")
|
|
|
|
// Create an issue — should route to the planning repo, not the project.
|
|
issue := bdCreate(t, bd, dir, "Contributor issue")
|
|
if issue.ID == "" {
|
|
t.Fatal("expected issue ID")
|
|
}
|
|
if !strings.HasPrefix(issue.ID, "cr-") {
|
|
t.Errorf("ID should have prefix cr-, got %q", issue.ID)
|
|
}
|
|
|
|
// Verify the issue landed in the planning repo's embedded store.
|
|
// The planning store database name is the sanitized prefix (same as source).
|
|
planningBeadsDir := filepath.Join(planningDir, ".beads")
|
|
assertIssueInStore(t, planningBeadsDir, "cr", issue.ID)
|
|
|
|
// Verify the issue is NOT in the project's store.
|
|
projectBeadsDir := filepath.Join(dir, ".beads")
|
|
assertIssueNotInStore(t, projectBeadsDir, "cr", issue.ID)
|
|
})
|
|
|
|
t.Run("show_reads_routed_issue", func(t *testing.T) {
|
|
dir, _ := initContributor(t, bd, "sh")
|
|
|
|
issue := bdCreate(t, bd, dir, "Show me")
|
|
shown := bdShow(t, bd, dir, issue.ID)
|
|
if shown.Title != "Show me" {
|
|
t.Errorf("title: got %q, want %q", shown.Title, "Show me")
|
|
}
|
|
})
|
|
|
|
t.Run("multiple_creates_succeed", func(t *testing.T) {
|
|
dir, planningDir := initContributor(t, bd, "mc")
|
|
|
|
ids := make(map[string]bool)
|
|
for i := 0; i < 3; i++ {
|
|
issue := bdCreate(t, bd, dir, fmt.Sprintf("Issue %d", i))
|
|
if issue.ID == "" {
|
|
t.Fatalf("create %d: expected issue ID", i)
|
|
}
|
|
if ids[issue.ID] {
|
|
t.Fatalf("create %d: duplicate ID %q", i, issue.ID)
|
|
}
|
|
ids[issue.ID] = true
|
|
}
|
|
|
|
// All three should be in the planning store.
|
|
planningBeadsDir := filepath.Join(planningDir, ".beads")
|
|
for id := range ids {
|
|
assertIssueInStore(t, planningBeadsDir, "mc", id)
|
|
}
|
|
})
|
|
}
|
|
|
|
// initContributor sets up a project with contributor mode enabled and returns
|
|
// the project dir and planning dir paths. The contributor wizard runs via
|
|
// subprocess with stdin piped to answer the interactive prompts.
|
|
func initContributor(t *testing.T, bd, prefix string) (projectDir, planningDir string) {
|
|
t.Helper()
|
|
|
|
projectDir = t.TempDir()
|
|
planningDir = filepath.Join(t.TempDir(), "planning")
|
|
initGitRepoAt(t, projectDir)
|
|
|
|
// Run bd init with --contributor flag.
|
|
// The wizard prompts (no upstream remote):
|
|
// 1. "Continue with contributor setup? [y/N]:" → "y"
|
|
// 2. "Planning repo path [press Enter for default]:" → planningDir
|
|
args := []string{"init", "--quiet", "--prefix", prefix, "--contributor"}
|
|
cmd := exec.Command(bd, args...)
|
|
cmd.Dir = projectDir
|
|
cmd.Env = append(bdEnv(projectDir), "BD_NON_INTERACTIVE=0")
|
|
cmd.Stdin = strings.NewReader("y\n" + planningDir + "\n")
|
|
out, err := cmd.CombinedOutput()
|
|
if err != nil {
|
|
t.Fatalf("bd init --contributor failed: %v\n%s", err, out)
|
|
}
|
|
|
|
// Sanity: planning .beads dir should exist (created by wizard).
|
|
planningBeadsDir := filepath.Join(planningDir, ".beads")
|
|
requireFile(t, planningBeadsDir)
|
|
|
|
// Sanity: beads.role should be "contributor".
|
|
roleCmd := exec.Command("git", "config", "beads.role")
|
|
roleCmd.Dir = projectDir
|
|
roleOut, err := roleCmd.Output()
|
|
if err != nil {
|
|
t.Fatalf("git config beads.role failed: %v", err)
|
|
}
|
|
if got := strings.TrimSpace(string(roleOut)); got != "contributor" {
|
|
t.Fatalf("beads.role: got %q, want %q", got, "contributor")
|
|
}
|
|
|
|
return projectDir, planningDir
|
|
}
|
|
|
|
// assertIssueInStore verifies that an issue with the given ID exists in the
|
|
// embedded Dolt store at beadsDir.
|
|
func assertIssueInStore(t *testing.T, beadsDir, database, issueID string) {
|
|
t.Helper()
|
|
dataDir := filepath.Join(beadsDir, "embeddeddolt")
|
|
db, cleanup, err := embeddeddolt.OpenSQL(t.Context(), dataDir, database, "main")
|
|
if err != nil {
|
|
t.Fatalf("OpenSQL(%s, %s): %v", beadsDir, database, err)
|
|
}
|
|
defer cleanup()
|
|
|
|
var count int
|
|
err = db.QueryRowContext(t.Context(),
|
|
"SELECT COUNT(*) FROM issues WHERE id = ?", issueID).Scan(&count)
|
|
if err != nil {
|
|
t.Fatalf("query issues for %s: %v", issueID, err)
|
|
}
|
|
if count == 0 {
|
|
t.Errorf("expected issue %s in store at %s, not found", issueID, beadsDir)
|
|
}
|
|
}
|
|
|
|
// assertIssueNotInStore verifies that an issue with the given ID does NOT
|
|
// exist in the embedded Dolt store at beadsDir.
|
|
func assertIssueNotInStore(t *testing.T, beadsDir, database, issueID string) {
|
|
t.Helper()
|
|
dataDir := filepath.Join(beadsDir, "embeddeddolt")
|
|
db, cleanup, err := embeddeddolt.OpenSQL(t.Context(), dataDir, database, "main")
|
|
if err != nil {
|
|
t.Fatalf("OpenSQL(%s, %s): %v", beadsDir, database, err)
|
|
}
|
|
defer cleanup()
|
|
|
|
var count int
|
|
err = db.QueryRowContext(t.Context(),
|
|
"SELECT COUNT(*) FROM issues WHERE id = ?", issueID).Scan(&count)
|
|
if err != nil {
|
|
t.Fatalf("query issues for %s: %v", issueID, err)
|
|
}
|
|
if count != 0 {
|
|
t.Errorf("issue %s should NOT be in store at %s, but found %d rows", issueID, beadsDir, count)
|
|
}
|
|
}
|