Remove Beads Classic remnants that are no longer needed now that the system is pure Dolt: - Delete deprecated commands: sync, template (cmds only), thanks (cmd only), detect-pollution (cmd only), admin aliases, comment alias - Remove dead sqliteBackendWarning() and all 7 unreachable call sites (GetBackend() always returns "dolt") - Remove sqliteIntegrityRecovery() from fix package - Delete legacy test scripts: test_wsl2_wal.sh, test_issue_gh1224.sh, migrate-audit.sh - Remove SQLite-specific test functions from doctor tests Utility functions shared with active code are preserved (e.g., TemplateSubgraph, isTestIssue, printThanksPage). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
121 lines
3.5 KiB
Go
121 lines
3.5 KiB
Go
package main
|
|
|
|
import (
|
|
"encoding/json"
|
|
"fmt"
|
|
"os"
|
|
"regexp"
|
|
"strings"
|
|
|
|
"github.com/steveyegge/beads/internal/types"
|
|
)
|
|
|
|
// Pollution detection utilities used by doctor_pollution.go, create.go, and export.go.
|
|
// The deprecated 'bd detect-pollution' command has been removed;
|
|
// use 'bd doctor --check=pollution' instead.
|
|
|
|
type pollutionResult struct {
|
|
issue *types.Issue
|
|
score float64
|
|
reasons []string
|
|
}
|
|
|
|
// testPrefixPattern matches common test issue title prefixes.
|
|
// Compiled once at package level for use in isTestIssue and detectTestPollution.
|
|
var testPrefixPattern = regexp.MustCompile(`^(test|benchmark|sample|tmp|temp|debug|dummy)[-_\s]`)
|
|
|
|
// isTestIssue checks if an issue title looks like a test issue based on common test prefixes.
|
|
// This function is used both for warnings during creation and for pollution detection.
|
|
func isTestIssue(title string) bool {
|
|
return testPrefixPattern.MatchString(strings.ToLower(title))
|
|
}
|
|
|
|
func detectTestPollution(issues []*types.Issue) []pollutionResult {
|
|
var results []pollutionResult
|
|
sequentialPattern := regexp.MustCompile(`^[a-z]+-\d+$`)
|
|
|
|
// Group issues by creation time to detect rapid succession
|
|
issuesByMinute := make(map[int64][]*types.Issue)
|
|
for _, issue := range issues {
|
|
minute := issue.CreatedAt.Unix() / 60
|
|
issuesByMinute[minute] = append(issuesByMinute[minute], issue)
|
|
}
|
|
|
|
for _, issue := range issues {
|
|
score := 0.0
|
|
var reasons []string
|
|
|
|
title := strings.ToLower(issue.Title)
|
|
|
|
// Check for test prefixes (strong signal)
|
|
if testPrefixPattern.MatchString(title) {
|
|
score += 0.7
|
|
reasons = append(reasons, "Title starts with test prefix")
|
|
}
|
|
|
|
// Check for sequential numbering (medium signal)
|
|
if sequentialPattern.MatchString(issue.ID) && len(issue.Description) < 20 {
|
|
score += 0.4
|
|
reasons = append(reasons, "Sequential ID with minimal description")
|
|
}
|
|
|
|
// Check for generic/empty description (weak signal)
|
|
if len(strings.TrimSpace(issue.Description)) == 0 {
|
|
score += 0.2
|
|
reasons = append(reasons, "No description")
|
|
} else if len(issue.Description) < 20 {
|
|
score += 0.1
|
|
reasons = append(reasons, "Very short description")
|
|
}
|
|
|
|
// Check for rapid creation (created with many others in same minute)
|
|
minute := issue.CreatedAt.Unix() / 60
|
|
if len(issuesByMinute[minute]) >= 10 {
|
|
score += 0.3
|
|
reasons = append(reasons, fmt.Sprintf("Created with %d other issues in same minute", len(issuesByMinute[minute])-1))
|
|
}
|
|
|
|
// Check for generic test titles
|
|
if strings.Contains(title, "issue for testing") ||
|
|
strings.Contains(title, "test issue") ||
|
|
strings.Contains(title, "sample issue") {
|
|
score += 0.5
|
|
reasons = append(reasons, "Generic test title")
|
|
}
|
|
|
|
// Only include if score is above threshold
|
|
if score >= 0.7 {
|
|
results = append(results, pollutionResult{
|
|
issue: issue,
|
|
score: score,
|
|
reasons: reasons,
|
|
})
|
|
}
|
|
}
|
|
|
|
return results
|
|
}
|
|
|
|
func backupPollutedIssues(polluted []pollutionResult, path string) error {
|
|
// Create backup file
|
|
// nolint:gosec // G304: path is provided by user as explicit backup location
|
|
file, err := os.Create(path)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to create backup file: %w", err)
|
|
}
|
|
defer file.Close()
|
|
|
|
// Write each issue as JSONL
|
|
for _, p := range polluted {
|
|
data, err := json.Marshal(p.issue)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to marshal issue %s: %w", p.issue.ID, err)
|
|
}
|
|
|
|
if _, err := file.WriteString(string(data) + "\n"); err != nil {
|
|
return fmt.Errorf("failed to write issue %s: %w", p.issue.ID, err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|