beads/cmd/bd/metadata_ready_test.go
onyx 97462205e9 fix: prevent closed-store panics and consolidate test suites (bd-1rh)
- Add ErrStoreClosed guard to DoltStore query methods (execContext,
  queryContext, queryRowContext) to prevent nil-pointer panics when
  accessing a closed store
- Add IsClosed() method to DoltStore for callers to check store state
- Guard maybeAutoBackup, maybeAutoPush, and maybeAutoCommit against
  closed stores in PersistentPostRun
- Consolidate metadata_filter_test.go from 9 separate stores to 1
  shared suite (TestMetadataFilterSuite)
- Consolidate metadata_ready_test.go from 4 separate stores to 1
  shared suite (TestGetReadyWork_MetadataSuite)
- Consolidate thread_test.go from 5 separate stores to 1 shared suite
  (TestThreadTraversalSuite)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Executed-By: beads/polecats/onyx
Rig: beads
Role: polecats
2026-02-27 13:41:40 -08:00

94 lines
2.9 KiB
Go

//go:build cgo
package main
import (
"context"
"encoding/json"
"testing"
"github.com/steveyegge/beads/internal/types"
)
func TestGetReadyWork_MetadataSuite(t *testing.T) {
t.Parallel()
tmpDir := t.TempDir()
store := newTestStore(t, tmpDir)
ctx := context.Background()
// Create all test data up front with unique metadata keys per subtest.
allIssues := []*types.Issue{
// --- FieldMatch data ---
{ID: "mr-fm-1", Title: "Platform task (fm)", Priority: 2, IssueType: types.TypeTask, Status: types.StatusOpen,
Metadata: json.RawMessage(`{"mr_fm_team":"platform"}`)},
{ID: "mr-fm-2", Title: "Frontend task (fm)", Priority: 2, IssueType: types.TypeTask, Status: types.StatusOpen,
Metadata: json.RawMessage(`{"mr_fm_team":"frontend"}`)},
// --- HasMetadataKey data ---
{ID: "mr-hmk-1", Title: "Has team (hmk)", Priority: 2, IssueType: types.TypeTask, Status: types.StatusOpen,
Metadata: json.RawMessage(`{"mr_hmk_team":"platform"}`)},
{ID: "mr-hmk-2", Title: "No metadata (hmk)", Priority: 2, IssueType: types.TypeTask, Status: types.StatusOpen},
// --- NoMatch data ---
{ID: "mr-nm-1", Title: "Platform task (nm)", Priority: 2, IssueType: types.TypeTask, Status: types.StatusOpen,
Metadata: json.RawMessage(`{"mr_nm_team":"platform"}`)},
}
for _, issue := range allIssues {
if err := store.CreateIssue(ctx, issue, "test"); err != nil {
t.Fatalf("CreateIssue(%s): %v", issue.ID, err)
}
}
t.Run("FieldMatch", func(t *testing.T) {
results, err := store.GetReadyWork(ctx, types.WorkFilter{
Status: "open",
MetadataFields: map[string]string{"mr_fm_team": "platform"},
})
if err != nil {
t.Fatalf("GetReadyWork: %v", err)
}
if len(results) != 1 {
t.Fatalf("expected 1 result, got %d", len(results))
}
if results[0].ID != "mr-fm-1" {
t.Errorf("expected issue mr-fm-1, got %s", results[0].ID)
}
})
t.Run("HasMetadataKey", func(t *testing.T) {
results, err := store.GetReadyWork(ctx, types.WorkFilter{
Status: "open",
HasMetadataKey: "mr_hmk_team",
})
if err != nil {
t.Fatalf("GetReadyWork: %v", err)
}
if len(results) != 1 {
t.Fatalf("expected 1 result, got %d", len(results))
}
if results[0].ID != "mr-hmk-1" {
t.Errorf("expected issue mr-hmk-1, got %s", results[0].ID)
}
})
t.Run("FieldNoMatch", func(t *testing.T) {
results, err := store.GetReadyWork(ctx, types.WorkFilter{
Status: "open",
MetadataFields: map[string]string{"mr_nm_team": "backend"},
})
if err != nil {
t.Fatalf("GetReadyWork: %v", err)
}
if len(results) != 0 {
t.Errorf("expected 0 results, got %d", len(results))
}
})
t.Run("FieldInvalidKey", func(t *testing.T) {
_, err := store.GetReadyWork(ctx, types.WorkFilter{
Status: "open",
MetadataFields: map[string]string{"'; DROP TABLE issues; --": "val"},
})
if err == nil {
t.Fatal("expected error for invalid metadata key, got nil")
}
})
}