* ci: F5 S2 Variant A nogo ownership for the integration configuration group No full Bazel lane validates the integration / doltserver-integration / doltserver-cmd configurations anymore (all three now pass --norun_validations). Instead bazel-integration gains a narrow "Nogo: integration library files" step that keeps full nogo (vet + golangci-lint) on the configuration's one non-test library package, //internal/testutil/integration, via `bazel build --config=integration --@rules_go//go/config:race --keep_going --output_groups=nogo_fix -- //internal/testutil/integration:integration`. This accepts a scoped coverage loss (f5-spec.md §3/§5 S2, Variant A): the 56 integration-tagged _test.go files (listed in tools/nogo/unvalidated_integration_tests.txt, derived from source by the new T4 test) no longer get a vet pass in any lane, since golangci-lint already skips all _test.go files repo-wide (.golangci.yml's run.tests: false) and no lane builds those test binaries with validations on. Verified directly with real `bazel build` runs: a planted vet finding in the library package still fails the new step; the same finding in an integration-tagged _test.go file no longer fails anything; a planted finding in a plain race-configuration library still fails bazel-test; and GoCompilePkg action keys for the integration configuration are identical with and without --norun_validations (it is a build-request option, not a configuration flag, so no farm cache invalidation). scripts/nogo_lint_policy_test.go: the nogoConfigurations table gains a "integ" row with an ownerIsNogoOnlyStep flag and a dedicated checkNogoOnlyStepRow, generalizing T1/T2/T5/T6 to cover an owner that is a narrow build step rather than a full lane; adds T4 (TestNogoIntegrationStepCoversItsConfiguration), which derives the step's expected target set from source via go/build's own tag matching instead of a hardcoded list. Also fixes four should-fix items from julianknutsen's review of #7482: 1. expandBazelrcConfig now follows `common:` lines and --config= tokens anywhere on a line, not just a first-position `build:`/`test:` one. 2. TestNogoRaceOwnerBuildsEverything now expands every config the owner job can reach (including shell-variable-gated ones like sole-run), not just the statically-named "ci". 3. The package-gate check now compares full key-flag fingerprints instead of substring-matching --@rules_go//go/config:race / --norun_validations. 4. tools/bazel/nogo_ownership.py now fails loudly (exit 2) when both the owner's and non-owners' action-key sets are empty, instead of reporting a vacuous pass. Each fix has new mutation-test coverage in TestNogoPolicyRejectsMutations (should-fixes 1-3) or nogo_ownership_test.py (should-fix 4). engdocs/LINTING.md and engdocs/CI_REQUIRED_CHECK_TOPOLOGY.md updated to remove the stale "integration still validates in all three lanes" claim and document the Variant A trade-off. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(ci): make T4's source scan work under Bazel, not just plain go test scripts:scripts_test only declares //:repo_other_files as data (every tracked file but Go and Markdown source, by design: a Go-only change should not re-run the CI/workflow policy tests). TestNogoIntegrationStep CoversItsConfiguration's source scan needs every non-test .go file, so under `bazel test //scripts:scripts_test` its runfiles tree had none and the scan always came back empty. Fixes: - scripts/BUILD.bazel: add //:repo_go_srcs to scripts_test's data, with a comment explaining why (this is the one test in the target that needs it). - integrationOnlyLibraryPackages: use bazelPolicyRoot(t) + repoFiles(t, ...) (the existing Bazel-safe, runfiles-aware file listing other policy tests in this package already use) instead of sourceRepoRoot(t) + filepath.WalkDir, which only sees what //scripts's own go_test target declares. Verified with real `bazel test --config=integration --@rules_go//go/config:race` and `--config=ci --@rules_go//go/config:race` runs of //scripts:scripts_test (both pass); CI caught the original gap (PR #7486's first push failed Bazel / integration and Bazel / test with exactly this). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(bazel): address independent review + bee-ghosttrack findings on F5 S2 Variant A Independent review of #7486, must-fixes 1-7: pipefail on the nogo-only step's tee pipeline; exact source-scan equality check for tools/nogo/unvalidated_integration_tests.txt; expandBazelrcConfig follows common:-lines and non-first-position --config= tokens in both the Go policy test and nogo_ownership.py; mirrored nogo_ownership.py should-fix guarding against a non-owner action-key query silently matching nothing. Cost fix: split T4/T6's whole-repo .go source scan into its own go_test target (//scripts:nogo_integration_scan_test) so a Go-only change no longer re-runs all of scripts_test; extracted the shared bazelInvocations and ciWorkflow helpers into helper-only files so both targets can depend on them without violating the one-target-per-test-file partition rule. bee-ghosttrack review: checkNogoOnlyStepRow's own fingerprint now excludes test:-sourced .bazelrc lines pulled in via --config=X (buildOrCommonLines), since the nogo-only step is a `bazel build` invocation that never reads a test: line; added mutation s2i reproducing the gap this closes. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(nogo): pin integration nogo-only step's target, fingerprint its lane, add behavioral test Addresses the remaining should-fixes from the independent review of #7486: 1. TestNogoIntegrationStepScriptFailsWithoutMaskingBazelsExitCode (scripts/nogo_integration_step_script_test.go) extracts the real "Nogo: integration library files" step script from bazel.yml and runs it under plain `bash -e` (GitHub's actual run: semantics, no pipefail added) against a stub bazel, closing the gap a text-only pin can't: it catches rc=0 before `exit "$rc"`, `|| :`/`|| true` on the tee pipeline, or a missing/negated `set -o pipefail`, regardless of how the mutation is spelled. 2. The nogo-only step's target set is now pinned by exact go_library label, not just package: nogo_integration_scan_test.go derives the label(s) from source + BUILD.bazel and nogo_lint_policy_test.go pins them literally (its own go_test target has no //:repo_go_srcs). Both reject a `-//` exclusion pattern outright. 3. checkNonOwnerCommandLineAddsNoKeyFlag is now also applied to the integ row's owner's own full lane: under Variant A that lane validates nothing, so it is effectively a non-owner for this check's purpose, and must not override a key-affecting flag on its command line either. 4. Latent items: TestNoUnconditionalValidationOff now also scans .github/actions/setup-bazel/write-bazelrc.sh for run_validations (every line it emits lacks a :config suffix, so any occurrence would turn validation off everywhere with no owner lane to catch it). tools/bazel/nogo_ownership.py's docstring is corrected: it had said S2 was simply "out of scope," which is now stale since S2 has its own validating lane (the nogo-only step, checked statically); the script's dynamic aquery-based cross-check remains S1-only because S2's owner has no non-owner test lane building the same configuration to compare actions against. Skipped (not cheap / not reachable): - bazel-server-storage's `if:` not modeling an "integration" input: no such input exists to model; the gate is RBE-enabled-only by design, and resolving this requires understanding pr.yml's broader gating semantics, not a textual fix. - defaults.run.shell parsing: bazel.yml has no `defaults:` block today (confirmed by grep), so there is nothing to parse; the gap is latent only for a future change, not a live bug. - race-off scan's future-wrong-fix edge case: the review itself characterizes this as not reachable with today's file set. New mutation cases s2j/s2k/s2l in TestNogoPolicyRejectsMutations cover items 2 and 3. All mutation-verifications performed by hand-editing the real files, confirming FAIL, and reverting via Edit (never git stash/checkout). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| bench-ready-indexes | ||
| check-versions | ||
| checkworkflowtags | ||
| ci | ||
| gitattributespolicy | ||
| hooks | ||
| internal/testbash | ||
| migration-test | ||
| pr-lint | ||
| prlintmake | ||
| repochecks | ||
| repro-be-1he-slow-path | ||
| repro-dolt-hang | ||
| repro-dolt-prod-timeouts | ||
| workflowtags | ||
| bazel-autofix-push.sh | ||
| bazel_autofix_push_test.go | ||
| bazel_cache_mode_test.go | ||
| bazel_dolt_race_shadow_test.go | ||
| bazel_farm_workflow_test.go | ||
| bazel_fork_mode_test.go | ||
| bazel_go_repository_tools_test.go | ||
| bazel_hermetic_cc_test.go | ||
| bazel_invocations_test.go | ||
| bazel_policy_test.go | ||
| bazel_rbe_prewarm_test.go | ||
| bazel_rrc_test.go | ||
| bazel_skip_allowlist_test.go | ||
| build-examples.sh | ||
| BUILD.bazel | ||
| bump-version.sh | ||
| check-build-tags.sh | ||
| check-cli-docs-drift.sh | ||
| check-doc-flags.sh | ||
| check-doc-freshness.sh | ||
| check-go-install-guidance.sh | ||
| check-migration-hygiene.sh | ||
| check-testing-short.sh | ||
| check-versions.sh | ||
| check-winget-portable-alias.sh | ||
| check-workapi-frontend-boundary.sh | ||
| check_build_tags_test.go | ||
| check_doc_freshness_test.go | ||
| check_release_cross_compile_test.go | ||
| check_testing_short_test.go | ||
| check_winget_portable_alias_test.go | ||
| ci_actions_policy_test.go | ||
| ci_analytics_extract_test.go | ||
| ci_analytics_workflow_test.go | ||
| ci_blacksmith_runner_test.go | ||
| ci_f7b_review_test.go | ||
| ci_f7c_advisory_test.go | ||
| ci_merge_queue_test.go | ||
| ci_workflow_apt_get_timeout_test.go | ||
| ci_workflow_core_test.go | ||
| ci_workflow_test.go | ||
| clean-test-tmp.sh | ||
| complexity_script_test.go | ||
| conformance.sh | ||
| conformance_script_test.go | ||
| cross-version-smoke-test.sh | ||
| docs-autofix-push.sh | ||
| docs.md | ||
| embedded_shard_count_test.go | ||
| gen-winres.sh | ||
| generate-cli-docs.sh | ||
| generate-newsletter.py | ||
| generate-newsletter_README.md | ||
| gh-body-lint | ||
| host_tools_test.go | ||
| install-hooks.sh | ||
| install.sh | ||
| install_dolt_test.go | ||
| makefile_bazel_primary_test.go | ||
| managed_local_lane_test.go | ||
| migrate-jsonl-to-dolt.sh | ||
| migrate-legacy-to-current.sh | ||
| migration_corpus_bazel_test.go | ||
| mutation-equivalence.sh | ||
| nogo_integration_scan_test.go | ||
| nogo_integration_step_script_test.go | ||
| nogo_lint_policy_test.go | ||
| pinned_shards_helpers_test.go | ||
| pinned_shards_sources_test.go | ||
| pinned_shards_test.go | ||
| pr-preflight.sh | ||
| pr_lanes_bazel_coverage_test.go | ||
| pr_preflight_test.go | ||
| pr_risk_bazel_coverage_test.go | ||
| pre-push-suite.sh | ||
| pre_push_suite_test.go | ||
| proxied_lane_coverage_test.go | ||
| pull_dolt_image_test.go | ||
| rbe_worker_env_test.go | ||
| README.md | ||
| release.sh | ||
| release_script_test.go | ||
| repo_helpers_test.go | ||
| required_suite_test.go | ||
| resolve-docs-bd.sh | ||
| scripts_targets_test.go | ||
| shard_manifest_test.go | ||
| sign-windows.sh | ||
| test-cgo.sh | ||
| test-git-remote.sh | ||
| test-icu-path.sh | ||
| test.sh | ||
| test_script_test.go | ||
| testing_short_tree_test.go | ||
| tracked_files_test.go | ||
| update-nix-vendorhash.sh | ||
| update-versions.sh | ||
| update-winget.sh | ||
| upgrade-smoke-test.sh | ||
| upgrade_smoke_loop_test.go | ||
| verify-cgo.sh | ||
| worker_env_autosync_test.go | ||
Beads Scripts
Utility scripts for maintaining the beads project.
ci/
Repository-owned CI command wrappers. These scripts are the source of truth for the target CI tiers; Make targets are aliases for local discoverability.
make ci-pr-core
make ci-pr-lint
make ci-package-mcp
make ci-package-npm
Each wrapper auto-detects the repository root, sources .buildflags when it
invokes Go in the default build mode, and records per-command timing through
scripts/ci/lib/timing.sh.
ci-pr-lint keeps its supported Bash/Make entrypoint but delegates to the
checkout-owned scripts/pr-lint Go driver, which runs nogo (//tools/nogo)
under Bazel natively and cross-configured for windows/amd64 and darwin/arm64
(see engdocs/LINTING.md). This is the same shell-free
lint authority used by bd preflight in a Beads source checkout.
Broad Go test wrappers also source scripts/ci/lib/test-env.sh, which creates a
temporary HOME/XDG/Dolt root, isolates Git global/system config, clears runtime
Beads/Dolt environment variables, and sets BEADS_TEST_SKIP=dolt before tests
run. This keeps local make test-go and make ci-pr-core results comparable to
the fast PR-core contract even on shared agent hosts. Set
BEADS_TEST_ENV_RUN_DOLT=1 only when intentionally running the Dolt-dependent
tests through these broad wrappers, or BEADS_TEST_ENV_DISABLE=1 when debugging
against your real local configuration.
The broad Go wrappers also cap package and test parallelism to 4 by default
(GO_TEST_PKG_PARALLEL and GO_TEST_PARALLEL). This avoids turning high-core
shared hosts into a different test topology than GitHub Actions.
scripts/check-testing-short.sh (make check-testing-short; CI runs it in
//scripts:go_sources_test) enforces
that testing.Short() is only used for runtime, stress, or large-fixture skips.
Use build tags, environment checks, or named wrappers for integration/e2e/API
boundaries.
Package gate wrappers validate publishable/package-adjacent surfaces:
make ci-package-mcpbuilds or consumes abdbinary, puts it onPATHasbd, then runs locked MCP packageuv sync, Ruff, mypy, pytest, and build checks.make ci-package-npmbuilds or consumes the native binary expected bynpm-package/bin/bd, runs the npm package test suite, and checksnpm pack --dry-run.
Set BEADS_TEST_BD_BINARY=/path/to/bd for MCP and npm package gates to reuse a
prebuilt candidate binary instead of rebuilding it inside the wrapper.
pr-preflight.sh
Read-only PR safety check for agents and maintainers.
# Before implementing or opening a related PR
./scripts/pr-preflight.sh --search "topic keywords" --repo gastownhall/beads
# Before changing, closing, or merging an existing PR
./scripts/pr-preflight.sh 123 --repo gastownhall/beads
It reports contributor/fork status, draft/review/merge/check state, risky diff
signals such as .beads/ changes or missing tests, and the required
contributor-protection next steps. It does not replace code review or local
validation.
Base-branch health is supplemented by a warn-only PR-gate sample: the last 60
completed pull_request-event runs, grouped per workflow. A single workflow
whose decisive runs (>= 5, across >= 3 distinct head branches) are all
failure-class is reported as a broken PR gate — the case where a job that
exists only in the PR workflow is red for every PR while the base branch shows
green. This detector never blocks (deliberately: automation classifies
unrecognized [block] lines as genuine merge blockers and would park merge
lanes on a false positive); it is skipped entirely while the base branch is
red.
gh-body-lint
Lint Markdown files before posting them with gh ... --body-file.
./scripts/gh-body-lint body.md
./scripts/gh-body-lint --fix body.md
The lint catches literal \n sequences, which render poorly on GitHub, and
GH#123 references, which do not auto-link like #123 or owner/repo#123.
release.sh (⭐ The Easy Button)
One-command release from version bump to local installation.
Usage
# Full release (does everything)
./scripts/release.sh 0.9.3
# Preview what would happen
./scripts/release.sh 0.9.3 --dry-run
What It Does
This master script automates the entire release process:
- ✅ Stops running Dolt servers (avoids version conflicts)
- ✅ Runs tests and linting
- ✅ Bumps version in all files
- ✅ Commits and pushes version bump
- ✅ Creates and pushes git tag
- ✅ Verifies or opens the Homebrew core formula PR
- ✅ Upgrades local Homebrew installation
- ✅ Verifies everything works
After this script completes, your system is running the new version!
Examples
# Release version 0.9.3
./scripts/release.sh 0.9.3
# Preview a release (no changes made)
./scripts/release.sh 1.0.0 --dry-run
Prerequisites
- Clean git working directory
- All changes committed
- Homebrew installed (for local upgrade)
- Push access to gastownhall/beads
Output
The script provides colorful, step-by-step progress output:
- 🟨 Yellow: Current step
- 🟩 Green: Step completed
- 🟥 Red: Errors
- 🟦 Blue: Section headers
What Happens Next
After the script finishes:
- GitHub Actions builds binaries for all platforms (~5 minutes)
- PyPI package is published automatically
- Homebrew core formula is verified or tracked through its canonical PR
- Users can
brew upgrade beadsto get the new version after Homebrew merges - GitHub Release is created with binaries and changelog
bump-version.sh
Bumps the version number across all beads components in a single command.
Usage
# Show usage
./scripts/bump-version.sh
# Update versions (shows diff, no commit)
./scripts/bump-version.sh 0.9.3
# Update versions and auto-commit
./scripts/bump-version.sh 0.9.3 --commit
What It Does
Updates version in all these files:
cmd/bd/version.go- bd CLI version constantplugins/beads/.claude-plugin/plugin.json- Claude plugin versionplugins/beads/.codex-plugin/plugin.json- Codex plugin version.claude-plugin/marketplace.json- Claude marketplace plugin versionintegrations/beads-mcp/pyproject.toml- MCP server versionREADME.md- Alpha status versionPLUGIN.md- Version requirements
Features
- Validates semantic versioning format (MAJOR.MINOR.PATCH)
- Verifies all versions match after update
- Shows git diff of changes
- Auto-commits with standardized message (optional)
- Cross-platform compatible (macOS and Linux)
Examples
# Bump to 0.9.3 and review changes
./scripts/bump-version.sh 0.9.3
# Review the diff, then manually commit
# Bump to 1.0.0 and auto-commit
./scripts/bump-version.sh 1.0.0 --commit
git push origin main
Why This Script Exists
Previously, version bumps only updated cmd/bd/version.go, leaving other components out of sync. This script ensures all version numbers stay consistent across the project.
Safety
- Checks for uncommitted changes before proceeding
- Refuses to auto-commit if there are existing uncommitted changes
- Validates version format before making any changes
- Verifies all versions match after update
- Shows diff for review before commit
sign-windows.sh
Signs Windows executables with an Authenticode certificate using osslsigncode.
Usage
# Sign a Windows executable
./scripts/sign-windows.sh path/to/bd.exe
# Environment variables required for signing:
export WINDOWS_SIGNING_CERT_PFX_BASE64="<base64-encoded-pfx>"
export WINDOWS_SIGNING_CERT_PASSWORD="<certificate-password>"
What It Does
This script is called automatically by GoReleaser during the release process:
- Decodes the PFX certificate from base64
- Signs the Windows executable using osslsigncode
- Timestamps the signature using DigiCert's RFC3161 server
- Replaces the original binary with the signed version
- Verifies the signature was applied correctly
Prerequisites
osslsigncodeinstalled (apt install osslsigncodeorbrew install osslsigncode)- EV code signing certificate exported as PFX file
- GitHub secrets configured:
WINDOWS_SIGNING_CERT_PFX_BASE64- base64-encoded PFX fileWINDOWS_SIGNING_CERT_PASSWORD- certificate password
Graceful Degradation
If the signing secrets are not configured:
- The script prints a warning and exits successfully
- GoReleaser continues without signing
- The release proceeds with unsigned Windows binaries
This allows releases to work before a certificate is acquired.
Why This Script Exists
Windows code signing helps reduce antivirus false positives that affect Go binaries.
Kaspersky and other AV software commonly flag unsigned Go executables as potentially
malicious due to heuristic detection. See docs/reference/antivirus.md for details.
Future Scripts
Additional maintenance scripts may be added here as needed.