* fix(httpclient): name the connect failure when bd serve cannot be reached A workspace whose server does not answer reported the transport's text: `cannot reach bd serve at https://host:30699: Get "https://host:30699/v0/beads/context": dial tcp 100.85.56.42:30699: i/o timeout`. It names the request rather than the address that failed, and says nothing about what a dial timeout usually means. An operator chasing an unreachable store had to know that "i/o timeout" on a dial means the SYN went unanswered. A request whose connection could not be opened now fails with a *wire.DialError inside the *ConnectError: a refused connect names the address and says nothing is listening there; a connect that times out names the address that never answered, how long the attempt waited, and that a firewall dropping the connection or a down host is the usual cause; a host name that does not resolve is named as such. The transport's error stays reachable through Unwrap, so errors.Is checks (ECONNREFUSED, timeouts) and *ConnectError classification are unchanged, and a dial the caller canceled keeps its own error. The events:watch connect gets the same classification. Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of gascity-agent Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(httpclient): keep the transport's dial text in connect errors Review follow-up. The refused and DNS messages dropped "connection refused" and "dial tcp", the vocabulary gc's text classifier matches to tell an unavailable store from other failures; without it the dispatcher's serve loop exits and control beads are quarantined. Every DialError message now ends with the transport's own *net.OpError text in brackets, after the explanation. TestACanceledDialIsTheCallersOwn now actually reaches the ctx.Err() guard: its round tripper cancels and hands back a genuine refused dial, which the guard alone keeps from becoming a DialError (removing the guard fails it). Agent-Signature: claude-code-claude-opus-5-5-unknown-reasoning on behalf of gascity-agent Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
97 lines
3.5 KiB
Go
97 lines
3.5 KiB
Go
package wire
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net"
|
|
"syscall"
|
|
"time"
|
|
)
|
|
|
|
// DialError is a request that never reached the server because no connection
|
|
// could be opened: the name did not resolve, or the TCP connect failed. It is
|
|
// returned inside a *ConnectError, so callers that classify an unreachable
|
|
// server keep working, and it unwraps to the transport's own error.
|
|
//
|
|
// It exists to say which step failed. The transport's text names the request
|
|
// (`Get "https://…/v0/beads/context": dial tcp …: i/o timeout`) where the
|
|
// operator needs the address that did not answer and what that usually means.
|
|
type DialError struct {
|
|
Op string
|
|
// Addr is the address the connect was aimed at (ip:port), or the host
|
|
// name that did not resolve.
|
|
Addr string
|
|
// After is how long the attempt ran before it failed.
|
|
After time.Duration
|
|
// Resolve reports a name lookup failure rather than a failed connect.
|
|
Resolve bool
|
|
Err error
|
|
}
|
|
|
|
func (e *DialError) Error() string {
|
|
switch {
|
|
case e.Resolve:
|
|
return fmt.Sprintf("%s: cannot resolve %s: %v (%s)", e.Op, e.Addr, e.cause(), e.transportText())
|
|
case errors.Is(e.Err, syscall.ECONNREFUSED):
|
|
return fmt.Sprintf("%s: TCP connection to %s refused: nothing is listening on that port (%s)", e.Op, e.Addr, e.transportText())
|
|
case isTimeout(e.Err):
|
|
return fmt.Sprintf("%s: no TCP connection to %s after %s: nothing answered, so a firewall may be dropping the connection or the host is down (%s)",
|
|
e.Op, e.Addr, e.After.Round(100*time.Millisecond), e.transportText())
|
|
default:
|
|
return fmt.Sprintf("%s: TCP connection to %s failed (%s)", e.Op, e.Addr, e.transportText())
|
|
}
|
|
}
|
|
|
|
// transportText is the transport's own account of the failed dial without the
|
|
// request it was for: the *net.OpError's text ("dial tcp 10.0.0.1:443:
|
|
// connect: connection refused"), or the whole error when there is none. Every
|
|
// message keeps it, because what callers match on is that vocabulary: gc
|
|
// classifies an unreachable store by "connection refused", "dial tcp" and
|
|
// "i/o timeout" in bd's error text (dispatch's availability tier, gc hook's
|
|
// store-unavailable exit), and naming the failed step must not hide it.
|
|
func (e *DialError) transportText() string {
|
|
var opErr *net.OpError
|
|
if errors.As(e.Err, &opErr) {
|
|
return opErr.Error()
|
|
}
|
|
return e.Err.Error()
|
|
}
|
|
|
|
// cause is the innermost network error, without the request and address the
|
|
// transport's own text repeats.
|
|
func (e *DialError) cause() error {
|
|
var dnsErr *net.DNSError
|
|
if errors.As(e.Err, &dnsErr) {
|
|
return errors.New(dnsErr.Err)
|
|
}
|
|
var opErr *net.OpError
|
|
if errors.As(e.Err, &opErr) && opErr.Err != nil {
|
|
return opErr.Err
|
|
}
|
|
return e.Err
|
|
}
|
|
|
|
func (e *DialError) Unwrap() error { return e.Err }
|
|
|
|
// Timeout reports whether the connect timed out, so net.Error-style checks
|
|
// keep classifying it.
|
|
func (e *DialError) Timeout() bool { return isTimeout(e.Err) }
|
|
|
|
// dialFailure classifies a transport error as a resolve or connect failure,
|
|
// or returns nil for anything else (a TLS handshake, a reset). host is the
|
|
// request's host:port, named when the transport's error carries no address.
|
|
func dialFailure(op, host string, err error, after time.Duration) *DialError {
|
|
var dnsErr *net.DNSError
|
|
if errors.As(err, &dnsErr) {
|
|
return &DialError{Op: op, Addr: dnsErr.Name, After: after, Resolve: true, Err: err}
|
|
}
|
|
var opErr *net.OpError
|
|
if !errors.As(err, &opErr) || opErr.Op != "dial" {
|
|
return nil
|
|
}
|
|
addr := host
|
|
if opErr.Addr != nil {
|
|
addr = opErr.Addr.String()
|
|
}
|
|
return &DialError{Op: op, Addr: addr, After: after, Err: err}
|
|
}
|