Ten agents over 216 files, one directory-balanced group each, working to a rubric that named what to cut (duplication narration, restatement of the next line, the governing rule echoed in every command file, throat-clearing) and what to keep (traps, invariants, security, tracker ids, behaviour changes, and the "why a naive simplification destroys this assertion" rationale). Net 1,523 lines. Density against this repo's own per-directory norm on main: cmd/bd 33.6% -> 27.3% (main 10.7%) internal/storage 26.1% -> 23.1% (main 14.1%) backend/conformance 34.0% -> 29.6% (main 22.8%) internal/httpapi 30.9% -> 27.8% (main 30.6%, now below) overall 34.7% -> 31.6% Every agent landed at 18-25% rather than the 30% asked for, and every one gave the same reason independently: what remained was on the keep list. Ten separate judgements agreeing is the most useful result here — the prose is dense, but it is mostly load-bearing, and the shortfall is the honest answer rather than a failure to try. TWO REVERTS, both to protect something worth more than the lines. issueops/ is back to its pre-trim state, giving up 610 lines. The conformance contracts cite the leaf docs BY LINE — "pins treewalker.go:52-66" — 155 times. Trimming the cited files silently repointed those at whatever text moved into those numbers, across agent boundaries so no agent could see it. A semantic remapper recovered 141 of them, but 23 needed judgement and several landed on struct fields. The leaf docs are the spec the contracts are written against; they are the one place in this change where dense prose IS the deliverable, and keeping them stable is worth more than the 610 lines. tree_walker_contract.go and version_reconciler_contract.go went back for the same reason: an agent had deleted a paragraph containing a citation, so positional restoration could not align them. After the reverts, exactly 5 citations point into a still-trimmed file and 2 of those are weak — both in cmd/bd/config_guard_test.go, which this series never touched and whose citations were already wrong on main (init.go:361 pointed at a closing brace; the guard it names is at init.go:1499). VERIFICATION. A guard strips every comment and all whitespace from each of the 193 modified files at HEAD and in the worktree and requires the two to be byte-identical, so a code change cannot hide in a comment diff. It handles `//` inside string and raw-string literals, and was tested against a deliberate code change before being trusted. gofmt clean, go build, go vet, golangci-lint 0 issues, and the two AST-based tests that PARSE trimmed files — the timed provider binding pin over claim.go and the serve database-source gate over serve.go — both pass. One real defect found while trimming: checkDatabaseSource's doc block ran into `// sourceRoles is ...` with no blank line, so godoc attached thirty-one lines of the wrong prose to func sourceRoles and left checkDatabaseSource undocumented. Fixed by separating them.
85 lines
3.1 KiB
Go
85 lines
3.1 KiB
Go
package workapi
|
|
|
|
import (
|
|
"errors"
|
|
"testing"
|
|
|
|
"github.com/steveyegge/beads/issueops"
|
|
)
|
|
|
|
// The refusals and the normalization are pinned here, without a database,
|
|
// because they are the same on every backend by construction: all three
|
|
// implementations validate through ValidateBootstrapRequest and decide the
|
|
// refusal through RefuseIdentifiedSubstrate. The conformance contract is left
|
|
// to assert what only a real backend can show.
|
|
|
|
func validBootstrapRequest() issueops.BootstrapRequest {
|
|
return issueops.BootstrapRequest{
|
|
Prefix: "acme",
|
|
ProjectID: "11111111-2222-3333-4444-555555555555",
|
|
}
|
|
}
|
|
|
|
func TestValidateBootstrapRequestRefusesEachRequiredField(t *testing.T) {
|
|
for _, test := range []struct {
|
|
name string
|
|
spoil func(*issueops.BootstrapRequest)
|
|
}{
|
|
{"no prefix", func(r *issueops.BootstrapRequest) { r.Prefix = "" }},
|
|
// A prefix that is nothing but the hyphen the plane strips is the
|
|
// interesting empty: it arrives non-empty and normalizes to nothing.
|
|
{"prefix of hyphens", func(r *issueops.BootstrapRequest) { r.Prefix = "---" }},
|
|
{"no project id", func(r *issueops.BootstrapRequest) { r.ProjectID = "" }},
|
|
} {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
req := validBootstrapRequest()
|
|
test.spoil(&req)
|
|
if _, err := ValidateBootstrapRequest(req); !errors.Is(err, issueops.ErrValidation) {
|
|
t.Fatalf("ValidateBootstrapRequest() error = %v, want ErrValidation", err)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestValidateBootstrapRequestNormalizesOnlyTheTrailingHyphen(t *testing.T) {
|
|
req := validBootstrapRequest()
|
|
req.Prefix = "my-proj--"
|
|
got, err := ValidateBootstrapRequest(req)
|
|
if err != nil {
|
|
t.Fatalf("ValidateBootstrapRequest(): %v", err)
|
|
}
|
|
// Interior hyphens survive; only the trailing run goes, which is what the
|
|
// settings plane has always done to this key.
|
|
if got.Prefix != "my-proj" {
|
|
t.Fatalf("normalized prefix = %q, want %q", got.Prefix, "my-proj")
|
|
}
|
|
if got.ProjectID != req.ProjectID {
|
|
t.Fatalf("ValidateBootstrapRequest() changed a field it does not own: %+v", got)
|
|
}
|
|
}
|
|
|
|
func TestRefuseIdentifiedSubstrate(t *testing.T) {
|
|
if err := RefuseIdentifiedSubstrate("", ""); err != nil {
|
|
t.Fatalf("RefuseIdentifiedSubstrate(\"\", \"\") = %v, want nil for a substrate with no identity", err)
|
|
}
|
|
|
|
// EITHER marker refuses, including the half-identified states a bootstrap
|
|
// that failed partway leaves on a backend with no transaction to roll back.
|
|
for _, test := range []struct{ prefix, projectID string }{
|
|
{"acme", "proj-1"},
|
|
{"acme", ""},
|
|
{"", "proj-1"},
|
|
} {
|
|
err := RefuseIdentifiedSubstrate(test.prefix, test.projectID)
|
|
if !errors.Is(err, issueops.ErrAlreadyIdentified) {
|
|
t.Fatalf("RefuseIdentifiedSubstrate(%q, %q) = %v, want ErrAlreadyIdentified", test.prefix, test.projectID, err)
|
|
}
|
|
var refusal *issueops.AlreadyIdentifiedError
|
|
if !errors.As(err, &refusal) {
|
|
t.Fatalf("RefuseIdentifiedSubstrate(%q, %q) error is not *AlreadyIdentifiedError", test.prefix, test.projectID)
|
|
}
|
|
if refusal.Prefix != test.prefix || refusal.ProjectID != test.projectID {
|
|
t.Fatalf("refusal = %+v, want it to name what was found (%q, %q)", refusal, test.prefix, test.projectID)
|
|
}
|
|
}
|
|
}
|