* feat(http): serve list/show counts/dep tree/ping, close+reopen under a session, one-lookup not-found (S6b/S6c/S6d) S6c. The external-dependency decorator rebuilt its role views from the legacy DoltStorage seam (storereader over itself, IsBlocked, GetDependencyTree, ClaimReadyIssue), which a remote store only partly serves: `bd list`/`bd children` refused on the SearchIssuesWithCounts stub, `bd show --json` printed zero counts, the default `bd dep tree` refused, `bd ready --claim` and `bd close` of an externally blocked issue reached unsupported paths. For a storage.RemoteBackendStore each view now passes the inner role through and lays the policy over it in role terms (externaldeps/remote_roles.go): ready reads and the ready claim exclude the workspace-wide blocked set over a widened window; per-issue checks (claim, close, batch close, list annotations, tree leaves) read only the named issues' edges through EdgeReader instead of every edge in the workspace. A server advertising policy.external_dependencies (MC's does) gets a plain passthrough. `bd ping` uses a new storage.Pinger, which the http store answers with its authenticated context read. S6d. A store reporting storage.CallerAttributionLimitedStore (http) cannot carry a Provenance label or a patch's closed_by_session. The library still refuses both; the CLI omits them where nothing is lost: `bd reopen`'s fixed "bd: reopen <id>" label (the server labels the same entry), and the closed_by_session of `bd update -s closed` (attribution only, usually the ambient CLAUDE_SESSION_ID; an explicit --session prints a notice; `bd close` still records it). See cmd/bd/remote_backend.go. S6b. utils.ExactIDLookupStore: the resolver stops at exact lookups for a store with no substring search, so a missing prefixed id is a not-found (beadserrors.ErrNotFound, "no issue found matching") after one getIssue. The general resolver no longer repeats an identical normalized probe. The http SearchIssueIDs answers D11's partial-id refusal, which now unwraps to ErrNotFound. Contributor auto-routing for a remote workspace reads local config only, so the not-found fallback pays no settings round trip. `bd update <absent> --claim` (gc's hook claim) answers a gc-classifiable not-found in at most two requests. Served e2e (backend/http/e2e_remote_roles_test.go): every gc list shape and `bd children` against embedded, `show --json` count parity, default dep tree parity, external blocking still enforced, close/reopen under CLAUDE_SESSION_ID, missing-id request counts, absent-id claim against the current server and the MC handshake mask, policy passthrough under the MC mask, ping. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(externaldeps): role-level remote reader and claimer cases bd ready and bd update --claim reach the policy through the legacy seam and the lifecycle guard, so the remote Reader.Ready exclusion and the remote Claimer guard (what bd serve and library callers reach) are pinned at the role level with a fake remote store. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(http): bd serve advertises policy.external_dependencies; clients pass through bd serve composes every ready, claim, claim-next, close, blocking and tree role through the external-dependency policy, but never said so. Every client therefore ran the policy a second time, with the CLIENT machine's external-project config, and claim-next became a non-atomic read-then-claim loop on the client. The server now advertises the token exactly when the roles it serves were composed through the policy: httpapi.Config.ExternalDependencyPolicy, which bd serve derives from its actual chain (externaldeps.Applied for the store arm, externaldeps.AppliedToProvider for the provider arm). A server handed raw roles still withholds it, so the token stays truthful. Against a server that advertises it, every remote role view hands the request to the server's own role untouched: no client validation, no edge reads, claim-next is the server's one atomic call, and the ready count is the server's countReadyWork (new remoteReadyCounter). The client-side policy remains only for servers that do not advertise the token. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(create): default created_by to the request's actor in the create role created_by was stamped in two front doors and never in the library: the CLI (creationActorStamp, with a remote-workspace special case) and the three httpapi create handlers. A library caller of Lifecycle.Create or BatchCreator with an empty CreatedBy stored "" locally and the actor over http. PreparePublicCreateRequest, which every create shape prepares through (Lifecycle.Create, BatchCreator items, batch-apply create items), now defaults an empty CreatedBy to request.Actor; an explicit value is kept. The handlers no longer stamp, `bd create` and the state event create pass only the actor, and creationActorStamp/isRemoteBackendWorkspace are gone. The CLI sites that still create through the raw CreateIssue seam (swarm, todo, gate, the create form) keep stamping currentActor(): that seam is shared with import, where defaulting would re-attribute imported rows, and the http store refuses it anyway, so the remote special case was never reachable there. Conformance: the lifecycle-create, batch-creator and batch-apply contracts now pin created_by == actor for an item that names none, on every leg. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(httpclient): GetIssue answers a miss with storage.ErrNotFound, like the local stores The http store's raw GetIssue answered a missing id with (nil, nil), where DoltStore and the embedded store return a wrapped storage.ErrNotFound. A caller written against the backend contract read the http miss as a hit: `bd create --graph` refused every explicit-id plan over http (patched in cmd/bd on feat/http-mc-corpus; that workaround is reverted there). GetIssue now returns the miss (and the empty id) as storage.ErrNotFound, spelled as issueops.GetIssueInTx spells it. GetLabels, which reads through GetIssue, keeps the local read's "no labels" answer for a missing id; the `bd list --parent` walk reads the typed miss as "parent issue not found". The served bridge test now holds the local reference store and the http store to the same miss: ErrNotFound with the same text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(createbatchequiv): re-record the apply golden for the created_by default c2866ea7fe made the create role default an empty CreatedBy to the request's actor, so every create item of the apply scenario's batch (actor "apply-writer") now stores created_by "apply-writer" instead of "". TestCreateBatchFastPathsMatchPerRow_*/apply compared the stored rows to a digest recorded before that change and failed on exactly the three tables the column reaches: issues and wisps (the row) and events (the update event's old-value snapshot). Fast and per-row bodies still agree; the batch-apply conformance contract pins the same value. Bisected with bazel: passes at be92efe40f's integ twin 696f7acc8e, fails from the created_by commit on. Only apply.json's three digests move. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * style: gofmt ledger.go and the externaldeps remote-roles test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cmd/bd): bd create reads routing settings local-only on a remote backend too determineAutoRoutedRepoPath skipped a remote backend's settings document (routing targets are local paths that one shared document cannot name for every client), but getRoutingConfigValue, which `bd create` and migrate-personal read routing.* and contributor.* through, still asked it. The same workspace could route a create one way and a lookup another, and every create paid a settings round trip per key. Both now go through routingSettingsStore: nil for a remote backend, so routing comes from config.yaml / the environment only there, and a local store is still consulted. A unit test holds both reads to the rule with a store that counts settings reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cmd/bd): say so when update -s closed drops an ambient CLAUDE_SESSION_ID Over http `bd update -s closed` cannot carry closed_by_session, so the CLI drops it rather than refusing the close. An explicit --session printed a notice; the ambient CLAUDE_SESSION_ID every agent under Claude Code exports was dropped without a word, a silent data difference from a local backend (the served corpus's mc-update-meta-status-closed). The drop is now named on stderr in both cases, once per command, pointing at `bd close`, whose wire operation records the session. The served e2e asserts the notice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(backend/http): hold bd list --limit 2 to each side's own unlimited order TestE2E_ListWithGCFiltersMatchesEmbedded compared the --limit 2 rows of the served and embedded workspaces as sets. The seed has four P2 rows, so the limit cuts a priority tie whose created_at order differs between two workspaces seeded seconds apart: a test-only flake, the order itself being total. Each side's two rows must now be, in order, the first two of that same side's --limit 0 listing; the unlimited listings are still compared across sides by the shape loop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test: unit-tier pins for the created_by default, the policy token and the GetIssue miss Three review mutations were caught only by a heavier tier (the uow conformance legs, the served httpclient tier) or by one package's test alone. Each now has a unit test where its rule lives: - issueops: PreparePublicCreateRequest defaults an empty CreatedBy to the actor and keeps an explicit one, without mutating the caller's request. - externaldeps: the policy layer AppliedToProvider finds becomes the handshake's policy.external_dependencies through httpapi.Listen, the composition bd serve performs, and a raw provider's handshake lacks it. - httpclient (no embedded engine): GetIssue over the real wire client against a stub server answers a 404 not_found, and the empty id without dialing, as storage.ErrNotFound spelled like the local stores. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(changelog): S6b/c/d entries match the code The S6 entry still said `bd create` suppresses created_by on a remote workspace and that the external-dependency policy runs client-side. Since S6b/c/d, created_by defaults to the actor in the library on every backend, and every bd serve composed through the policy advertises policy.external_dependencies, so clients pass those operations through; the client-side policy (now in role terms) runs only against a server that does not advertise it. New entries: the advertised policy token, bd ping over http, the created_by library default, closed_by_session dropped by an http `bd update -s closed` (with a notice, typed or ambient), reopen without a Provenance label over http, local-only routing.* / contributor.* on a remote backend, GetIssue's miss as storage.ErrNotFound, and list/children/show counts/dep tree over http. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(externaldeps): keep S6's list --ready, --claim-next refusal and lost-race error on the S6c composition The re-adopted S6 head (#7288) carries the review fixup's remote role composition; S6c replaces it with its own (rolesAreRemote, the widened ready window, the policy passthrough). Two behaviours S6 shipped and its reviews pinned would otherwise go: - bd close --claim-next against a server that does not apply the policy is refused whole, before anything is read or closed, with "the served batch close cannot carry a next claim, so nothing was closed; close without --claim-next, then run `bd ready --claim`". S6c passed the batch to the http closer, whose W-CloseBatchRequest.ClaimNext refusal drops the remedy, so TestE2E_BDOverHTTP's two refuseClaimNext steps went red. A request invalid on every backend is still ErrValidation first, and a server that applies the policy still gets the request untouched. - remoteReadyClaimer.ClaimNext reports a page on which every candidate was lost to another actor as "claim ready: lost N races ...", not as the empty answer that means there is no work. - `bd list --ready` (List with ReadyFlag) is answered by the policy store's own reader over the served ready reads, as S6 does. S6c passed it to the served listing, which cannot carry ReadyFlag (httpclient ledger row E-ListRequest.ReadyFlag), so it exited 1 over http with or without external refs; TestE2E_BDOverHTTP and TestServedRolesKeepTheExternalDependencyPolicy were red on it. TestRemoteReaderAnswersAReadyListingWithoutTheWireFlag pins it, with the fake's served List refusing ReadyFlag as the wire does. S6's composition tests now run against S6c as remote_roles_composition_test.go. Their fake serves Ready the way a server does (the S6 composition read ready work through the legacy policy reader instead), and two call logs gain that Ready. TestRemoteBatchCloserRefusesANextClaim, TestRemoteBatchCloserValidatesANextClaimFirst and TestRemoteReadyClaimerReportsLostRaces were red on S6c before this change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(externaldeps): unassigned claim-next and fail-closed close reads Review fixes for the S6c composition against a server that does not advertise policy.external_dependencies: the two majors of review attempt 1, plus the minors on the same code. - ReadyClaimer: the composed claim-next reads only open, unassigned ready rows (Unassigned=true, Assignee cleared), the candidates the local ClaimReadyIssueInTx selects. A row another actor holds, or one already assigned to the caller, is no longer taken or counted as a lost race. Each pass reads 25 candidates past the blocked rows, as httpclient's composed claim does, and a full window lost end to end is read once more: claimed rows leave the unassigned set. Only a claim that tried candidates and won none is an error. - BatchCloser: an externally blocked item travels to the server only when its status read finds it closed or not found (liveRefusal). Any other read error is that item's outcome, so a transient or auth failure no longer forwards a refused close to a server that will not refuse it. - TreeWalker: a failed capability probe renders the external leaves over the walked tree instead of failing a walk the server already answered. appendTreeExternalReferences skips an id the tree holds, so an enforcing server's own leaves are not doubled. - remoteEdges names each anchor once and skips an empty one, which the http EdgeReader refuses with ErrValidation. The composition fakes now honor Unassigned/Assignee as workapi.BuildReadyFilter does, model a rival claim landing first and a failing GetIssue, and refuse an empty edge anchor as httpclient does. New: TestRemoteReadyClaimerTakesOnlyUnassignedWork, TestRemoteReadyClaimerWalksAContendedFront, TestRemoteBatchCloserAnswersAFailedReadWithIt, TestRemoteEdgesNamesEachAnchorOnce, and the probe-failure cases of TestRemoteTreeWalkerAddsExternalLeaves. Each is red with its fix reverted. From review attempt 2, three nearby cleanups: - TestServedRolesKeepTheExternalDependencyPolicy seeds open rows held by another actor and by the claimant ahead of the free work, then claims with and without an assignee filter. The unassigned-only claim is now pinned over a real served server, not only through the fakes: red with the pre-fixup remote_roles.go, with filter.Unassigned dropped, and (the filtered claim) with an explicit assignee honored. - The capabilities description in openapi.v0.yaml (and the regenerated types.gen.go comment) no longer calls the whole list build-level: policy.external_dependencies depends on how the server composed its roles, as the paragraph above it says. - createbatchequiv's golden note names issueops.PreparePublicCreateRequest instead of a commit id that is not on this branch. Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(backend/http): count a not_found read as reaching the remote in #7469's credential doors main's #7469 added TestExplicitCredentialIgnoresTheEnvPlaintextGrant. Its OpenWith and Open doors read bd-1 from plaintextRemote, which answers every issue read not_found, and the granted leg needs that read to return a nil error. That held while the http client answered a miss with (nil, nil). This branch's "fix(httpclient): GetIssue answers a miss with storage.ErrNotFound, like the local stores" makes the same read return storage.ErrNotFound. So on main plus this branch both doors fail at per_open_credential_test.go:392 ("with Target.AllowInsecureCredential: not found: issue bd-1") under plain go test. The merge is textually clean, so only a build of the merge shows it. The two store doors now count storage.ErrNotFound as success, since that answer came off the wire. The assertions are unchanged. The refused leg still needs the "refusing to send a credential" error and no request on the transport. The granted leg still needs exactly one request carrying "Bearer explicit-token": a granted read that never reaches the wire still fails at :408. Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
326 lines
14 KiB
Go
326 lines
14 KiB
Go
package httpapi
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/steveyegge/beads/internal/storage"
|
|
"github.com/steveyegge/beads/internal/types"
|
|
"github.com/steveyegge/beads/issueops"
|
|
)
|
|
|
|
// These cover the transport half of POST /v0/beads/issues:batchCreate — the
|
|
// body shape, the refusals this operation owns, and how a role refusal is named
|
|
// on the wire. Everything below the wire is the role's, pinned by
|
|
// backend/conformance/batch_creator_contract.go at all three backends.
|
|
|
|
const batchCreatePath = "/v0/beads/issues:batchCreate"
|
|
|
|
func newBatchCreateServer(t *testing.T, creator *roleBatchCreator) *testServer {
|
|
t.Helper()
|
|
return newTestServer(t, rolesConfig(Config{BatchCreator: creator}))
|
|
}
|
|
|
|
// TestBatchCreatePassesTheRequestToTheRoleAndAnswersWithWhatItCreated pins the
|
|
// projection in both directions: the wire members become the role's request,
|
|
// and the role's issues come back in request order carrying the ids only the
|
|
// server can assign.
|
|
func TestBatchCreatePassesTheRequestToTheRoleAndAnswersWithWhatItCreated(t *testing.T) {
|
|
creator := &roleBatchCreator{}
|
|
ts := newBatchCreateServer(t, creator)
|
|
|
|
resp := ts.claim(t, batchCreatePath, `{"actor":"alice","items":[
|
|
{"title":"first","priority":1,"issue_type":"bug","labels":["api"],
|
|
"dependencies":[{"target_id":"bd-9","type":"blocks"}]},
|
|
{"title":"second","description":"body"}
|
|
]}`)
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Fatalf("status = %d, want 200: %s", resp.StatusCode, readAll(t, resp))
|
|
}
|
|
body := decodeBody(t, resp)
|
|
items, _ := body["items"].([]any)
|
|
if len(items) != 2 {
|
|
t.Fatalf("items = %v, want the two issues the role created", body["items"])
|
|
}
|
|
for i, want := range []string{"bd-batch-0", "bd-batch-1"} {
|
|
issue, _ := items[i].(map[string]any)
|
|
if issue["id"] != want {
|
|
t.Errorf("items[%d].id = %v, want %q: the generated ids come back in request order", i, issue["id"], want)
|
|
}
|
|
}
|
|
if _, present := body["has_more"]; present {
|
|
t.Error("the response carries has_more; this is not a page and a client must not look for a second one")
|
|
}
|
|
|
|
reqs := creator.createRequests()
|
|
if len(reqs) != 1 {
|
|
t.Fatalf("role calls = %d, want 1", len(reqs))
|
|
}
|
|
got := reqs[0]
|
|
if got.Actor != "alice" {
|
|
t.Errorf("actor = %q, want the one the wire named", got.Actor)
|
|
}
|
|
if len(got.Items) != 2 {
|
|
t.Fatalf("items = %d, want 2", len(got.Items))
|
|
}
|
|
first := got.Items[0]
|
|
if first.Issue.Title != "first" || first.Issue.Priority != 1 || first.Issue.IssueType != types.TypeBug {
|
|
t.Errorf("item 0 = %+v, want the wire's title, priority and issue_type", *first.Issue)
|
|
}
|
|
if first.Issue.Status != types.StatusOpen {
|
|
t.Errorf("item 0 status = %q, want open: a created issue starts open", first.Issue.Status)
|
|
}
|
|
if len(first.Issue.Labels) != 1 || first.Issue.Labels[0] != "api" {
|
|
t.Errorf("item 0 labels = %v, want the wire's", first.Issue.Labels)
|
|
}
|
|
if len(first.Dependencies) != 1 ||
|
|
first.Dependencies[0].TargetID != "bd-9" || first.Dependencies[0].Type != types.DepBlocks {
|
|
t.Errorf("item 0 dependencies = %+v, want the one edge the wire named", first.Dependencies)
|
|
}
|
|
// Absent members are absent, not zero-valued strings the role has to
|
|
// second-guess: an omitted priority is the workspace default.
|
|
if got.Items[1].Issue.Priority != 0 || got.Items[1].Issue.Description != "body" {
|
|
t.Errorf("item 1 = %+v, want the wire's description and no priority", *got.Items[1].Issue)
|
|
}
|
|
// created_by is not the handler's to stamp: every item reaches the role
|
|
// without one, and the role defaults it to the request's actor
|
|
// (backend/conformance's batch-creator contract pins that half).
|
|
for i, item := range got.Items {
|
|
if item.Issue.CreatedBy != "" {
|
|
t.Errorf("item %d created_by = %q, want it left to the role", i, item.Issue.CreatedBy)
|
|
}
|
|
}
|
|
// No provenance: the file name a CLI batch spells has no analogue here, so
|
|
// the entry reads as the implementation's default rather than as a lie.
|
|
if got.Provenance != "" {
|
|
t.Errorf("provenance = %q, want empty: this surface names no source file", got.Provenance)
|
|
}
|
|
}
|
|
|
|
// TestBatchCreateRefusesTheShapesTheDocumentRefuses walks the 400s this
|
|
// operation owns. Every one of them is answered BEFORE the role is reached, so
|
|
// a refusal here is also the proof that nothing was created.
|
|
func TestBatchCreateRefusesTheShapesTheDocumentRefuses(t *testing.T) {
|
|
for _, test := range []struct {
|
|
name string
|
|
body string
|
|
wantParam string
|
|
}{
|
|
{"no actor", `{"items":[{"title":"t"}]}`, "actor"},
|
|
{"blank actor", `{"actor":" ","items":[{"title":"t"}]}`, "actor"},
|
|
{"actor with a newline", "{\"actor\":\"alice\\nbd: create\",\"items\":[{\"title\":\"t\"}]}", "actor"},
|
|
{"null actor", `{"actor":null,"items":[{"title":"t"}]}`, "actor"},
|
|
{"no items", `{"actor":"alice"}`, "items"},
|
|
{"empty items", `{"actor":"alice","items":[]}`, "items"},
|
|
{"items is not an array", `{"actor":"alice","items":{"title":"t"}}`, "items"},
|
|
{"unknown top-level member", `{"actor":"alice","items":[{"title":"t"}],"dry_run":true}`, "dry_run"},
|
|
{"unknown item member", `{"actor":"alice","items":[{"title":"t","id":"bd-1"}]}`, "items[0].id"},
|
|
{"unknown edge member", `{"actor":"alice","items":[{"title":"t","dependencies":[{"target_id":"bd-9","type":"blocks","reverse":true}]}]}`, "items[0].dependencies.reverse"},
|
|
{"no title", `{"actor":"alice","items":[{"description":"d"}]}`, "items[0].title"},
|
|
{"blank title", `{"actor":"alice","items":[{"title":" "}]}`, "items[0].title"},
|
|
{"priority out of range", `{"actor":"alice","items":[{"title":"t","priority":9}]}`, "items[0].priority"},
|
|
{"priority is not a number", `{"actor":"alice","items":[{"title":"t","priority":"high"}]}`, "items[0]"},
|
|
{"edge with no target", `{"actor":"alice","items":[{"title":"t","dependencies":[{"target_id":"","type":"blocks"}]}]}`, "items[0].dependencies.target_id"},
|
|
// A value at all, not membership of a list: the edge vocabulary is
|
|
// OPEN, so "nonsense" is a legal type here and only an unstorable one
|
|
// is refused.
|
|
{"edge with an unstorable type", `{"actor":"alice","items":[{"title":"t","dependencies":[{"target_id":"bd-9","type":"` + strings.Repeat("x", types.MaxDependencyTypeLen+1) + `"}]}]}`, "items[0].dependencies.type"},
|
|
{"the second item is the bad one", `{"actor":"alice","items":[{"title":"ok"},{"title":""}]}`, "items[1].title"},
|
|
} {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
creator := &roleBatchCreator{}
|
|
ts := newBatchCreateServer(t, creator)
|
|
|
|
resp := ts.claim(t, batchCreatePath, test.body)
|
|
if resp.StatusCode != http.StatusBadRequest {
|
|
t.Fatalf("status = %d, want 400: %s", resp.StatusCode, readAll(t, resp))
|
|
}
|
|
body := decodeBody(t, resp)
|
|
if body["code"] != string(CodeInvalidArgument) {
|
|
t.Errorf("code = %v, want %q", body["code"], CodeInvalidArgument)
|
|
}
|
|
if body["param"] != test.wantParam {
|
|
t.Errorf("param = %v, want %q — a client dispatches on this rather than on the detail", body["param"], test.wantParam)
|
|
}
|
|
if calls := creator.createRequests(); len(calls) != 0 {
|
|
t.Errorf("the role was called %d times for a refused request; nothing may be created", len(calls))
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestBatchCreateRefusesAnOversizeBatch pins the one size bound this operation
|
|
// owns. It is a bound on how long a request may hold a write transaction, so it
|
|
// is refused before the role is reached rather than after.
|
|
func TestBatchCreateRefusesAnOversizeBatch(t *testing.T) {
|
|
creator := &roleBatchCreator{}
|
|
ts := newBatchCreateServer(t, creator)
|
|
|
|
items := make([]string, maxBatchCreateItems+1)
|
|
for i := range items {
|
|
items[i] = fmt.Sprintf(`{"title":"issue %d"}`, i)
|
|
}
|
|
resp := ts.claim(t, batchCreatePath, `{"actor":"alice","items":[`+strings.Join(items, ",")+`]}`)
|
|
if resp.StatusCode != http.StatusBadRequest {
|
|
t.Fatalf("status = %d, want 400: %s", resp.StatusCode, readAll(t, resp))
|
|
}
|
|
if body := decodeBody(t, resp); body["param"] != "items" {
|
|
t.Errorf("param = %v, want items", body["param"])
|
|
}
|
|
if calls := creator.createRequests(); len(calls) != 0 {
|
|
t.Errorf("the role was called for an oversize batch")
|
|
}
|
|
}
|
|
|
|
// TestBatchCreateNamesARoleRefusalInTheServersOwnWords is the case
|
|
// failBatchCreate exists for. The absent-target refusal arrives as
|
|
// ErrValidation WRAPPING ErrNotFound, and the shared classifier reaches
|
|
// ErrNotFound first — so without the operation's own failure path this 400
|
|
// would be a 404 for a request that addressed no resource at all. The detail
|
|
// is the server's own sentence: the role's carries a driver error naming
|
|
// tables and constraints.
|
|
func TestBatchCreateNamesARoleRefusalInTheServersOwnWords(t *testing.T) {
|
|
for _, test := range []struct {
|
|
name string
|
|
err error
|
|
wantDetail string
|
|
}{
|
|
{
|
|
name: "an absent edge target is a 400, not a 404",
|
|
err: fmt.Errorf("create batch item 1: %w: create: dependency target does not exist: "+
|
|
"Error 1452 (23000): Cannot add or update a child row: a foreign key constraint fails "+
|
|
"(`beads`.`dependencies`): %w", storage.ErrValidation, storage.ErrNotFound),
|
|
wantDetail: "a dependency target names no issue in this workspace; nothing was created",
|
|
},
|
|
{
|
|
name: "a content refusal is a 400",
|
|
err: fmt.Errorf("create batch item 0: %w: create: invalid issue type", storage.ErrValidation),
|
|
wantDetail: "an item was refused by this workspace's own validation; nothing was created",
|
|
},
|
|
} {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
ts := newBatchCreateServer(t, &roleBatchCreator{err: test.err})
|
|
|
|
resp := ts.claim(t, batchCreatePath, `{"actor":"alice","items":[{"title":"t"}]}`)
|
|
if resp.StatusCode != http.StatusBadRequest {
|
|
t.Fatalf("status = %d, want 400: %s", resp.StatusCode, readAll(t, resp))
|
|
}
|
|
body := decodeBody(t, resp)
|
|
if body["code"] != string(CodeInvalidArgument) {
|
|
t.Errorf("code = %v, want %q", body["code"], CodeInvalidArgument)
|
|
}
|
|
if body["detail"] != test.wantDetail {
|
|
t.Errorf("detail = %v, want %q", body["detail"], test.wantDetail)
|
|
}
|
|
if detail, _ := body["detail"].(string); strings.Contains(detail, "foreign key") {
|
|
t.Error("the detail quotes the storage error; 4xx details reflect the caller's input, not server internals")
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestBatchCreateReportsANonValidationRoleFailureAsTheGenericFailure pins the
|
|
// other half of failBatchCreate: an error that is not the role's own refusal
|
|
// still goes through the shared classifier, so contention and outages keep the
|
|
// codes every other route uses.
|
|
func TestBatchCreateReportsANonValidationRoleFailureAsTheGenericFailure(t *testing.T) {
|
|
ts := newBatchCreateServer(t, &roleBatchCreator{err: errors.New("connection reset by the void")})
|
|
|
|
resp := ts.claim(t, batchCreatePath, `{"actor":"alice","items":[{"title":"t"}]}`)
|
|
if resp.StatusCode != http.StatusInternalServerError {
|
|
t.Fatalf("status = %d, want 500: %s", resp.StatusCode, readAll(t, resp))
|
|
}
|
|
if body := decodeBody(t, resp); body["code"] != string(CodeInternal) {
|
|
t.Errorf("code = %v, want %q", body["code"], CodeInternal)
|
|
}
|
|
}
|
|
|
|
// TestBatchCreateRefusesACreatorThatAnswersWithNothing pins
|
|
// checkedBatchCreator: a nil entry would be a nil dereference in the handler,
|
|
// so it is the generic 500 and above all not a panic.
|
|
func TestBatchCreateRefusesACreatorThatAnswersWithNothing(t *testing.T) {
|
|
for _, test := range []struct {
|
|
name string
|
|
issues []*types.Issue
|
|
}{
|
|
{"a nil entry", []*types.Issue{nil}},
|
|
{"fewer issues than items", []*types.Issue{}},
|
|
} {
|
|
t.Run(test.name, func(t *testing.T) {
|
|
ts := newBatchCreateServer(t, &roleBatchCreator{issues: test.issues})
|
|
|
|
resp := ts.claim(t, batchCreatePath, `{"actor":"alice","items":[{"title":"t"}]}`)
|
|
if resp.StatusCode != http.StatusInternalServerError {
|
|
t.Fatalf("status = %d, want 500: %s", resp.StatusCode, readAll(t, resp))
|
|
}
|
|
assertNoPanic(t, ts)
|
|
})
|
|
}
|
|
}
|
|
|
|
// TestBatchCreateRefusesANonJSONContentType pins the CSRF control this
|
|
// operation inherits from the claim: a JSON content type is not CORS-"simple",
|
|
// so a cross-origin write always triggers a preflight this server never
|
|
// approves.
|
|
func TestBatchCreateRefusesANonJSONContentType(t *testing.T) {
|
|
creator := &roleBatchCreator{}
|
|
ts := newBatchCreateServer(t, creator)
|
|
|
|
resp := ts.postBody(t, batchCreatePath, "text/plain", `{"actor":"alice","items":[{"title":"t"}]}`)
|
|
if resp.StatusCode != http.StatusBadRequest {
|
|
t.Fatalf("status = %d, want 400: %s", resp.StatusCode, readAll(t, resp))
|
|
}
|
|
if body := decodeBody(t, resp); body["param"] != "Content-Type" {
|
|
t.Errorf("param = %v, want Content-Type", body["param"])
|
|
}
|
|
if calls := creator.createRequests(); len(calls) != 0 {
|
|
t.Error("the role was called for a request that skipped the preflight")
|
|
}
|
|
}
|
|
|
|
// TestBatchCreateRefusesAQueryParameter pins that the document-level
|
|
// unknown-parameter rule reaches this operation too: it declares no parameters,
|
|
// so every query key is refused.
|
|
func TestBatchCreateRefusesAQueryParameter(t *testing.T) {
|
|
ts := newBatchCreateServer(t, &roleBatchCreator{})
|
|
|
|
resp := ts.claim(t, batchCreatePath+"?dry_run=true", `{"actor":"alice","items":[{"title":"t"}]}`)
|
|
if resp.StatusCode != http.StatusBadRequest {
|
|
t.Fatalf("status = %d, want 400: %s", resp.StatusCode, readAll(t, resp))
|
|
}
|
|
body := decodeBody(t, resp)
|
|
if body["param"] != "dry_run" || body["reason"] != string(ReasonUnknownParameter) {
|
|
t.Errorf("param/reason = %v/%v, want dry_run/unknown_parameter", body["param"], body["reason"])
|
|
}
|
|
}
|
|
|
|
// TestBatchCreateIsNotReachableByOtherMethods pins that the collection custom
|
|
// method is a POST and nothing else, so a GET of it is the catch-all's answer
|
|
// rather than a listing.
|
|
func TestBatchCreateIsNotReachableByOtherMethods(t *testing.T) {
|
|
ts := newBatchCreateServer(t, &roleBatchCreator{})
|
|
|
|
resp := ts.get(t, batchCreatePath)
|
|
if resp.StatusCode == http.StatusOK {
|
|
t.Fatalf("GET %s = 200; the custom method is a POST", batchCreatePath)
|
|
}
|
|
}
|
|
|
|
// TestBatchCreateDoesNotShadowTheClaimRoute pins the one routing risk the new
|
|
// path carries: both are POSTs under /v0/beads/issues, and the claim's pattern
|
|
// is a wildcard wide enough to have swallowed this one had the separating slash
|
|
// not been there.
|
|
func TestBatchCreateDoesNotShadowTheClaimRoute(t *testing.T) {
|
|
issues := &fakeIssues{issue: seededIssue("bd-1", "alice", types.StatusInProgress)}
|
|
ts, _ := newClaimServer(t, issues)
|
|
|
|
resp := ts.claim(t, "/v0/beads/issues/bd-1:claim", `{"actor":"alice"}`)
|
|
if resp.StatusCode != http.StatusOK {
|
|
t.Fatalf("claim status = %d, want 200: %s", resp.StatusCode, readAll(t, resp))
|
|
}
|
|
}
|
|
|
|
var _ issueops.BatchCreator = (*roleBatchCreator)(nil)
|