* schema+storage: restore 0068, move participation_generation to 0070 (be-blvmg) MAYOR RULING 2026-09-29 on tracker be-waare: migration 0068 shipped to origin/main as attribution_status-only (be-v33pa). be-h89oq's lineage had appended participation_generation steps 4-5 to that same file while it was still unmerged, which check-migration-hygiene.sh Check C correctly rejects once 0068 is frozen on main. This restores 0068 to origin/main's exact content and re-homes the participation_generation column (issues + wisps, design section 16.3 steps 4-5, be-dt74u amendment) in a new migration 0070, with its clone-local ignored/0028 twin for wisps. Ports back the participation_generation write-fence consumer code (RecordVersionInTx in internal/storage/issueops/version_history.go and its callers) and the dualwrite contract tests that exercise it. RED: the CLI-bundle direct-DDL override for 0070's guarded PREPARE/ALTER pair is not yet registered in cli_migrations.go, so TestBundleMigrationsWithPreparedALTERAreOverriddenOrJustified, TestMigration0070AddsParticipationGeneration, and TestAllMigrationsSQLUsesDirectDDLForKnownCLIIncompatibilities fail -- correctly: a fresh CLI-built bundle would silently omit the column (dolthub/dolt#11345) while a runtime-migrated store has it. git diff origin/main -- internal/storage/schema/migrations/0068_*.sql is empty, confirming 0068 is untouched. Agent-Signature: model=claude-sonnet-5; reasoning=high * schema: register CLI-bundle direct-DDL override for migration 0070 (be-blvmg) GREEN: adds cliMigration0070AddParticipationGeneration and its dispatch entries (cliCompatibleMigrationSQL, cliSubstituteAssumesWispTables), the same pre-2.3 Dolt CLI PREPARE/ALTER escape hatch 0067's wisps.current_revision and 0068's attribution_status already use (dolthub/dolt#11345). Makes TestBundleMigrationsWithPreparedALTERAreOverriddenOrJustified, TestMigration0070AddsParticipationGeneration, and TestAllMigrationsSQLUsesDirectDDLForKnownCLIIncompatibilities pass: a fresh CLI-built bundle now carries participation_generation on both issues and wisps, matching what a runtime-migrated store gets. scripts/check-migration-hygiene.sh checks A-D pass; 0068 remains byte-identical to origin/main. Agent-Signature: model=claude-sonnet-5; reasoning=high * build: bazel-sync BUILD.bazel for migration 0070 files (be-blvmg) make bazel-sync (gazelle) picked up two files the RED commit added that the hand-ported BUILD.bazel hadn't listed yet: 0070's embedded .up.sql in the go_library embedsrcs and migration_0070_add_participation_generation_test.go in the go_test srcs. Agent-Signature: model=claude-sonnet-5; reasoning=high * test(feat): red — Fix: enable history before fixtures in TestDualWriteDeleteNeighborRewriteRidesTheDeletesDoltCommit — PR #6943's §16.2b write fence leaves its flag-off neighbor legacy, so the delete mints 0 rows (stacked on44418b3) (refs be-fyaja) * feat: green — Fix: enable history before fixtures in TestDualWriteDeleteNeighborRewriteRidesTheDeletesDoltCommit — PR #6943's §16.2b write fence leaves its flag-off neighbor legacy, so the delete mints 0 rows (stacked on44418b3) (refs be-fyaja) * test(conformance): pin that a wisp reaching the issues plane begins its history (be-31mnz) Review feedback on #6943, blocker 1: with the flag on, a promoted wisp is never versioned. None of the five RunParticipationGeneration* cases reaches a promotion, so nothing caught it. Two contract cases, wired on all three legs: - RunParticipationGenerationWispPromotionBeginsHistory: create a wisp with the flag on, promote it, and require a stamped participation_generation, one version row, and +1 on the next update. - RunParticipationGenerationWispPersistenceMoveBeginsHistory: the same check for a persistence-mode update (bd update --persistent). This mints at a different site than promotion on every leg: the guarded update's one end-of-update mint on dolt and embeddeddolt, and MoveIssuePersistenceInTx's own on uow. "Wisp" is in the names because this contract already says "promoted" in R2.3's sense (ProceedsForPromotedRecord), which is a different operation. The fixture gains CreateWisp, PromoteWisp and MovePersistent closures, and each leg's FixtureKitIsWired checks them. Red at this commit on the embedded leg: after the arrival there are 0 rows and participation_generation is NULL, and after the update there are still 0 rows. A flag-on durable create goes 1 -> 2 in the same store. * fix(issueops): mint a wisp's first issues-plane version create-shaped (be-31mnz) Review feedback on #6943, blocker 1. A promotion, or a persistence move out of the wisps table, inserts a new issues row. A wisp never declares participation (FR-8), so that row's participation_generation is NULL. Both sites minted through the update-shaped RecordVersionInTx, and the section 16.2b fence read the NULL as legacy and skipped the mint. Nothing stamps the column later, so every later update skipped too, and a record created with versioned history on was never versioned. These sites now use RecordVersionForCreateInTx, which stamps the column and mints version 1, as a create on the issues plane does: - PromoteFromEphemeralInTx (promote.go). - MoveIssuePersistenceInTx's move out of the wisps table. - ExecuteUpdate's one end-of-update mint (execution.go), when its persistence patch did that move. This is the site bd update --persistent reaches on the dolt and embeddeddolt legs, and the review did not list it. PersistenceMoveResult.EnteredIssuesPlane tells ExecuteUpdate which entry point to use. One site the review named stays update-shaped on purpose: MoveIssuePersistenceInTx's same-plane repair, which clears a stray wisp flag on a row already in issues. That row keeps its own participation_generation. A row created with the flag on still mints. A legacy row stays legacy, because a repair is an ordinary write and R2.3 says an ordinary write does not promote it. A create-shaped mint there would stamp the legacy row and start versioning it. * docs(schema): 0070 must precede turning versioned history on (be-31mnz) Review note on #6943 (schema skew). The write fence reads participation_generation on every flag-on mint of an issues-plane row. On a store that has not applied 0070 the read fails, and the mutation fails with it instead of skipping. The migration header now says so, and says that the flag-off path (the default) returns before the read, so a store below 0070 writes exactly as before. Comment only. 0070 is not on main, so check-migration-hygiene's frozen-file check does not apply to it, and no test pins its bytes. * test(dolt): a persistence repair keeps the row's own participation (be-31mnz) Pins why MoveIssuePersistenceInTx's same-plane repair stays update-shaped while promotion and a move out of the wisps table became create-shaped (the previous commit). The repair clears a stray wisp flag on a row that already lives in issues, so the row keeps its own participation_generation. TestPersistenceRepairKeepsTheRowsOwnParticipation runs the repair with versioned history on for a legacy row (created with the flag off) and a participating row (created with it on), through both repair entry points: MoveIssuePersistenceInTx and a guarded update with a persistence patch. They mint at different sites. The legacy row must stay NULL and mint nothing, since R2.3 says an ordinary write does not promote it. The participating row must mint one version. participation_generation must not change in either case. It fails if the repair mint is create-shaped, which would stamp and start versioning the legacy row. * test(dolt): a delete's rewrite of a legacy neighbor mints nothing (be-31mnz) Folded in from bee's R1 on #6961, note 1. Once TestDualWriteDeleteNeighborRewriteRidesTheDeletesDoltCommit started creating its neighbor with history on, nothing covered a delete whose neighbor was created with history off. Under the section 16.2b fence, the expected result for that case is different: the rewrite still runs, but it mints nothing. TestDualWriteDeleteSkipsALegacyNeighborsRewrite creates the fixtures with history off, turns history on, and force-deletes the cited target. It then checks four things: the rewrite ran (ReferencesUpdated=1), the neighbor has no issue_versions rows, its participation_generation is still NULL, and dolt_status is clean for issue_versions, store_epoch and issues. * test(embeddeddolt): batch-created rows are stamped with the participation generation A batch create writes its rows first and mints each created row's first version last, after the creation-time edges land. The mint has to stay create-shaped for rows the batch inserted (stamping participation_generation from the store epoch) and update-shaped for rows it only upserted over (skipped while the row is a legacy row), so the per-row isNew has to survive the deferral to the batch's final mint pass. Pin that on the embedded engine: - brand-new explicit-id rows are stamped with the store epoch and get one version row each, and match the same input run one row at a time with the batch-create fast paths off (5 rows, and 250 rows across three INSERT statements); - a legacy row the batch upserts over keeps a NULL participation_generation and gets no version row, while the new rows beside it are stamped; - with versioned history off, no row is stamped and no version row is written. * ci(bazel): enroll the participation-generation tests in the embedded shards The embedded-Dolt shard manifest has to name every top-level Test* in internal/storage/embeddeddolt, or the exact-once coverage check fails. The two participation-generation fence tests were written before that check landed on main, and the batch-create stamping test is new, so none of the three is listed yet. Add them to the 15-shard block as the generator's incremental output: three inserted lines, no existing assignment moves. Also list the new batch-create test file in the embeddeddolt_test srcs, in sorted position, so the Bazel target compiles it alongside the Go build. Its imports are already among that target's deps. Rebase note (maintainer): on current main the embedded storage manifest uses a 40-shard block; the generator's incremental output placed these three tests in shards 18, 19 and 39 and re-sorted one existing shard-12 line. * fix(issueops): keep a created row's updated_at when its first version is minted Minting a version is bookkeeping. It must not change a user-visible column of the row it versions. The create-shaped mint stamps participation_generation with an UPDATE of the issues row. issues.updated_at is ON UPDATE CURRENT_TIMESTAMP, so an UPDATE that changes any other column and does not name updated_at rewrites it with the clock. Before the stamp, a row's first mint left current_revision at its column default of 1, so the UPDATE changed nothing and the clause never fired. The stamp moves participation_generation from NULL to the store epoch, so the clause fires on every row whose first version is minted and replaces the updated_at an import supplies. Set updated_at to itself in the stamp, as the blocked-state recompute in issueops/blocked_state.go already does, so the timestamp the row was created with survives. Add a regression that batch-creates rows with a supplied updated_at and requires both the stamp and the unchanged timestamp. * test(createbatchequiv): re-record the digests the participation-generation fence moves The fence does not re-mint rows that predate the stamp: a row whose participation_generation is still NULL gets no new version when a batch touches it. Main mints one, so six recorded entries move. The issue_versions entry of five scenarios loses the versions main mints for rows that predate the stamp: three rows in small, all eleven in depadd, all fifteen in waitsfor, four in import458 and two in import458-reject-stale. In depadd, eq-db1 and eq-dl are the only rows main mints more than once, and each of those mints moves their updated_at off the fixture date. The fence skips them, so the two rows keep the fixture date and join the issues_updated_at entry. No other table, list or counter digest changes, and the fast and per-row bodies already agree in every scenario. The digests were recorded with the embedded backend. The doc comment on GoldenDirEnv now says which entries were re-recorded. * test(storage): waive the participation-generation contracts on the http leg main's #7247 (6d21d337ad, "a served http conformance leg") registered a fourth leg, http, after this PR's original base. The PR's seven RunParticipationGeneration* entrypoints are neither wired nor waived there, so TestEveryLegWiresEveryRoleContract/http fails on the rebased branch. ParticipationGenerationFixture toggles the store's own versioned-history write flag and reads the raw participation_generation column back: store write-fence bookkeeping (design §16.2b), not a publicops role the HTTP client serves. Waive the seven cases on http with a named reason, the same waiver the donnabox fork carries (09e7ce05af), and keep the gap visible until a supported HTTP surface is designed and tested. go test ./internal/storage/ -run TestEveryLegWiresEveryRoleContract now passes on dolt, embeddeddolt, http and uow. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(issueops): decide the fence's plane by the table that holds the row recordVersionInTx chose the plane from the row's flags (IsWisp: Ephemeral || NoHistory) and then read participation_generation from the issues table only. A wisps-TABLE row can carry neither flag, so it passed the IsWisp return and the issues read failed with sql.ErrNoRows, aborting the whole mutation whenever versioned history is on. Two producers: - bd mol squash clears an ephemeral root's flag in place (UpdateIssue {"wisp": false}, after the root's close, in the squash's one transaction); update.go and the uow repository's Update both mint after it unconditionally. - import's "wisp_plane" marker (WispPlaneOverride = &true, flags false) routes the row to wisps, and the batch create mints it create-shaped. On origin/main the same paths do not fail but mint a stray issue_versions row for a wisps-table row, an FR-8 leak (wisps are never versioned). Fix: no issues row means nothing to version. ErrNoRows on the participation_generation read now returns nil (no version, no error) for update- and create-shaped calls alike. That read is the right signal and IsActiveWispInTx is not: GetIssueInTx has already resolved the row, so ErrNoRows on the issues read can only mean "not in issues", which is exactly the question the fence has to answer before it stamps or advances an issues row. It costs no extra query. IsActiveWispInTx asks the inverse question ("is it in wisps?") with one more query per mint, and it folds every error, including a transient one, into "not a wisp". Tests come first, as three new conformance contracts with three new ParticipationGenerationFixture hooks (ClearWispFlag, SquashWispRoot, CreateUnflaggedWisp). They are wired on the dolt, embeddeddolt and uow legs as subtests of each leg's TestParticipationGenerationFence (no new top-level test, so the shard manifests do not change) and waived on http with participationGenerationRawStoreWaiverReason: RunParticipationGenerationWispFlagClearMintsNothing (create wisp, UpdateIssue {"wisp": false}: no error, 0 versions) RunParticipationGenerationWispRootSquashMintsNothing (close + UpdateIssue {"wisp": false} in one transaction: no error, 0 versions) RunParticipationGenerationUnflaggedWispCreateMintsNothing (CreateIssues with WispPlaneOverride=&true, flags false: no error, 0 versions) Red before the fix, green after, run both ways: embeddeddolt (BEADS_TEST_EMBEDDED_DOLT=1): all three FAIL with "versioned history: read participation_generation for pg-...: sql: no rows in result set"; all three PASS after. uow: all three FAIL with the same error; all three PASS after. dolt (BEADS_TEST_DOLT_SERVER=local): WispRootSquash and UnflaggedWispCreate FAIL with the same error; both PASS after. WispFlagClear passes both ways on this leg. The store-level wisp update (updateWisp) runs in a transaction versioned history never scopes, so it never reaches the mint. For the same reason the leg's SquashWispRoot hook turns the events journal on for its one transaction: that pins the wisp writes to the scoped regular transaction, as in a journal-enabled workspace, so that case does reach the seam. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(issueops): a create stamps participation even when the row is flagged no-history A create-shaped mint (RecordVersionForCreateInTx) of a brand-new ISSUES-TABLE row that carries NoHistory or Ephemeral returned at the IsWisp check before the isCreate stamp, so participation_generation stayed NULL although the row was created with versioned history on. Import produces exactly that row: bd-r9uce keeps a promoted no-history wisp's durable row on the issues plane with its stray no_history=true (import_shared.go applyImportWispPlane: WispPlaneOverride = &false). When bd update --persistent later repairs the flag, it is a same-plane normalize whose mint is update-shaped by design (persistence.go: "A row created with the flag on proceeds; a legacy row stays legacy"). The NULL column made the fence read the row as legacy, so the repair and every later update were fenced and the row was never versioned. origin/main versions it after the repair (0, then 1, then 2 rows). Fix: on a create-shaped call, a flagged row that the issues table holds gets participation_generation stamped from store_epoch.epoch, the same source the minting stamp uses, read in the same transaction. No version is minted and updated_at is kept (SET ..., updated_at = updated_at), then the call returns. Update-shaped calls on flagged rows still return before any read. The table check from the previous commit now runs ahead of the IsWisp branch for create-shaped calls, so a flagged wisps-table row (the common wisp create) still mints and stamps nothing. That costs a create-shaped call on a flagged wisp one primary-key miss on issues, and only while versioned history is on. The store_epoch read/seed moves into readStoreEpochInTx so both stamps share it. Tests first: - New conformance contract RunParticipationGenerationNoHistoryIssueCreateDeclaresParticipation and hook CreateNoHistoryIssue. Wired on dolt, embeddeddolt and uow as a TestParticipationGenerationFence subtest and waived on http. With history on: create {NoHistory: true, WispPlaneOverride: &false} gives participation_generation non-NULL and 0 versions. The persistent repair (MovePersistent) then gives 1 version, and an update-shaped edit (MutateExisting, a title edit) gives 2. - New subtest TestCreateBatchParticipationGeneration/NoHistoryRowIsStampedUnversionedAndKeepsTheCallersUpdatedAt (embeddeddolt): a batch of such rows with a supplied updated_at comes out stamped, unversioned, and with updated_at unchanged. Red before the fix, green after, run both ways: dolt (BEADS_TEST_DOLT_SERVER=local), embeddeddolt (BEADS_TEST_EMBEDDED_DOLT=1), uow: the contract FAILS on all three legs ("participation_generation for pg-no-history-create is NULL ...", then "= 0 after the persistent repair, want 1", then "went from 0 to 0 ... want exactly +1"). It PASSES on all three after. embeddeddolt subtest: FAILS before the fix ("store_epoch has no row after the batch, so nothing stamped the 5 rows"). With the fix minus the updated_at = updated_at clause it FAILS on every row's updated_at. It PASSES with the full fix. No new top-level Test*, so the shard manifests do not change. The createbatchequiv goldens are unchanged: the dolt and embeddeddolt equivalence tests pass. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs: fix comments the rebase left stale Comment-only. - createbatchequiv.GoldenDirEnv said "One deliberate behavior change since ... nothing else moved" and then listed a second re-record, the participation-generation fence's. It now says there are two deliberate changes, puts each in its own paragraph, and scopes "nothing else moved" to apply.json, the only golden the first change touched. - issueops CreateIssueResult.isNew and deferredVersion still described one write path. After main's #7205, a row written by deferredCreates' multi-row INSERT reaches finishCreateIssueInTx(..., true) directly (create_batch_cache.go flush) and never passes through InsertIssueIfNew or CreateIssueInTxWithResult. isNew is InsertIssueIfNew's result on the per-row path and always true for a multi-row-INSERT row. deferredVersion is filled from both paths. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(issueops): pin the create/update shape split in the version guard TestEveryVersionedEntryPointMints counts RecordVersionInTx and RecordVersionForCreateInTx as one seam. A create-shaped site that fell back to the update-shaped entry therefore stayed green, though the fence then reads the new row's NULL participation_generation as legacy and the record is never versioned. The reverse case also stayed green: an update path that reached the create-shaped entry would stamp an existing legacy row and promote it, which R2.3 forbids. Add the split to the structural guard. It is two small tests over the same journalscan fixpoint and mintVersion edge discipline, with no AST changes: - TestCreateShapedEntryPointsMintCreateShaped: the create-shaped mint sites (finishCreateIssueInTx, CreateIssuesInTxWithContext, PromoteFromEphemeralInTx, moveIssuePersistenceInTx, executeUpdate) must each call RecordVersionForCreateInTx themselves. A delegate is not enough here, because executeUpdate runs its move with mintVersion=false and a batch switches finishCreateIssueInTx's mint off at run time. Every create-shaped entry point, the delegates and #7205's deferredCreates.flush included, must reach it. - TestUpdateShapedEntryPointsNeverMintCreateShaped: every other versionedEntryPoint must not reach RecordVersionForCreateInTx. The exception is ApplyBatchInTx, which runs create and update items together and is listed as mixed with a reason. Mutation-checked, each probe reverted afterwards. executeUpdate's EnteredIssuesPlane mint, PromoteFromEphemeralInTx's mint, or the batch's deferred create-shaped mint switched to RecordVersionInTx: each fails the create half. update.go's end-of-update mint switched to RecordVersionForCreateInTx: fails the update half for UpdateIssueInTx and every entry point that writes through it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(issueops): hold the dual-shape mint sites to both halves of the splitf006c871c5listed executeUpdate, moveIssuePersistenceInTx, finishCreateIssueInTx and CreateIssuesInTxWithContext (and the ExecuteUpdate/MoveIssuePersistenceInTx/create wrappers that delegate to them) as create-shaped, so TestUpdateShapedEntryPointsNeverMintCreateShaped skipped them. Each one also mints update-shaped, on its existing-row or same-plane branch, which is the common path: a guarded update of an existing row, the bd update --persistent repair of an issues-plane row's flags, a create or batch create that resolved to a row already there. Switching that branch to RecordVersionForCreateInTx stamped a legacy row out of legacy (R2.3), and every guard stayed green. Split the lists by what each function actually mints: - versionCreateShapedMintSites keeps only the pure create-shaped site, PromoteFromEphemeralInTx. It must call RecordVersionForCreateInTx and must not call RecordVersionInTx. - versionDualShapeMintSites names the four, each with its two branches. TestDualShapeMintSitesCallBothEntries requires each to call BOTH entries directly. A delegate does not count, for the same mintVersion=false and DeferVersionMint reasons as before. - versionCreateShapedEntryPoints keeps PromoteFromEphemeralInTx and deferredCreates.flush, which passes isNew=true for every row. - versionDualShapeEntryPoints replaces versionMixedShapeEntryPoints. It holds ApplyBatchInTx and the create, persistence-move and guarded-update entries that delegate to a dual-shape site, each with a reason. Each must reach both entries transitively. The update half skips the create-shaped and dual-shape entry points, as before. The update-shaped branch inside a dual-shape site is now the new test's to pin. Mutation-checked in a throwaway worktree. Switching the update-shaped mint to RecordVersionForCreateInTx at execution.go:301, persistence.go:97, create.go:260 or create.go:499 now fails TestDualShapeMintSitesCallBothEntries for that site. Before this commit, the whole issueops package stayed green under each of these switches. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(httpclient): run the participation-generation fence over the served wireedd3b72a1awaived all eleven ParticipationGeneration contracts on the http leg, saying the client had "no write flag to toggle and no raw column to read". That reason was wrong. served_dualwrite_history_test.go already flips the reference store's VersionedHistoryConfigurer and reads its raw columns, with the client driving the mutation. The waiver also hid the one harness that runs the fence behind the update a connected workspace actually sends. Every store leg's MutateExisting is store.UpdateIssue, but the served Lifecycle.Update reaches the guarded update, ExecuteUpdate. Add served_participation_generation_test.go on the same pattern: - Bound to the client: Mutate is Lifecycle.Create, MutateExisting is Lifecycle.Update, MovePersistent is the persistence-mode Lifecycle.Update that bd update --persistent sends, and PromoteWisp is issueops.Promote over the client's Reader/Lifecycle/Commenter, the entry bd promote dials over http. - Bound to the reference store, as before: SetFlag, the CreateWisp seed, and the raw reads. TestServedParticipationGenerationFence runs seven cases: CreateWithFlagOnStampsAValue, CreateWithFlagOffLeavesLegacyNull, SkipsUpdateOnLegacyRecord, ProceedsForPromotedRecord, FenceIgnoresSchemaSkewHatch, WispPromotionBeginsHistory and WispPersistenceMoveBeginsHistory. All seven pass, and no case turned up a server-side fence bug. Four cases stay waived, now with a reason that names the actual wire gap (participationGenerationWireGapWaiverReason): - WispFlagClearMintsNothing: the in-place {"wisp": false} is an untyped UpdateIssue, and IssuePatch.Persistence moves the row instead. - WispRootSquashMintsNothing: it needs RunInTransaction. That and UpdateIssue are both on the client's unsupported allowlist (D8). - UnflaggedWispCreateMintsNothing and NoHistoryIssueCreateDeclaresParticipation: both need WispPlaneOverride, which every create shape on the wire drops (roleIgnoredCreateIssueMembers). The new file is listed in httpclient_test's srcs. The served lane deals unpinned tests round-robin, so no shard manifest names it. Mutation-checked in a throwaway worktree. With execution.go:301 (the guarded update's update-shaped mint) switched to RecordVersionForCreateInTx, SkipsUpdateOnLegacyRecord and FenceIgnoresSchemaSkewHatch fail here ("version row count for hpg-legacy-skip went from 0 to 1"). The embeddeddolt and uow Participation|DualWrite|Version suites stay green under the same probe. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(conformance): an update never stamps a legacy no-history row7c00d65fa6made the seam write participation_generation on a flagged (NoHistory or Ephemeral) issues-table row when the call is create-shaped. Only the early `if IsWisp(issue) && !isCreate { return nil }` keeps an update-shaped call out of that branch, and nothing pinned it. The new contract and its subtest covered only the positive, create-shaped side. With the early return dropped, an ordinary update stamped a legacy no-history row out of legacy (R2.3), and every suite stayed green. Add RunParticipationGenerationLegacyNoHistoryIssueStaysLegacy beside NoHistoryIssueCreateDeclaresParticipation as its negative twin: 1. Create the no-history issues-table row with the flag OFF. 2. Turn the flag on and run MutateExisting. participation_generation must stay NULL, with 0 versions and current_revision unchanged. 3. Run MovePersistent, the bd update --persistent repair that clears the flag in place. The repair is update-shaped too, so the same three things must still hold. Wired on all four legs: dolt, embeddeddolt, uow and http. On http the case exercises the client's Lifecycle.Update and persistence update. Their precondition, the flag-off no-history create, is seeded through the reference store, because no client create can land that row in the issues table. That gap is also why the case whose SUBJECT is that create stays waived on http. Mutation-checked in a throwaway worktree, with the early return made `if false && IsWisp(issue) && !isCreate`. The new case fails on all four legs and is the only case that fails: "participation_generation for pg-no-history-legacy = 1 after an update-shaped mutation with the flag on, want NULL" (dolt server leg, embeddeddolt, uow and http). At tip it passes on all four. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * docs(issueops): say which table and which mint the fence comments mean Comment and doc corrections. No code changes. - RecordVersionForCreateInTx's doc comment covered a flagged issues-table row but not a wisps-table row. A row the wisps table holds mints and stamps nothing, whatever its flags say: there is no issues row to stamp (FR-8). That holds for an ordinary wisp create and for import's unflagged "wisp_plane" row. - The no-history stamp branch said the bd update --persistent repair mints update-shaped "(MoveIssuePersistenceInTx)". That is true only on the unit-of-work path. On dolt and embeddeddolt the repair goes through the guarded update: executeUpdate runs moveIssuePersistenceInTx with mintVersion=false and mints once at its own end. The fixture's MovePersistent doc already says this. - VERSIONED-BEADS-WRITE-PATHS.md row 13 still credited the whole wisp exclusion to `RecordVersionInTx returns on IsWisp` and called every case a NO-OP. Afterec52d29030, the table holding the row decides its plane: only an update-shaped call on a flagged wisp returns on IsWisp. Every other wisps-table row, including an unflagged one, is excluded by the issues-table participation_generation read, which finds no row. After7c00d65fa6, a create-shaped call on a flagged issues-table row is stamped but not versioned, so the row says that too. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * test(conformance): the wisps-table cases check the row is still a wisp runWispTableRowMintsNothing asserted 0 versions but never checked its own precondition, that the wisps table still holds the row. Suppose a step moved the row onto the issues plane through an update-shaped mint. That mint would hit the new row's NULL participation_generation and be fenced, so the count stayed 0 and the case passed without saying anything about a wisps-table row. - Add an InWispsTable hook to ParticipationGenerationFixture and bind it on dolt, embeddeddolt and uow as a raw wisps-table count. The wisps-table body now Fatals if the row is not in the wisps table after its steps. Each leg's KitIsWired test checks the hook. On http it stays nil with the other wisps-table hooks, whose cases are waived there. - The dolt ClearWispFlag hook now bites. A bare store.UpdateIssue on a wisp goes through updateWisp, whose transaction versioned history never scopes. So WispFlagClearMintsNothing passed on dolt with or without theec52d29030fix, as that commit's message admits. The hook now runs the lone flag clear in a RunInTransaction with the events journal on: the journal-enabled shape the SquashWispRoot hook already uses. - Both hooks go through a new withEventsJournal helper. It restores the store's previous journal setting rather than unconditionally setting it to false afterwards, which assumed the store started with the journal off. Mutation-checked in throwaway worktrees: - With version_history.go atec52d29030^, dolt's WispFlagClearMintsNothing now fails ("read participation_generation for pg-flag-clear: sql: no rows in result set"). It used to pass there. - Embedded ClearWispFlag rerouted as a flag-off persistence move followed by a flag-on title update: the case fails on the new precondition ("is not in the wisps table after flag-clear"). With the precondition disabled, the same probe passes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * fix(storage): review fixups for the participation_generation fence The review ofd17b716115approved the PR with no required changes and raised four minors and three nits. Each one below says what changed and why, or why it did not. Minor 1, the upsert create's new-or-existing choice was untested. The unit-of-work create that is not CreateOnly (bd batch, bd todo, tracker sync and mol port) inserts through an upsert, and db.Insert's existed probe picks the mint's shape; forcing it either way shipped green. The new uow TestParticipationGenerationUpsertCreate pins all three outcomes: a new row is stamped and begins its history, a legacy row the upsert resolves to stays legacy with no version, and a participating row mints exactly one more. No served-route case is added because every served create is CreateOnly (uow createParams), so the http wire cannot reach this branch. The cmd/bd proxied-server batch and todo creates call this same use-case method. Minor 2, an update-shaped mint still lets issues.updated_at move through ON UPDATE CURRENT_TIMESTAMP. Not changed here. The maintainer listed it on the PR as follow-up (2), and the approving review ofd17b716115accepted carrying it as a follow-up. It does not change the fence's contract as pinned. Minor 3, the depadd and waitsfor goldens had been re-recorded to zero issue_versions rows. Their seeds run with history off, so every seeded row was legacy and the harness stopped checking the dependency-add, close and reopen mints. Both scenarios now stamp their seeded issues-table rows after the seed (stampParticipation; wisps stay unstamped). Their goldens are back to main's pre-fence files byte for byte: depadd mints 11 version rows and waitsfor 15. The fenced legacy outcome stays pinned by small, import458 and import458-reject-stale. A run scenario that mints no version row now fails rather than recording an empty digest. Minor 4, PromoteFromEphemeralInTx always minted create-shaped. When the issues plane already held the id (the dual presence GH#4455 records), its upsert resolved to that row and the create-shaped mint stamped a legacy record (R2.3). It now keeps InsertIssueIfNew's isNew and mints update-shaped for an existing row, as finishCreateIssueInTx does. The version guard lists it as a dual-shape mint site and entry point, and PromoteOverDualPresenceKeepsLegacy pins the behavior at run time. Nit 1: with versioned history off, db.Insert skips the existed probe, since both mint entries return before reading anything. A create costs the round trips it did before the fence. Nit 2: the MINT COST comment now counts the fence read (about 6 to 7 round trips) and no longer says the snapshot reads current_revision; the fence read can select it for #6379's ordinal seed. Moving that read now would only add a column nothing consumes yet. Nit 3: the http leg's participation-generation wire-gap waiver opens as PENDING and names the wire mutation that would retire each case. Validation, in a scrubbed env with -tags=gms_pure_go on embedded and server Dolt (all pass, none skipped): - uow: TestParticipationGenerationFence, its FixtureKitIsWired check and TestParticipationGenerationUpsertCreate with its 4 subtests. - embeddeddolt: the create-batch equivalence parts (small/depadd, apply/waitsfor), the parts-coverage guard, the large scenarios, and the fence and kit. - dolt: TestCreateBatchFastPathsMatchPerRow_Dolt, the fence, FenceIgnoresSchemaSkewHatch and the kit. - httpclient: TestServedParticipationGenerationFence. - TestEveryLegWiresEveryRoleContract, the issueops structural guards, and the issueops, storage and domain/db packages. Eleven mutants, graded in 13 runs, each fail the test meant to catch them: - upsert always create-shaped or always update-shaped; - the probe guard inverted; - promote always create-shaped or always update-shaped; - the seed left unstamped; - the dependency-add, close or reopen mint dropped; - two on-disk single-entry promotes. Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(storage): a wisp upsert must not stamp a legacy issues twin domain/db's Insert chose the mint shape of its upsert (the create that is not CreateOnly) from an existence probe of the target table. For a wisps-table insert that probe asks the wrong plane: the seam snapshots the issues table first (GetIssueInTx), so when the issues plane already held the id as a legacy row, the wisp create took the create-shaped mint and stamped and versioned that untouched twin. An ordinary wisp write promoted a legacy record, which R2.3 forbids. bd mol port and the proxied mol and wisp writers call CreateWisp this way. It is latent until versioned history is enabled (#6661). A wisps-table insert never creates an issues row, so it now mints update-shaped, without the probe. The fence leaves a legacy twin alone, a wisp-only id still mints nothing through either entry (FR-8), and a participating twin mints the one version main already minted for it. Insert's comment now records that last case: the dual presence predates the fence, and this upsert does not refuse it the way issueops' create path does. TestParticipationGenerationUpsertCreate gains WispOverLegacyIssuesRowKeepsItLegacy, which fails against the previous dispatch (twin stamped, one version row). Also from review: the version shape guard names the dual-shape site its parse cannot see, and the row-lock exemption comment counts all three of the seam's UPDATE issues statements. Agent-Signature: claude-code-claude-opus-5-5-max on behalf of Julian Knutsen Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Julian Knutsen <julianknutsen@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Co-authored-by: Eddie the Engineer <338826946+gascity-eddie[bot]@users.noreply.github.com>
371 lines
12 KiB
Python
371 lines
12 KiB
Python
load("@rules_go//go:def.bzl", "go_library", "go_test")
|
|
load("@rules_shell//shell:sh_test.bzl", "sh_test")
|
|
|
|
go_library(
|
|
name = "httpclient",
|
|
srcs = [
|
|
"accessors.go",
|
|
"backend_credential.go",
|
|
"batchapplier.go",
|
|
"batchcloser.go",
|
|
"batchcreator.go",
|
|
"batchgetter.go",
|
|
"blocked_querier.go",
|
|
"blocked_recomputer.go",
|
|
"blockedlister.go",
|
|
"bridge.go",
|
|
"ca.go",
|
|
"ca_permissions_other.go",
|
|
"ca_permissions_unix.go",
|
|
"claimer.go",
|
|
"commenter.go",
|
|
"conn_share.go",
|
|
"counter.go",
|
|
"credential.go",
|
|
"deleter.go",
|
|
"dependencyeditor.go",
|
|
"detail_reads.go",
|
|
"dial.go",
|
|
"dispatch.go",
|
|
"errors.go",
|
|
"heartbeater.go",
|
|
"insecure_credential_guard.go",
|
|
"journal.go",
|
|
"leasereclaimer.go",
|
|
"lifecycle.go",
|
|
"list_walk.go",
|
|
"memories.go",
|
|
"metadata.go",
|
|
"metadatacas.go",
|
|
"molecule.go",
|
|
"offrole.go",
|
|
"open_with.go",
|
|
"order.go",
|
|
"readyclaimer.go",
|
|
"refusal.go",
|
|
"register.go",
|
|
"relations.go",
|
|
"releaser.go",
|
|
"resolve.go",
|
|
"role_querier.go",
|
|
"role_reader.go",
|
|
"role_readycounter.go",
|
|
"roles_aux.go",
|
|
"roles_graph.go",
|
|
"servercontext.go",
|
|
"store.go",
|
|
"sweeper.go",
|
|
"target.go",
|
|
"target_seam.go",
|
|
"unlimited_read.go",
|
|
"unsupported.go",
|
|
"unsupported_gen.go",
|
|
"vocabulary.go",
|
|
"watch.go",
|
|
"writewire.go",
|
|
],
|
|
importpath = "github.com/steveyegge/beads/internal/httpclient",
|
|
visibility = ["//:__subpackages__"],
|
|
deps = [
|
|
"//internal/config",
|
|
"//internal/configfile",
|
|
"//internal/creds",
|
|
"//internal/httpapi/apigen",
|
|
"//internal/httpclient/encode",
|
|
"//internal/httpclient/wire",
|
|
"//internal/storage",
|
|
"//internal/storage/backends",
|
|
"//internal/storage/issueops",
|
|
"//internal/storage/sqlbuild",
|
|
"//internal/types",
|
|
"//internal/utils",
|
|
"//issueops",
|
|
"//journalops",
|
|
"//memoryops",
|
|
"@org_golang_x_net//http/httpproxy",
|
|
"@org_golang_x_net//idna",
|
|
],
|
|
)
|
|
|
|
go_test(
|
|
name = "httpclient_test",
|
|
# Unsharded, this package took 137-228s on rbe-west under --config=ci
|
|
# (BEADS_TEST_SKIP=dolt, no BEADS_TEST_EMBEDDED_DOLT; 2026-10-09), the test lane's
|
|
# longest single action. Two shards (rules_go deals tests out round-robin) put
|
|
# ~68s of measured test time on each; the three heaviest tests (31s, 20s, 13s)
|
|
# land on different shards. size=large/timeout=long follows the same convention
|
|
# as //internal/storage/embeddeddolt's go_test.
|
|
size = "large",
|
|
timeout = "long",
|
|
srcs = [
|
|
"backend_credential_test.go",
|
|
"batchapplier_test.go",
|
|
"blocked_querier_test.go",
|
|
"blockedlister_test.go",
|
|
"brief_test.go",
|
|
"bulk_roles_test.go",
|
|
"ca_permissions_unix_test.go",
|
|
"ca_test.go",
|
|
"ca_wrong_ca_test.go",
|
|
"completeness_test.go",
|
|
"composition_test.go",
|
|
"conn_share_test.go",
|
|
"counts_test.go",
|
|
"create_priority_test.go",
|
|
"credential_source_test.go",
|
|
"credential_test.go",
|
|
"dial_header_timeout_test.go",
|
|
"dial_test.go",
|
|
"dispatch_test.go",
|
|
"divergence_citation_gate_test.go",
|
|
"divergence_test.go",
|
|
"expected_revision_contract_test.go",
|
|
"gate_fields_test.go",
|
|
"getissue_miss_test.go",
|
|
"heartbeater_test.go",
|
|
"helpers_test.go",
|
|
"insecure_credential_guard_test.go",
|
|
"lifecycle_create_test.go",
|
|
"lifecycle_update_test.go",
|
|
"list_filters_test.go",
|
|
"list_scope_test.go",
|
|
"list_search_test.go",
|
|
"list_sort_test.go",
|
|
"memo_key_test.go",
|
|
"memo_retry_test.go",
|
|
"metadatacas_test.go",
|
|
"molecule_test.go",
|
|
"open_with_test.go",
|
|
"race_detector_off_test.go",
|
|
"race_detector_on_test.go",
|
|
"required_served_tier_test.go",
|
|
"roles_graph_cycles_test.go",
|
|
"roles_test.go",
|
|
"served_batch_apply_large_test.go",
|
|
"served_batch_apply_test.go",
|
|
"served_batch_close_test.go",
|
|
"served_batch_getter_test.go",
|
|
"served_blocked_external_test.go",
|
|
"served_blocked_lister_test.go",
|
|
"served_bridge_test.go",
|
|
"served_bulk_test.go",
|
|
"served_claim_lifecycle_test.go",
|
|
"served_commenter_test.go",
|
|
"served_config_test.go",
|
|
"served_config_write_test.go",
|
|
"served_counter_test.go",
|
|
"served_detail_reads_test.go",
|
|
"served_dualrun_test.go",
|
|
"served_dualwrite_history_test.go",
|
|
"served_external_dependency_policy_test.go",
|
|
"served_graph_aux_test.go",
|
|
"served_graph_counter_test.go",
|
|
"served_harness_test.go",
|
|
"served_heartbeater_test.go",
|
|
"served_hooks_test.go",
|
|
"served_issue_operations_test.go",
|
|
"served_journal_test.go",
|
|
"served_large_apply_timeout_test.go",
|
|
"served_lease_reclaimer_test.go",
|
|
"served_lifecycle_create_test.go",
|
|
"served_list_test.go",
|
|
"served_memories_deps_test.go",
|
|
"served_metadata_cas_test.go",
|
|
"served_molecule_test.go",
|
|
"served_participation_generation_test.go",
|
|
"served_project_swap_test.go",
|
|
"served_querier_test.go",
|
|
"served_reader_test.go",
|
|
"served_ready_claimer_test.go",
|
|
"served_readycounter_test.go",
|
|
"served_relations_test.go",
|
|
"served_releaser_test.go",
|
|
"served_test.go",
|
|
"served_unlimited_read_test.go",
|
|
"served_wrong_server_test.go",
|
|
"store_dependent_test.go",
|
|
"store_test.go",
|
|
"target_test.go",
|
|
"unlimited_read_test.go",
|
|
"update_persistence_test.go",
|
|
"watch_test.go",
|
|
"wave2b_roles_test.go",
|
|
"wave2c_claimnext_test.go",
|
|
"wave2c_config_test.go",
|
|
"wave2c_journal_test.go",
|
|
"write_ledger_test.go",
|
|
"write_roles_test.go",
|
|
],
|
|
# keep
|
|
#
|
|
# TestInterfaceCompleteness (completeness_test.go) reads its own package's
|
|
# generated shell, unsupported_gen.go, by a plain relative os.ReadFile to
|
|
# regex-match the methods storage.DoltStorage's refusing shell covers. That
|
|
# file is already a `srcs` member of :httpclient above, which Bazel compiles
|
|
# away rather than leaving as a readable file in the test's sandbox; `data`
|
|
# is what actually puts a copy there, exactly as
|
|
# //internal/httpclient/encode's own go_test does for the same reason.
|
|
# Gazelle does not manage `data` on this rule, so this survives
|
|
# `make bazel-sync` (the directive just says so).
|
|
data = glob(["*.go"]),
|
|
embed = [":httpclient"],
|
|
shard_count = 2,
|
|
deps = [
|
|
"//:beads",
|
|
"//backend/conformance",
|
|
"//internal/eventsjournal",
|
|
"//internal/hooks",
|
|
"//internal/httpapi",
|
|
"//internal/httpapi/apigen",
|
|
"//internal/httpapi/spec",
|
|
"//internal/httpclient/encode",
|
|
"//internal/httpclient/wire",
|
|
"//internal/storage",
|
|
"//internal/storage/backends",
|
|
"//internal/storage/batchfixtures",
|
|
"//internal/storage/domain",
|
|
"//internal/storage/embeddeddolt",
|
|
"//internal/storage/externaldeps",
|
|
"//internal/storage/issueops",
|
|
"//internal/storage/sqlbuild",
|
|
"//internal/types",
|
|
"//internal/workapi",
|
|
"//issueops",
|
|
"//journalops",
|
|
"//memoryops",
|
|
"@in_gopkg_yaml_v3//:yaml_v3",
|
|
],
|
|
)
|
|
|
|
# scripts/conformance.sh's Tier 3, the served HTTP corpus: the whole package
|
|
# with BEADS_TEST_EMBEDDED_DOLT=1, so the served_*_test.go cases stand a real
|
|
# `bd serve` handler over embedded Dolt instead of skipping as they do in
|
|
# httpclient_test above, and BEADS_HTTP_TEST_REQUIRED=1, so a missing engine
|
|
# fails each served case rather than skipping it. It is the script's run on
|
|
# the lane's race build (raceEnabled shrinks its one large apply).
|
|
#
|
|
# Shard count: on the lane's executors (rbe-west, 2026-10-09, the whole
|
|
# embedded lane running) the package is ~750 top-level tests and ~1,100
|
|
# test-seconds, all serial, the heaviest about 52s. Each served case copies
|
|
# one per-process template workspace instead of initializing its own embedded
|
|
# Dolt schema (served_harness_test.go's servedTemplateWorkspace), and
|
|
# TestServedBatchGetterContract seeds its 1000 issues in one write: before
|
|
# both, the package was ~3,700 test-seconds over 24 shards, the heaviest shard
|
|
# 390s. rules_go's round-robin alone (16 shards) left shards at 40-119s,
|
|
# wherever its split dropped the long tests, so the tests measured at >= 3s
|
|
# (the maximum over three whole-lane runs) are pinned
|
|
# (tools/bazel/go_test_pinned_shard.sh, served_pinned_shards.txt from
|
|
# tools/bazel/pin_shards.py --shards 17 --min-seconds 3) onto 17 shards, and
|
|
# the binary's round-robin deals the other ~650 (~340s of measured test
|
|
# time; those shards ran ~1.4x their tests' summed times) over the remaining
|
|
# 9.
|
|
# Regenerate the manifest from runs of the lane:
|
|
# bazel test //... --config=embedded
|
|
# python3 tools/bazel/pin_shards.py --shards 17 --min-seconds 3 \
|
|
# --write internal/httpclient/served_pinned_shards.txt \
|
|
# bazel-testlogs/internal/httpclient/httpclient_served_test
|
|
#
|
|
# Tags:
|
|
# embedded: the embedded-Dolt tier; excluded from --config=prcore/ci,
|
|
# selected by --config=embedded.
|
|
sh_test(
|
|
name = "httpclient_served_test",
|
|
size = "large",
|
|
# Deviation from the script's -timeout=40m: Bazel ends the action at
|
|
# 1200s (eternal under --config=embedded), and rules_go's wrapper ignores
|
|
# that SIGTERM, so a hang would end as a bare TIMEOUT. 19m lets Go's own
|
|
# timeout fire first and dump every goroutine to test.log.
|
|
timeout = "eternal",
|
|
srcs = ["//tools/bazel:go_test_pinned_shard.sh"],
|
|
args = [
|
|
"$(rootpath :served_pinned_shards.txt)",
|
|
"$(rootpath :httpclient_test)",
|
|
"-test.v",
|
|
"-test.count=1",
|
|
"-test.timeout=19m",
|
|
],
|
|
data = [
|
|
"served_pinned_shards.txt",
|
|
":httpclient_test",
|
|
],
|
|
env = {
|
|
"BEADS_HTTP_TEST_REQUIRED": "1",
|
|
"BEADS_TEST_EMBEDDED_DOLT": "1",
|
|
},
|
|
shard_count = 26,
|
|
tags = ["embedded"],
|
|
)
|
|
|
|
# --- begin go_srcs (managed by tools/bazel/go_srcs.py; run `make bazel-sync`) ---
|
|
|
|
filegroup(
|
|
name = "go_srcs",
|
|
srcs = glob(
|
|
["**/*.go"],
|
|
allow_empty = True,
|
|
),
|
|
visibility = ["//:__subpackages__"],
|
|
)
|
|
|
|
# --- end go_srcs ---
|
|
|
|
# --- begin repo_files (managed by tools/bazel/go_srcs.py; run `make bazel-sync`) ---
|
|
|
|
filegroup(
|
|
name = "repo_doc_files",
|
|
srcs = glob(
|
|
[
|
|
"**/*.md",
|
|
"**/*.mdx",
|
|
],
|
|
allow_empty = True,
|
|
exclude = ["**/node_modules/**"],
|
|
),
|
|
visibility = ["//:__subpackages__"],
|
|
)
|
|
|
|
filegroup(
|
|
name = "repo_go_srcs",
|
|
srcs = glob(
|
|
["**/*.go"],
|
|
allow_empty = True,
|
|
exclude = [
|
|
"**/*_test.go",
|
|
"**/node_modules/**",
|
|
],
|
|
),
|
|
visibility = ["//:__subpackages__"],
|
|
)
|
|
|
|
filegroup(
|
|
name = "repo_go_test_srcs",
|
|
srcs = glob(
|
|
["**/*_test.go"],
|
|
allow_empty = True,
|
|
exclude = ["**/node_modules/**"],
|
|
),
|
|
visibility = ["//:__subpackages__"],
|
|
)
|
|
|
|
filegroup(
|
|
name = "repo_other_files",
|
|
srcs = glob(
|
|
["**"],
|
|
exclude = [
|
|
"**/*.db",
|
|
"**/*.exe",
|
|
"**/*.go",
|
|
"**/*.md",
|
|
"**/*.mdx",
|
|
"**/*.out",
|
|
"**/*.prof",
|
|
"**/*.pyc",
|
|
"**/*.test",
|
|
"**/__pycache__/**",
|
|
"**/node_modules/**",
|
|
],
|
|
),
|
|
visibility = ["//:__subpackages__"],
|
|
)
|
|
|
|
# --- end repo_files ---
|